Re: branching for 9.2devel
От
Pavan Deolasee
Тема
Re: branching for 9.2devel
Дата
Msg-id
BANLkTin=8zFUgAYkH0-AnNE6wMcvGCyP2g@mail.gmail.com
Ответ на
Re: branching for 9.2devel (Andrew Dunstan)
Список
Дерево обсуждения
branching for 9.2devel Robert Haas <robertmhaas@gmail.com>
Re: branching for 9.2devel Peter Eisentraut <peter_e@gmx.net>
Re: branching for 9.2devel Tom Lane <tgl@sss.pgh.pa.us>
Re: branching for 9.2devel Greg Stark <gsstark@mit.edu>
Re: branching for 9.2devel Tom Lane <tgl@sss.pgh.pa.us>
Re: branching for 9.2devel Greg Stark <gsstark@mit.edu>
Re: branching for 9.2devel Tom Lane <tgl@sss.pgh.pa.us>
Re: branching for 9.2devel Andrew Dunstan <andrew@dunslane.net>
Re: branching for 9.2devel Tom Lane <tgl@sss.pgh.pa.us>
Re: branching for 9.2devel Andrew Dunstan <andrew@dunslane.net>
Re: branching for 9.2devel Tom Lane <tgl@sss.pgh.pa.us>
Re: branching for 9.2devel Andrew Dunstan <andrew@dunslane.net>
Re: branching for 9.2devel Tom Lane <tgl@sss.pgh.pa.us>
Re: branching for 9.2devel Alvaro Herrera <alvherre@commandprompt.com>
Re: branching for 9.2devel Bruce Momjian <bruce@momjian.us>
Re: branching for 9.2devel Andrew Dunstan <andrew@dunslane.net>
Re: branching for 9.2devel Tom Lane <tgl@sss.pgh.pa.us>
Re: branching for 9.2devel Andrew Dunstan <andrew@dunslane.net>
Re: branching for 9.2devel Andrew Dunstan <andrew@dunslane.net>
Re: branching for 9.2devel Greg Stark <gsstark@mit.edu>
Re: branching for 9.2devel Tom Lane <tgl@sss.pgh.pa.us>
Re: branching for 9.2devel "Greg Sabino Mullane" <greg@turnstep.com>
Re: branching for 9.2devel "Joshua D. Drake" <jd@commandprompt.com>
Re: branching for 9.2devel Pavan Deolasee <pavan.deolasee@gmail.com>
Re: branching for 9.2devel David Blewett <david@dawninglight.net>
Re: branching for 9.2devel David Blewett <david@dawninglight.net>
Re: branching for 9.2devel Andrew Dunstan <andrew@dunslane.net>
Re: branching for 9.2devel Tom Lane <tgl@sss.pgh.pa.us>
Re: branching for 9.2devel Josh Berkus <josh@agliodbs.com>
Re: branching for 9.2devel Magnus Hagander <magnus@hagander.net>
Re: branching for 9.2devel David Blewett <david@dawninglight.net>
Re: branching for 9.2devel Robert Haas <robertmhaas@gmail.com>
Re: branching for 9.2devel Jim Nasby <jim@nasby.net>
Re: branching for 9.2devel David Christensen <david@endpoint.com>
Re: branching for 9.2devel Simon Riggs <simon@2ndQuadrant.com>
Re: branching for 9.2devel Christopher Browne <cbbrowne@gmail.com>
Re: branching for 9.2devel Aidan Van Dyk <aidan@highrise.ca>
Re: branching for 9.2devel "Kevin Grittner" <Kevin.Grittner@wicourts.gov>
Re: branching for 9.2devel Tom Lane <tgl@sss.pgh.pa.us>
Re: branching for 9.2devel David Blewett <david@dawninglight.net>
Re: branching for 9.2devel Andrew Dunstan <andrew@dunslane.net>
Re: branching for 9.2devel Robert Haas <robertmhaas@gmail.com>
Re: branching for 9.2devel Tom Lane <tgl@sss.pgh.pa.us>
Re: branching for 9.2devel Josh Berkus <josh@agliodbs.com>
Re: branching for 9.2devel Tom Lane <tgl@sss.pgh.pa.us>
Re: branching for 9.2devel Greg Smith <greg@2ndQuadrant.com>
Re: branching for 9.2devel Robert Haas <robertmhaas@gmail.com>
Re: branching for 9.2devel "Joshua D. Drake" <jd@commandprompt.com>
Re: branching for 9.2devel Robert Haas <robertmhaas@gmail.com>
Re: branching for 9.2devel Josh Berkus <josh@agliodbs.com>
Re: branching for 9.2devel Tom Lane <tgl@sss.pgh.pa.us>
Re: branching for 9.2devel Stephen Frost <sfrost@snowman.net>
Re: branching for 9.2devel Steve Singer <ssinger_pg@sympatico.ca>
Re: branching for 9.2devel Robert Haas <robertmhaas@gmail.com>
Re: branching for 9.2devel Robert Haas <robertmhaas@gmail.com>
Re: branching for 9.2devel Stephen Frost <sfrost@snowman.net>
Re: branching for 9.2devel Simon Riggs <simon@2ndQuadrant.com>
Re: branching for 9.2devel Joshua Berkus <josh@agliodbs.com>
Re: branching for 9.2devel Robert Haas <robertmhaas@gmail.com>
Re: branching for 9.2devel Joshua Berkus <josh@agliodbs.com>
Re: branching for 9.2devel Robert Haas <robertmhaas@gmail.com>
Re: branching for 9.2devel Joshua Berkus <josh@agliodbs.com>
Re: branching for 9.2devel "Kevin Grittner" <Kevin.Grittner@wicourts.gov>
Re: branching for 9.2devel Tom Lane <tgl@sss.pgh.pa.us>
Re: branching for 9.2devel Joshua Berkus <josh@agliodbs.com>
Re: branching for 9.2devel "Kevin Grittner" <Kevin.Grittner@wicourts.gov>
Re: branching for 9.2devel Robert Haas <robertmhaas@gmail.com>
Re: branching for 9.2devel Robert Treat <rob@xzilla.net>
Re: branching for 9.2devel "Kevin Grittner" <Kevin.Grittner@wicourts.gov>
Re: branching for 9.2devel Robert Treat <rob@xzilla.net>
Re: branching for 9.2devel "Kevin Grittner" <Kevin.Grittner@wicourts.gov>
Re: branching for 9.2devel Andrew Dunstan <andrew@dunslane.net>
Re: branching for 9.2devel Simon Riggs <simon@2ndQuadrant.com>
On Tue, Apr 26, 2011 at 2:25 AM, Andrew Dunstan <andrew@dunslane.net> wrote:
Well, my solution would be to replace pgindent with a perl script (among other advantages, it would then run everywhere we build, including Windows), and filter the typedefs list so that we only use the ones that appear in each file with that file, instead of passing the whole list to each file.
On 04/25/2011 04:28 PM, Tom Lane wrote:Andrew Dunstan<andrew@dunslane.net> writes:On 04/25/2011 03:30 PM, Tom Lane wrote:Oh wow, I never noticed that. That's going to be a severe problem for*Ouch*. Really? It's hard to believe that anyone would consider itLooks like BSD does the same. It's just that we hide it in pgindent:
remotely usable for more than toy-sized projects, if you have to list
all the typedef names on the command line.
the "run it anywhere" goal. The typedefs list is already close to 32K,
and is not going anywhere but up. There are already platforms on which
a shell command line that long will fail, and I think once we break past
32K we might find it failing on even pretty popular ones.
Can we not setup a automatic mechanism where a submitter can send a patch to some email id, the patch gets applied on the current HEAD, pgindent is run and the new patch is sent back to the submitter who can then submit it to the hackers for review. If the patch does not apply cleanly, the same can also be emailed back to the submitter.
Thanks,
Pavan
--
Pavan Deolasee
EnterpriseDB http://www.enterprisedb.com
В списке pgsql-hackers по дате отправления