On Tue, Nov 23, 2010 at 10:21 PM, David Fetter <david@fetter.org> wrote:
> Please find attached a patch changing both this and "updateable" to
> "updatable," also per the very handy git grep I just learned about :)
I looked a little more at this patch today. I didn't find any serious
problems, though it would have helped me (and maybe other reviewers)
to have a comprehensive list of the SQL statements which the patch
implements autocompletion for.
Not sure how hard this would be to add in, but the following gets
autocompleted with an INSERT: CREATE TRIGGER mytrg BEFORE IN[TAB]
while the following doesn't find any autocompletions: CREATE TRIGGER mytrg BEFORE INSERT OR UP[TAB]
Also, this existed before the patch, but this SQL: CREATE TRIGGER mytrg INSTEAD OF INSERT ON [TAB]
autocompletes to: CREATE TRIGGER mytrg INSTEAD OF INSERT ON SET
not sure how that "SET" is getting in there -- some incorrect tab
completion match?
Josh