Re: Tab completion for view triggers in psql

Поиск
Список
Период
Сортировка
От Itagaki Takahiro
Тема Re: Tab completion for view triggers in psql
Дата
Msg-id AANLkTimh=mfPoa8YG78UfCZdQ9JNDEKcaTbRis6vJrZ7@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Tab completion for view triggers in psql  (David Fetter <david@fetter.org>)
Ответы Re: Tab completion for view triggers in psql  (David Fetter <david@fetter.org>)
Список pgsql-hackers
On Tue, Nov 30, 2010 at 18:18, David Fetter <david@fetter.org> wrote:
>> It expands all tables (and views) in tab-completion after INSERT,
>> UPDATE, and DELETE FROM.  Is it an intended change?

I found it was a simple bug; we need ( ) around selcondition.

In addition, I modified your patch a bit:

* I added a separated CREATE TRIGGER INSTEAD OF if-branch
  because it doesn't accept tables actually; it only accepts
  views. OTOH, BEFORE or AFTER only accepts tables.

* I think "t.tgtype & (1 << N) <> 0" is more natural
  bit operation than "t.tgtype | (1 << N) = t.tgtype".

Patch attached. If you think my changes are ok,
please change the patch status to "Ready for Committer".

--
Itagaki Takahiro

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Heikki Linnakangas
Дата:
Сообщение: Re: GiST insert algorithm rewrite
Следующее
От: Csaba Nagy
Дата:
Сообщение: Re: DELETE with LIMIT (or my first hack)