Обсуждение: pgAdmin4 PATCH: Domain Module

Hi

On Wed, Mar 16, 2016 at 9:18 AM, Khushboo Vashi
<khushboo.vashi@enterprisedb.com> wrote:
>
>>> - Owner and schema should be allowed to be left blank (and then default
>>> to the current user/schema)
>
> Done

Oh, sorry - that design changed a while back, and I've updated all the
existing nodes already. I thought I'd mentioned that. All we do now is
pre-set the default values for those two fields.

>>> - When adding constraints, I should be able to type directly into the
>>> grid. Expanding the row should be optional.
>
> I have made the grid non-editable explicitly as the Check constraint control
> is multi-line control and right now there is no support in the grid for the
> multi-line control.

Not sure I follow - the mockup design you sent months ago allowed you
to type into the grid, and expand a row to show all fields if you
wanted. That is an *absolutely essential* feature enhancement for
pgAdmin 4 - it's required by the table design (though this will change
a little in other ways, like positioning of the expand row button),
and should be used here:
https://www.lucidchart.com/documents/edit/610ce42d-c397-48ff-a5e7-bd92c4995715/0

>>> - The comment column on the constraints grid expands when the text
>>> reaches ~50% of the width. It should be a fixed size (and use 100% of the
>>> space available, less appropriate margins)
>
> I have applied the size for the each header of the grid, but if the given
> input will be without space in the grid then it will expand. For this, we
> can make table layout fixed. So, please suggest, should I do that or not?

Yes, I think it should be fixed. If the grid row is expanded,
presumably it'll show in a multi-line field anyway? Plus the
properties will use a multi-line field as well.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Hi

On Wed, Mar 16, 2016 at 2:03 PM, Khushboo Vashi
<khushboo.vashi@enterprisedb.com> wrote:
> Hi,
>
> Please find the updated Domain Module Patch.
>
> To test this patch, please apply Backgrid Textarea Cell Patch before this.

Thanks. I believe with the following fixes, we'll be done :-)

- Default values should be auto-quoted when necessary (ie. strings, on
a text-based domain).

- "System Domain?" should be in the General section, between owner and comment.

- The switches should use the same colouring/styling as other objects, e.g.

          options: {
            'onText': 'Yes', 'offText': 'No',
            'onColor': 'success', 'offColor': 'primary',
            'size': 'small'
          }

- Please remove the Schema property from the main properties tab (not
the properties dialogue).

- No icon is show for Checks on the Dependents tab for a domain.

- The add button on the Security Labels tab is spelt "Add". Why is
that? Other instances of this grid use "ADD" which is the default in
backform.pgadmin.js.

- Dependencies on domain check constraints are listed as being on a
"Type" not a "Domain".

- If adding a domain constraint using the grid on the Domain dialogue,
I cannot specify "NOT VALID". We need a checkbox for that in a narrow
columns at the end. Unchecking it for an existing constraint should be
the equivalent of doing "ALTER DOMAIN ... VALIDATE CONSTRAINT"

- If I switch the "Don't Validate" switch on a constraint, there are
leading blank lines in the generated SQL. The same occurs when adding
a comment to a constraint.

- I think we need to reverse the meaning of "Don't Validate" and
rename to match the "Valid?" field that's on the properties list.
Otherwise it's not clear they're the same thing.

- s/Not Null/Not Null?/


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Thu, Mar 17, 2016 at 5:39 PM, Khushboo Vashi
<khushboo.vashi@enterprisedb.com> wrote:
> Hi Dave,
>
> I have a query regarding your below feedback :
>
> - Default values should be auto-quoted when necessary (ie. strings, on a
> text-based domain).
>
> To resolve this, I have checked the typcategory field from pg_type for the
> base_type selected for the Domain.
> If the typcategory is String type  (i.e. S), then only I have used qtLiteral
> function to quote the default value.
>
> Is this right approach or not?

Yes, I think that's a good approach (at least, I don't see any
downsides right now :-) )



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Mon, Mar 21, 2016 at 7:41 AM, Khushboo Vashi
<khushboo.vashi@enterprisedb.com> wrote:
> Hi Dave,
>
>
> On Fri, Mar 18, 2016 at 8:31 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> On Thu, Mar 17, 2016 at 5:39 PM, Khushboo Vashi
>> <khushboo.vashi@enterprisedb.com> wrote:
>> > Hi Dave,
>> >
>> > I have a query regarding your below feedback :
>> >
>> > - Default values should be auto-quoted when necessary (ie. strings, on a
>> > text-based domain).
>> >
>> > To resolve this, I have checked the typcategory field from pg_type for
>> > the
>> > base_type selected for the Domain.
>> > If the typcategory is String type  (i.e. S), then only I have used
>> > qtLiteral
>> > function to quote the default value.
>> >
>> > Is this right approach or not?
>>
>> Yes, I think that's a good approach (at least, I don't see any
>> downsides right now :-) )
>>
>
> After implementing above approach, I found some issues:
>
> 1> If I put quotes explicitly, user can not set any expression as a default
> value
>     For example,
>
>  CREATE OR REPLACE FUNCTION test_text_return() RETURNS TEXT AS
> $$
>  SELECT now()::text;
> $$ LANGUAGE 'sql';
>
>
> CREATE DOMAIN text_domin AS TEXT DEFAULT public.test_text_return();
>
>      In this case, if I put quotes for default value, it will be set as a
> string rather than an expression.
>
>
> 2> When I set any string for the default value, it is getting stored with
> the datatype like 'test_default'::text
>      So, in the Default Value (Properties Dialogue), it is showing
> 'test_default'::text
>
>       I have tried pg_get_expr(typdefaultbin, 0) to fetch only default value
> (without datatype), but it returns the whole expression.
>
>
> As per my discussion with Ashesh, we feel - we should not quote the default
> value after looking at the above example.
>
> Please, let me know what should I do further?

Urgh, yes - I hadn't thought of that. Leave it unquoted please.

I guess we can add a hint to the field:

Enter an expression or value.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Did you forget to attach the latest patch?

On Wed, Mar 23, 2016 at 7:27 AM, Khushboo Vashi
<khushboo.vashi@enterprisedb.com> wrote:
> Updated one comment.
>
> On Wed, Mar 23, 2016 at 12:48 PM, Khushboo Vashi
> <khushboo.vashi@enterprisedb.com> wrote:
>>
>> Hi,
>>
>> Please find attached updated patch for the Domains module.
>>
>> On Wed, Mar 16, 2016 at 9:40 PM, Dave Page <dpage@pgadmin.org> wrote:
>>>
>>> Hi
>>>
>>> On Wed, Mar 16, 2016 at 2:03 PM, Khushboo Vashi
>>> <khushboo.vashi@enterprisedb.com> wrote:
>>> > Hi,
>>> >
>>> > Please find the updated Domain Module Patch.
>>> >
>>> > To test this patch, please apply Backgrid Textarea Cell Patch before
>>> > this.
>>>
>>> Thanks. I believe with the following fixes, we'll be done :-)
>>>
>>> - Default values should be auto-quoted when necessary (ie. strings, on
>>> a text-based domain).
>>
>> As per our discussion, this should leave unquoted.
>
> And also added a hint to the field stated 'Enter an expression or a value.'
>>
>>
>>> - "System Domain?" should be in the General section, between owner and
>>> comment.
>>
>> Done
>>>
>>> - The switches should use the same colouring/styling as other objects,
>>> e.g.
>>>
>>>           options: {
>>>             'onText': 'Yes', 'offText': 'No',
>>>             'onColor': 'success', 'offColor': 'primary',
>>>             'size': 'small'
>>>           }
>>
>> Done
>>>
>>> - Please remove the Schema property from the main properties tab (not
>>> the properties dialogue).
>>
>> Done
>>>
>>> - No icon is show for Checks on the Dependents tab for a domain.
>>
>> Done
>>>
>>> - The add button on the Security Labels tab is spelt "Add". Why is
>>> that? Other instances of this grid use "ADD" which is the default in
>>> backform.pgadmin.js.
>>
>> Done
>>>
>>> - Dependencies on domain check constraints are listed as being on a
>>> "Type" not a "Domain".
>>
>> Done
>>>
>>> - If adding a domain constraint using the grid on the Domain dialogue,
>>> I cannot specify "NOT VALID". We need a checkbox for that in a narrow
>>> columns at the end. Unchecking it for an existing constraint should be
>>> the equivalent of doing "ALTER DOMAIN ... VALIDATE CONSTRAINT"
>>
>> Done
>>>
>>> - If I switch the "Don't Validate" switch on a constraint, there are
>>> leading blank lines in the generated SQL. The same occurs when adding
>>> a comment to a constraint.
>>
>> Done
>>>
>>> - I think we need to reverse the meaning of "Don't Validate" and
>>> rename to match the "Valid?" field that's on the properties list.
>>> Otherwise it's not clear they're the same thing.
>>
>> Done
>>>
>>> - s/Not Null/Not Null?/
>>
>> Done
>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>
>>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Hi

Almost there :-s

- The hint for default should be a placeholder in the textbox itself
(like combos have "Select from the list"

- I should be able to check the "Validate?" option on one or more
constraints from within the Domain dialogue

- Please ensure the capitalisation of all property labels is
consistent - it should be "Base type" not "Base Type", "System
domain?" not "System Domain?" etc.

- The check constraint reverse engineered SQL should include the path
to the constraint, e.g.

-- CHECK: schema.domain.check_at

Once that's done, it can be committed I think.

Thanks.

On Wed, Mar 23, 2016 at 7:27 AM, Khushboo Vashi
<khushboo.vashi@enterprisedb.com> wrote:
> Updated one comment.
>
> On Wed, Mar 23, 2016 at 12:48 PM, Khushboo Vashi
> <khushboo.vashi@enterprisedb.com> wrote:
>>
>> Hi,
>>
>> Please find attached updated patch for the Domains module.
>>
>> On Wed, Mar 16, 2016 at 9:40 PM, Dave Page <dpage@pgadmin.org> wrote:
>>>
>>> Hi
>>>
>>> On Wed, Mar 16, 2016 at 2:03 PM, Khushboo Vashi
>>> <khushboo.vashi@enterprisedb.com> wrote:
>>> > Hi,
>>> >
>>> > Please find the updated Domain Module Patch.
>>> >
>>> > To test this patch, please apply Backgrid Textarea Cell Patch before
>>> > this.
>>>
>>> Thanks. I believe with the following fixes, we'll be done :-)
>>>
>>> - Default values should be auto-quoted when necessary (ie. strings, on
>>> a text-based domain).
>>
>> As per our discussion, this should leave unquoted.
>
> And also added a hint to the field stated 'Enter an expression or a value.'
>>
>>
>>> - "System Domain?" should be in the General section, between owner and
>>> comment.
>>
>> Done
>>>
>>> - The switches should use the same colouring/styling as other objects,
>>> e.g.
>>>
>>>           options: {
>>>             'onText': 'Yes', 'offText': 'No',
>>>             'onColor': 'success', 'offColor': 'primary',
>>>             'size': 'small'
>>>           }
>>
>> Done
>>>
>>> - Please remove the Schema property from the main properties tab (not
>>> the properties dialogue).
>>
>> Done
>>>
>>> - No icon is show for Checks on the Dependents tab for a domain.
>>
>> Done
>>>
>>> - The add button on the Security Labels tab is spelt "Add". Why is
>>> that? Other instances of this grid use "ADD" which is the default in
>>> backform.pgadmin.js.
>>
>> Done
>>>
>>> - Dependencies on domain check constraints are listed as being on a
>>> "Type" not a "Domain".
>>
>> Done
>>>
>>> - If adding a domain constraint using the grid on the Domain dialogue,
>>> I cannot specify "NOT VALID". We need a checkbox for that in a narrow
>>> columns at the end. Unchecking it for an existing constraint should be
>>> the equivalent of doing "ALTER DOMAIN ... VALIDATE CONSTRAINT"
>>
>> Done
>>>
>>> - If I switch the "Don't Validate" switch on a constraint, there are
>>> leading blank lines in the generated SQL. The same occurs when adding
>>> a comment to a constraint.
>>
>> Done
>>>
>>> - I think we need to reverse the meaning of "Don't Validate" and
>>> rename to match the "Valid?" field that's on the properties list.
>>> Otherwise it's not clear they're the same thing.
>>
>> Done
>>>
>>> - s/Not Null/Not Null?/
>>
>> Done
>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>
>>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Hi

You're going to hate me for this....

- I added an un-validated constraint to a domain, then opened the
domain properties and clicked the Validate? option for it. The SQL is
generated, but the Save button is not enabled.

- If I right-click a domain, I get Create options for "Domain" (with a
constraint icon) and "Domain..." with a domain icon.

See attached screenshot.

Thanks.

On Thu, Mar 24, 2016 at 9:54 AM, Khushboo Vashi
<khushboo.vashi@enterprisedb.com> wrote:
> Hi,
>
> Please find the attached updated patch for the Domain module.
>
> Thanks,
> Khushboo
>
> On Wed, Mar 23, 2016 at 6:35 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> Hi
>>
>> Almost there :-s
>>
>> - The hint for default should be a placeholder in the textbox itself
>> (like combos have "Select from the list"
>
> Done
>>
>> - I should be able to check the "Validate?" option on one or more
>> constraints from within the Domain dialogue
>
> Done.
> Constraint Name can also be changed through the Domain dialogue.
>>
>> - Please ensure the capitalisation of all property labels is
>> consistent - it should be "Base type" not "Base Type", "System
>> domain?" not "System Domain?" etc.
>
> Done
>>
>> - The check constraint reverse engineered SQL should include the path
>> to the constraint, e.g.
>>
> Done
>>
>> -- CHECK: schema.domain.check_at
>>
>> Once that's done, it can be committed I think.
>>
>> Thanks.
>>
>> On Wed, Mar 23, 2016 at 7:27 AM, Khushboo Vashi
>> <khushboo.vashi@enterprisedb.com> wrote:
>> > Updated one comment.
>> >
>> > On Wed, Mar 23, 2016 at 12:48 PM, Khushboo Vashi
>> > <khushboo.vashi@enterprisedb.com> wrote:
>> >>
>> >> Hi,
>> >>
>> >> Please find attached updated patch for the Domains module.
>> >>
>> >> On Wed, Mar 16, 2016 at 9:40 PM, Dave Page <dpage@pgadmin.org> wrote:
>> >>>
>> >>> Hi
>> >>>
>> >>> On Wed, Mar 16, 2016 at 2:03 PM, Khushboo Vashi
>> >>> <khushboo.vashi@enterprisedb.com> wrote:
>> >>> > Hi,
>> >>> >
>> >>> > Please find the updated Domain Module Patch.
>> >>> >
>> >>> > To test this patch, please apply Backgrid Textarea Cell Patch before
>> >>> > this.
>> >>>
>> >>> Thanks. I believe with the following fixes, we'll be done :-)
>> >>>
>> >>> - Default values should be auto-quoted when necessary (ie. strings, on
>> >>> a text-based domain).
>> >>
>> >> As per our discussion, this should leave unquoted.
>> >
>> > And also added a hint to the field stated 'Enter an expression or a
>> > value.'
>> >>
>> >>
>> >>> - "System Domain?" should be in the General section, between owner and
>> >>> comment.
>> >>
>> >> Done
>> >>>
>> >>> - The switches should use the same colouring/styling as other objects,
>> >>> e.g.
>> >>>
>> >>>           options: {
>> >>>             'onText': 'Yes', 'offText': 'No',
>> >>>             'onColor': 'success', 'offColor': 'primary',
>> >>>             'size': 'small'
>> >>>           }
>> >>
>> >> Done
>> >>>
>> >>> - Please remove the Schema property from the main properties tab (not
>> >>> the properties dialogue).
>> >>
>> >> Done
>> >>>
>> >>> - No icon is show for Checks on the Dependents tab for a domain.
>> >>
>> >> Done
>> >>>
>> >>> - The add button on the Security Labels tab is spelt "Add". Why is
>> >>> that? Other instances of this grid use "ADD" which is the default in
>> >>> backform.pgadmin.js.
>> >>
>> >> Done
>> >>>
>> >>> - Dependencies on domain check constraints are listed as being on a
>> >>> "Type" not a "Domain".
>> >>
>> >> Done
>> >>>
>> >>> - If adding a domain constraint using the grid on the Domain dialogue,
>> >>> I cannot specify "NOT VALID". We need a checkbox for that in a narrow
>> >>> columns at the end. Unchecking it for an existing constraint should be
>> >>> the equivalent of doing "ALTER DOMAIN ... VALIDATE CONSTRAINT"
>> >>
>> >> Done
>> >>>
>> >>> - If I switch the "Don't Validate" switch on a constraint, there are
>> >>> leading blank lines in the generated SQL. The same occurs when adding
>> >>> a comment to a constraint.
>> >>
>> >> Done
>> >>>
>> >>> - I think we need to reverse the meaning of "Don't Validate" and
>> >>> rename to match the "Valid?" field that's on the properties list.
>> >>> Otherwise it's not clear they're the same thing.
>> >>
>> >> Done
>> >>>
>> >>> - s/Not Null/Not Null?/
>> >>
>> >> Done
>> >>>
>> >>>
>> >>>
>> >>> --
>> >>> Dave Page
>> >>> Blog: http://pgsnake.blogspot.com
>> >>> Twitter: @pgsnake
>> >>>
>> >>> EnterpriseDB UK: http://www.enterprisedb.com
>> >>> The Enterprise PostgreSQL Company
>> >>
>> >>
>> >
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Thanks - committed.

On Thu, Mar 24, 2016 at 3:25 PM, Khushboo Vashi
<khushboo.vashi@enterprisedb.com> wrote:
> Hi,
>
> Please find the attached updated patch for the Domains Module.
>
> Thanks,
> Khushboo
>
> On Thu, Mar 24, 2016 at 5:29 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> Hi
>>
>> You're going to hate me for this....
>>
>> - I added an un-validated constraint to a domain, then opened the
>> domain properties and clicked the Validate? option for it. The SQL is
>> generated, but the Save button is not enabled.
>
> Done.
>>
>>
>> - If I right-click a domain, I get Create options for "Domain" (with a
>> constraint icon) and "Domain..." with a domain icon.
>>
> As per the discussion with Ashesh, He has updated the context menu JS file
> with the new version and that is causing the issue.
> He is going to fix this issue as this is generic for the all context menu.
> I will create a new task for this in kanban and assign it to Ashesh.
>
>> See attached screenshot.
>>
>> Thanks.
>>
>> On Thu, Mar 24, 2016 at 9:54 AM, Khushboo Vashi
>> <khushboo.vashi@enterprisedb.com> wrote:
>> > Hi,
>> >
>> > Please find the attached updated patch for the Domain module.
>> >
>> > Thanks,
>> > Khushboo
>> >
>> > On Wed, Mar 23, 2016 at 6:35 PM, Dave Page <dpage@pgadmin.org> wrote:
>> >>
>> >> Hi
>> >>
>> >> Almost there :-s
>> >>
>> >> - The hint for default should be a placeholder in the textbox itself
>> >> (like combos have "Select from the list"
>> >
>> > Done
>> >>
>> >> - I should be able to check the "Validate?" option on one or more
>> >> constraints from within the Domain dialogue
>> >
>> > Done.
>> > Constraint Name can also be changed through the Domain dialogue.
>> >>
>> >> - Please ensure the capitalisation of all property labels is
>> >> consistent - it should be "Base type" not "Base Type", "System
>> >> domain?" not "System Domain?" etc.
>> >
>> > Done
>> >>
>> >> - The check constraint reverse engineered SQL should include the path
>> >> to the constraint, e.g.
>> >>
>> > Done
>> >>
>> >> -- CHECK: schema.domain.check_at
>> >>
>> >> Once that's done, it can be committed I think.
>> >>
>> >> Thanks.
>> >>
>> >> On Wed, Mar 23, 2016 at 7:27 AM, Khushboo Vashi
>> >> <khushboo.vashi@enterprisedb.com> wrote:
>> >> > Updated one comment.
>> >> >
>> >> > On Wed, Mar 23, 2016 at 12:48 PM, Khushboo Vashi
>> >> > <khushboo.vashi@enterprisedb.com> wrote:
>> >> >>
>> >> >> Hi,
>> >> >>
>> >> >> Please find attached updated patch for the Domains module.
>> >> >>
>> >> >> On Wed, Mar 16, 2016 at 9:40 PM, Dave Page <dpage@pgadmin.org>
>> >> >> wrote:
>> >> >>>
>> >> >>> Hi
>> >> >>>
>> >> >>> On Wed, Mar 16, 2016 at 2:03 PM, Khushboo Vashi
>> >> >>> <khushboo.vashi@enterprisedb.com> wrote:
>> >> >>> > Hi,
>> >> >>> >
>> >> >>> > Please find the updated Domain Module Patch.
>> >> >>> >
>> >> >>> > To test this patch, please apply Backgrid Textarea Cell Patch
>> >> >>> > before
>> >> >>> > this.
>> >> >>>
>> >> >>> Thanks. I believe with the following fixes, we'll be done :-)
>> >> >>>
>> >> >>> - Default values should be auto-quoted when necessary (ie. strings,
>> >> >>> on
>> >> >>> a text-based domain).
>> >> >>
>> >> >> As per our discussion, this should leave unquoted.
>> >> >
>> >> > And also added a hint to the field stated 'Enter an expression or a
>> >> > value.'
>> >> >>
>> >> >>
>> >> >>> - "System Domain?" should be in the General section, between owner
>> >> >>> and
>> >> >>> comment.
>> >> >>
>> >> >> Done
>> >> >>>
>> >> >>> - The switches should use the same colouring/styling as other
>> >> >>> objects,
>> >> >>> e.g.
>> >> >>>
>> >> >>>           options: {
>> >> >>>             'onText': 'Yes', 'offText': 'No',
>> >> >>>             'onColor': 'success', 'offColor': 'primary',
>> >> >>>             'size': 'small'
>> >> >>>           }
>> >> >>
>> >> >> Done
>> >> >>>
>> >> >>> - Please remove the Schema property from the main properties tab
>> >> >>> (not
>> >> >>> the properties dialogue).
>> >> >>
>> >> >> Done
>> >> >>>
>> >> >>> - No icon is show for Checks on the Dependents tab for a domain.
>> >> >>
>> >> >> Done
>> >> >>>
>> >> >>> - The add button on the Security Labels tab is spelt "Add". Why is
>> >> >>> that? Other instances of this grid use "ADD" which is the default
>> >> >>> in
>> >> >>> backform.pgadmin.js.
>> >> >>
>> >> >> Done
>> >> >>>
>> >> >>> - Dependencies on domain check constraints are listed as being on a
>> >> >>> "Type" not a "Domain".
>> >> >>
>> >> >> Done
>> >> >>>
>> >> >>> - If adding a domain constraint using the grid on the Domain
>> >> >>> dialogue,
>> >> >>> I cannot specify "NOT VALID". We need a checkbox for that in a
>> >> >>> narrow
>> >> >>> columns at the end. Unchecking it for an existing constraint should
>> >> >>> be
>> >> >>> the equivalent of doing "ALTER DOMAIN ... VALIDATE CONSTRAINT"
>> >> >>
>> >> >> Done
>> >> >>>
>> >> >>> - If I switch the "Don't Validate" switch on a constraint, there
>> >> >>> are
>> >> >>> leading blank lines in the generated SQL. The same occurs when
>> >> >>> adding
>> >> >>> a comment to a constraint.
>> >> >>
>> >> >> Done
>> >> >>>
>> >> >>> - I think we need to reverse the meaning of "Don't Validate" and
>> >> >>> rename to match the "Valid?" field that's on the properties list.
>> >> >>> Otherwise it's not clear they're the same thing.
>> >> >>
>> >> >> Done
>> >> >>>
>> >> >>> - s/Not Null/Not Null?/
>> >> >>
>> >> >> Done
>> >> >>>
>> >> >>>
>> >> >>>
>> >> >>> --
>> >> >>> Dave Page
>> >> >>> Blog: http://pgsnake.blogspot.com
>> >> >>> Twitter: @pgsnake
>> >> >>>
>> >> >>> EnterpriseDB UK: http://www.enterprisedb.com
>> >> >>> The Enterprise PostgreSQL Company
>> >> >>
>> >> >>
>> >> >
>> >>
>> >>
>> >>
>> >> --
>> >> Dave Page
>> >> Blog: http://pgsnake.blogspot.com
>> >> Twitter: @pgsnake
>> >>
>> >> EnterpriseDB UK: http://www.enterprisedb.com
>> >> The Enterprise PostgreSQL Company
>> >
>> >
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company