Обсуждение: Could we do pgindent on just utils/adt/xml.c in the 8.3 branch?

I just committed a backpatch of
http://archives.postgresql.org/pgsql-committers/2009-05/msg00229.php
to 8.3.  As in that patch, I did not try to manually reindent the code
that's now wrapped in PG_TRY blocks.  It might be a good idea to run
pgindent on just that one file so that it's spacing-consistent with
the later branches.  This will ease any future backpatching in that
file.
        regards, tom lane

Tom Lane wrote:
> I just committed a backpatch of
> http://archives.postgresql.org/pgsql-committers/2009-05/msg00229.php
> to 8.3.  As in that patch, I did not try to manually reindent the code
> that's now wrapped in PG_TRY blocks.  It might be a good idea to run
> pgindent on just that one file so that it's spacing-consistent with
> the later branches.  This will ease any future backpatching in that
> file.

Sure, I can easily do that, but I am not sure how to generate a typedef
list for that release, except to use the old typedef collection method
for that file.  Is that OK?

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 PG East:  http://www.enterprisedb.com/community/nav-pg-east-2010.do

Bruce Momjian <bruce@momjian.us> writes:
> Sure, I can easily do that, but I am not sure how to generate a typedef
> list for that release, except to use the old typedef collection method
> for that file.  Is that OK?

One of the things I noticed while patching was that the 8.3 typedef list
was missing xmlChar and a few other typedefs that are used a lot in that
file :-(.  So please don't use the same method you used in 8.3.

I think it would be close enough to use the current (just added to CVS)
typedef list.  Or use the one you used for 8.4 if you have it handy.
There is not a lot of difference between the 8.3 and current code in
that file, so either of those are probably going to give you the same
results.
        regards, tom lane

Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > Sure, I can easily do that, but I am not sure how to generate a typedef
> > list for that release, except to use the old typedef collection method
> > for that file.  Is that OK?
> 
> One of the things I noticed while patching was that the 8.3 typedef list
> was missing xmlChar and a few other typedefs that are used a lot in that
> file :-(.  So please don't use the same method you used in 8.3.

Yes, I don't have libxml installed on this machine so it didn't pick up
those typedefs.

> I think it would be close enough to use the current (just added to CVS)
> typedef list.  Or use the one you used for 8.4 if you have it handy.
> There is not a lot of difference between the 8.3 and current code in
> that file, so either of those are probably going to give you the same
> results.

Done.  Sorry for the delay.

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 PG East:  http://www.enterprisedb.com/community/nav-pg-east-2010.do