Re: PATCH: pgbench - option to build using ppoll() for largerconnection counts

Поиск
Список
Период
Сортировка
Искать
От
Fabien COELHO
Тема
Re: PATCH: pgbench - option to build using ppoll() for largerconnection counts
Дата
Msg-id
alpine.DEB.2.20.1803251252390.8109@lancre
Ответ на
Список
Дерево обсуждения
PATCH: pgbench - option to build using ppoll() for larger connectioncounts "Rady, Doug" <radydoug@amazon.com>
Re: PATCH: pgbench - option to build using ppoll() for larger connection counts Tom Lane <tgl@sss.pgh.pa.us>
Re: PATCH: pgbench - option to build using ppoll() for larger connection counts Tom Lane <tgl@sss.pgh.pa.us>
Re: PATCH: pgbench - option to build using ppoll() for largerconnection counts Fabien COELHO <coelho@cri.ensmp.fr>
Re: PATCH: pgbench - option to build using ppoll() for largerconnection counts "Rady, Doug" <radydoug@amazon.com>
Re: PATCH: pgbench - option to build using ppoll() for largerconnection counts Fabien COELHO <coelho@cri.ensmp.fr>
Re: PATCH: pgbench - option to build using ppoll() for largerconnection counts "Rady, Doug" <radydoug@amazon.com>
Re: PATCH: pgbench - option to build using ppoll() for largerconnection counts Fabien COELHO <coelho@cri.ensmp.fr>
Re: PATCH: pgbench - option to build using ppoll() for largerconnection counts "Rady, Doug" <radydoug@amazon.com>
Re: PATCH: pgbench - option to build using ppoll() for largerconnection counts Andres Freund <andres@anarazel.de>
Re: PATCH: pgbench - option to build using ppoll() for largerconnection counts Fabien COELHO <coelho@cri.ensmp.fr>
Re: PATCH: pgbench - option to build using ppoll() for largerconnection counts Andres Freund <andres@anarazel.de>
Re: PATCH: pgbench - option to build using ppoll() for largerconnection counts "Rady, Doug" <radydoug@amazon.com>
Re: PATCH: pgbench - option to build using ppoll() for largerconnection counts Fabien COELHO <coelho@cri.ensmp.fr>
Re: PATCH: pgbench - option to build using ppoll() for largerconnection counts "Rady, Doug" <radydoug@amazon.com>
Re: PATCH: pgbench - option to build using ppoll() for largerconnection counts Andres Freund <andres@anarazel.de>
Re: PATCH: pgbench - option to build using ppoll() for larger connection counts Tom Lane <tgl@sss.pgh.pa.us>
Re: PATCH: pgbench - option to build using ppoll() for largerconnection counts Andres Freund <andres@anarazel.de>
Re: PATCH: pgbench - option to build using ppoll() for larger connection counts konstantin knizhnik <k.knizhnik@postgrespro.ru>
Re: PATCH: pgbench - option to build using ppoll() for largerconnection counts Fabien COELHO <coelho@cri.ensmp.fr>
Re: PATCH: pgbench - option to build using ppoll() for largerconnection counts Thomas Munro <thomas.munro@enterprisedb.com>
Re: PATCH: pgbench - option to build using ppoll() for largerconnection counts Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Re: PATCH: pgbench - option to build using ppoll() for largerconnection counts Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Re: PATCH: pgbench - option to build using ppoll() for largerconnection counts Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Re: PATCH: pgbench - option to build using ppoll() for largerconnection counts Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Re: PATCH: pgbench - option to build using ppoll() for largerconnection counts Fabien COELHO <coelho@cri.ensmp.fr>
Re: PATCH: pgbench - option to build using ppoll() for larger connection counts Tom Lane <tgl@sss.pgh.pa.us>
Re: PATCH: pgbench - option to build using ppoll() for larger connection counts Tom Lane <tgl@sss.pgh.pa.us>
Re: PATCH: pgbench - option to build using ppoll() for largerconnection counts Fabien COELHO <coelho@cri.ensmp.fr>
Re: PATCH: pgbench - option to build using ppoll() for largerconnection counts "Rady, Doug" <radydoug@amazon.com>
Re: PATCH: pgbench - option to build using ppoll() for largerconnection counts Fabien COELHO <coelho@cri.ensmp.fr>

Hello Doug,

> Updated the patch to not do the #undef
> pgbench11-ppoll-v11.patch attached.

Patch applies. Do not forget to regenerate configure to test...

I've compiled and run with both ppoll & select options without issues.

Two quite minor style comment (at least 2 instances):

   if (cond) return false; else return true;

ISTM that the simpler the better:

   return !cond;

Also ISTM that the following does not comply with pg C style expectations 
(idem, 2 instances):

   } else {


-- 
Fabien.

В списке pgsql-hackers по дате отправления
От: David Rowley
Дата:
От: Haribabu Kommi
Дата:
FAQ