Hello Doug,
> I'm not sure why you do the following trick, could you explain?
> +#undef USE_SELECT
> +#define USE_SELECT
>
> This was due to compiler complaint about USE_SELECT being redefined.
> Have replaced that "trick" with a new #define POLL_USING_SELECT which is used elsewhere in pgbench instead.
Ok, why not.
Another option to avoid the warning and a new name could have been to
"#ifndef X #define X #endif /* !X */"
Patch applies cleanly, compiles cleanly for both options, local & global
"make check" ok.
Switched to "Ready".
--
Fabien.