Re: Add new option 'all' to pg_stat_reset_shared()

On Wed, Nov 08, 2023 at 02:15:24PM +0530, Bharath Rupireddy wrote:
> On Wed, Nov 8, 2023 at 9:43 AM Andres Freund  wrote:
>> It's not like oids are a precious resource. It's a more confusing API to have
>> to have to specify a NULL as an argument than not having to do so. If we
>> really want to avoid a separate oid, a more sensible path would be to add a
>> default argument to pg_stat_reset_slru() (by doing a CREATE OR REPLACE in
>> system_functions.sql).
> 
> +1. Attached the patch.
>
>  -- Test that multiple SLRUs are reset when no specific SLRU provided to reset function
> -SELECT pg_stat_reset_slru(NULL);
> +SELECT pg_stat_reset_slru();

For the SLRU part, why not.

Hmm.  What's the final plan for pg_stat_reset_shared(), then?  An
equivalent that calls a series of pgstat_reset_of_kind()?
--
Michael