Обсуждение: pgsql: Add pgindent commit to git-blame-ignore-revs file.
Add pgindent commit to git-blame-ignore-revs file. Add entry for recent commit e1c1c30f. Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/ba135fa537ab5c2fca0d589c826ebb3ecf98b2f1 Modified Files -------------- .git-blame-ignore-revs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
On 6/28/21 12:26 PM, Peter Geoghegan wrote: > Add pgindent commit to git-blame-ignore-revs file. > > Add entry for recent commit e1c1c30f. > Hmm, did I miss something or do we need to update some instructions somewhere? cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com
On Mon, Jun 28, 2021 at 9:31 AM Andrew Dunstan <andrew@dunslane.net> wrote: > Hmm, did I miss something or do we need to update some instructions > somewhere? (Responded on the other committers thread just now too.) I did update the instructions in commit 8e638845, but perhaps I omitted to update something. What do you think? -- Peter Geoghegan
On 2021-Jun-28, Peter Geoghegan wrote: > On Mon, Jun 28, 2021 at 9:31 AM Andrew Dunstan <andrew@dunslane.net> wrote: > > Hmm, did I miss something or do we need to update some instructions > > somewhere? > > (Responded on the other committers thread just now too.) > > I did update the instructions in commit 8e638845, but perhaps I > omitted to update something. What do you think? I think it would be useful to have the "git log" instructions in src/tools/RELEASE_CHANGES, not just in the .git-blame-ignore-revs file itself. ... and now that I look at running that command, I notice that the date format it generates for me is different from what it did for you: e1c1c30f635390b6a3ae4993e8cac213a33e6e3f # Mon Jun 28 11:05:54 2021 -0400 # Pre branch pgindent / pgperltidy run This is what you committed: +e1c1c30f635390b6a3ae4993e8cac213a33e6e3f # 2021-06-28 11:05:54 -0400 +# Pre branch pgindent / pgperltidy run Is it worth documenting whatever is causing the output to be this? I'm sure many of us would be bothered if the date format was not always the same in future entries. -- Álvaro Herrera Valdivia, Chile "Linux transformó mi computadora, de una `máquina para hacer cosas', en un aparato realmente entretenido, sobre el cual cada día aprendo algo nuevo" (Jaime Salinas)
Peter Geoghegan <pg@bowt.ie> writes:
> On Mon, Jun 28, 2021 at 9:31 AM Andrew Dunstan <andrew@dunslane.net> wrote:
>> Hmm, did I miss something or do we need to update some instructions
>> somewhere?
> I did update the instructions in commit 8e638845, but perhaps I
> omitted to update something. What do you think?
The instructions for "Starting a New Development Cycle" perhaps need
a specific "see src/tools/pgindent/README". I'd be inclined to
remove the separate mention of .git-blame-ignore-revs from "Pre-Beta
Tasks", too. If you didn't read pgindent/README you might miss
more than just this.
regards, tom lane
On Mon, Jun 28, 2021 at 9:43 AM Alvaro Herrera <alvherre@alvh.no-ip.org> wrote: > ... and now that I look at running that command, I notice that the date > format it generates for me is different from what it did for you: This is because our global git configs differ. > Is it worth documenting whatever is causing the output to be this? > I'm sure many of us would be bothered if the date format was not always > the same in future entries. I handled this in passing by making the instructions specify "--date=iso", just for consistency. It's now: git log --pretty=format:"%H # %cd %n# %s" $PGINDENTGITHASH -1 --date=iso This shows the pgindent-commit author's timestamp in the author's own timezone, plus ISO format. I believe that this addresses your concern. I'll consider the question of changing exactly how things are documented and hook into the release process separately, in my response to Tom. -- Peter Geoghegan
On Mon, Jun 28, 2021 at 9:47 AM Tom Lane <tgl@sss.pgh.pa.us> wrote: > The instructions for "Starting a New Development Cycle" perhaps need > a specific "see src/tools/pgindent/README". I'd be inclined to > remove the separate mention of .git-blame-ignore-revs from "Pre-Beta > Tasks", too. If you didn't read pgindent/README you might miss > more than just this. How about the approach taken in the attached patch? I think that leaving the snippet on adding new entries to the file at the top of the file is the right approach. I haven't changed that. I do point this out explicitly, though. -- Peter Geoghegan
Вложения
Peter Geoghegan <pg@bowt.ie> writes:
> On Mon, Jun 28, 2021 at 9:47 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> The instructions for "Starting a New Development Cycle" perhaps need
>> a specific "see src/tools/pgindent/README". I'd be inclined to
>> remove the separate mention of .git-blame-ignore-revs from "Pre-Beta
>> Tasks", too. If you didn't read pgindent/README you might miss
>> more than just this.
> How about the approach taken in the attached patch?
WFM.
regards, tom lane
On Mon, Jun 28, 2021 at 12:53 PM Tom Lane <tgl@sss.pgh.pa.us> wrote: > > How about the approach taken in the attached patch? > > WFM. Pushed. Thanks. -- Peter Geoghegan