Обсуждение: [pgAdmin4][Patch]: Adding connection status in Query tool
Hi,
PFA patch to add the connection status in query tool, this feature will allow user to check the database connection status in query tool itself, it will also provide the detailed status as a tooltip when user hovers on it, the most benefit of the feature will be when user open query tool in new Browser Tab where Browser tree is not visible to user, user can also configure the status polling time using preference dialog.
RM#2475
Apart from that I have also removed the ..sqleditor/static/css/ sqleditor.css reference from ../datagrid/templates/ datagrid/index.html file because we are already bundling the "sqleditor.css" file in main "style.css" file.
Thanks to Chethana for his UI related inputs and to Surinder for helping me on html alignment issues.
--![](https://drive.google.com/a/enterprisedb.com/uc?id=0B6jGeB3BfKRMV0t4MEp0YnZCTTA&export=download)
Regards,
Вложения
Hi
--
Interesting. A few thoughts:
- The pulsating icon is very off-putting. I think we need to make it only flash a couple of times when we actually need to attract the attention of the user.
- We shouldn't really use tooltips like this, as it may confuse folks with screen readers. Should we make the icon clickable (which should have a visual hint)? Maybe a drop-down status panel.
- Do we need to poll separately for the status? Instead, why not update it whenever polling for results, or executing something?
Thanks!
On Tue, Dec 19, 2017 at 11:42 AM, Murtuza Zabuawala <murtuza.zabuawala@ enterprisedb.com> wrote:
Hi,PFA patch to add the connection status in query tool, this feature will allow user to check the database connection status in query tool itself, it will also provide the detailed status as a tooltip when user hovers on it, the most benefit of the feature will be when user open query tool in new Browser Tab where Browser tree is not visible to user, user can also configure the status polling time using preference dialog.RM#2475Apart from that I have also removed the ..sqleditor/static/css/sqleditor.css reference from ../datagrid/templates/datagrid /index.html file because we are already bundling the "sqleditor.css" file in main "style.css" file.
Thanks to Chethana for his UI related inputs and to Surinder for helping me on html alignment issues.--Regards,
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Tue, Dec 19, 2017 at 7:24 PM, Dave Page <dpage@pgadmin.org> wrote:
HiInteresting. A few thoughts:- The pulsating icon is very off-putting. I think we need to make it only flash a couple of times when we actually need to attract the attention of the user.
As per my discussion with Chethana, In his opinion user tends to notice things that way more quickly.
Are you sure you wish to flash only couple of times on error?
- We shouldn't really use tooltips like this, as it may confuse folks with screen readers. Should we make the icon clickable (which should have a visual hint)? Maybe a drop-down status panel.
Sure let me check.
- Do we need to poll separately for the status? Instead, why not update it whenever polling for results, or executing something?
Then user won't be able to know the current connection status prior to query execution, the purpose of the feature is to make user aware of current connection status even if there is no query running, As most user tends to leave open their query tool window after their work it will be useful when flask session gets expired and connection to server gets closed after that.
Thanks!On Tue, Dec 19, 2017 at 11:42 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA patch to add the connection status in query tool, this feature will allow user to check the database connection status in query tool itself, it will also provide the detailed status as a tooltip when user hovers on it, the most benefit of the feature will be when user open query tool in new Browser Tab where Browser tree is not visible to user, user can also configure the status polling time using preference dialog.RM#2475Apart from that I have also removed the ..sqleditor/static/css/sqleditor.css reference from ../datagrid/templates/datagrid /index.html file because we are already bundling the "sqleditor.css" file in main "style.css" file.
Thanks to Chethana for his UI related inputs and to Surinder for helping me on html alignment issues.--Regards,--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Hi
--
On Tue, Dec 19, 2017 at 2:17 PM, Murtuza Zabuawala <murtuza.zabuawala@ enterprisedb.com> wrote:
On Tue, Dec 19, 2017 at 7:24 PM, Dave Page <dpage@pgadmin.org> wrote:HiInteresting. A few thoughts:- The pulsating icon is very off-putting. I think we need to make it only flash a couple of times when we actually need to attract the attention of the user.As per my discussion with Chethana, In his opinion user tends to notice things that way more quickly.Are you sure you wish to flash only couple of times on error?
We already show and alert and switch to the messages tab if there's an error right? Either way, it's very off-putting.
- We shouldn't really use tooltips like this, as it may confuse folks with screen readers. Should we make the icon clickable (which should have a visual hint)? Maybe a drop-down status panel.Sure let me check.- Do we need to poll separately for the status? Instead, why not update it whenever polling for results, or executing something?Then user won't be able to know the current connection status prior to query execution, the purpose of the feature is to make user aware of current connection status even if there is no query running, As most user tends to leave open their query tool window after their work it will be useful when flask session gets expired and connection to server gets closed after that.
Ah, OK. I see. Where is the polling frequency? I can't find it in the Preferences.
I'm really not too sure about polling this often. If i've got 5 query tool windows open, that's 10 queries a second, with the dashboard as well. That's why I was suggesting piggy-backing the status updates on other queries.
Sidenote: I've seen the status indicator go from green to orange and back again numerous times, for no obvious reason when connected to a local server.
Thanks!On Tue, Dec 19, 2017 at 11:42 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA patch to add the connection status in query tool, this feature will allow user to check the database connection status in query tool itself, it will also provide the detailed status as a tooltip when user hovers on it, the most benefit of the feature will be when user open query tool in new Browser Tab where Browser tree is not visible to user, user can also configure the status polling time using preference dialog.RM#2475Apart from that I have also removed the ..sqleditor/static/css/sqleditor.css reference from ../datagrid/templates/datagrid /index.html file because we are already bundling the "sqleditor.css" file in main "style.css" file.
Thanks to Chethana for his UI related inputs and to Surinder for helping me on html alignment issues.--Regards,--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
What are thoughts on switching the colors between currently running and idle? I think if the session is currently running, and its still open during the session time limit, it should be green. Perhaps idle sessions should be yellow or grey to indicate that the window should be (and can be) closed without terminating any current transactions.
As far as it pulsating, most users only need to know session status when they look for it, and it's not top of mind when they open the window. I agree with Dave that it shouldn't attract people's attention unless there is a problem.
On Tue, Dec 19, 2017 at 7:15 AM Dave Page <dpage@pgadmin.org> wrote:
HiOn Tue, Dec 19, 2017 at 2:17 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:On Tue, Dec 19, 2017 at 7:24 PM, Dave Page <dpage@pgadmin.org> wrote:HiInteresting. A few thoughts:- The pulsating icon is very off-putting. I think we need to make it only flash a couple of times when we actually need to attract the attention of the user.As per my discussion with Chethana, In his opinion user tends to notice things that way more quickly.Are you sure you wish to flash only couple of times on error?We already show and alert and switch to the messages tab if there's an error right? Either way, it's very off-putting.- We shouldn't really use tooltips like this, as it may confuse folks with screen readers. Should we make the icon clickable (which should have a visual hint)? Maybe a drop-down status panel.Sure let me check.- Do we need to poll separately for the status? Instead, why not update it whenever polling for results, or executing something?Then user won't be able to know the current connection status prior to query execution, the purpose of the feature is to make user aware of current connection status even if there is no query running, As most user tends to leave open their query tool window after their work it will be useful when flask session gets expired and connection to server gets closed after that.Ah, OK. I see. Where is the polling frequency? I can't find it in the Preferences.I'm really not too sure about polling this often. If i've got 5 query tool windows open, that's 10 queries a second, with the dashboard as well. That's why I was suggesting piggy-backing the status updates on other queries.Sidenote: I've seen the status indicator go from green to orange and back again numerous times, for no obvious reason when connected to a local server.Thanks!On Tue, Dec 19, 2017 at 11:42 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:Hi,PFA patch to add the connection status in query tool, this feature will allow user to check the database connection status in query tool itself, it will also provide the detailed status as a tooltip when user hovers on it, the most benefit of the feature will be when user open query tool in new Browser Tab where Browser tree is not visible to user, user can also configure the status polling time using preference dialog.RM#2475Apart from that I have also removed the ..sqleditor/static/css/sqleditor.css reference from ../datagrid/templates/datagrid/index.html file because we are already bundling the "sqleditor.css" file in main "style.css" file.
Thanks to Chethana for his UI related inputs and to Surinder for helping me on html alignment issues.--Regards,--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Hi Shirley,
Selected colours are as below,
Idle = Green (#32CD32) -> Means user can execute query
Busy = Orange (#e8a735) -> Connection is busy
Failed = Red (#d0021b) -> There is an error
On Tue, Dec 19, 2017 at 8:58 PM, Shirley Wang <swang@pivotal.io> wrote:
What are thoughts on switching the colors between currently running and idle? I think if the session is currently running, and its still open during the session time limit, it should be green. Perhaps idle sessions should be yellow or grey to indicate that the window should be (and can be) closed without terminating any current transactions.As far as it pulsating, most users only need to know session status when they look for it, and it's not top of mind when they open the window. I agree with Dave that it shouldn't attract people's attention unless there is a problem.
Ok, I will change remove the pulsating from idle status and add it only when connection is busy or incase of an error.
On Tue, Dec 19, 2017 at 7:15 AM Dave Page <dpage@pgadmin.org> wrote:HiOn Tue, Dec 19, 2017 at 2:17 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: On Tue, Dec 19, 2017 at 7:24 PM, Dave Page <dpage@pgadmin.org> wrote:HiInteresting. A few thoughts:- The pulsating icon is very off-putting. I think we need to make it only flash a couple of times when we actually need to attract the attention of the user.As per my discussion with Chethana, In his opinion user tends to notice things that way more quickly.Are you sure you wish to flash only couple of times on error?We already show and alert and switch to the messages tab if there's an error right? Either way, it's very off-putting.- We shouldn't really use tooltips like this, as it may confuse folks with screen readers. Should we make the icon clickable (which should have a visual hint)? Maybe a drop-down status panel.Sure let me check.- Do we need to poll separately for the status? Instead, why not update it whenever polling for results, or executing something?Then user won't be able to know the current connection status prior to query execution, the purpose of the feature is to make user aware of current connection status even if there is no query running, As most user tends to leave open their query tool window after their work it will be useful when flask session gets expired and connection to server gets closed after that.Ah, OK. I see. Where is the polling frequency? I can't find it in the Preferences.I'm really not too sure about polling this often. If i've got 5 query tool windows open, that's 10 queries a second, with the dashboard as well. That's why I was suggesting piggy-backing the status updates on other queries.
@Dave,
I also thought about it but that's what we have to do if we want to provide the realtime updates but then it's configurable so user can change the polling interval at anytime, with default settings if user has 5 query tool windows open then 5 ajax will be fired every second.
![Inline image 1](/media/maillist_attaches/pgadmin-hackers/2017/12/20/CAKKotZQtEYtod3H+Af4i5+Ch=sH2-BpSNcG5j1KW5uywL85Q7g@mail.gmail.com/image.png)
Sidenote: I've seen the status indicator go from green to orange and back again numerous times, for no obvious reason when connected to a local server.
Looking into it.
Thanks!On Tue, Dec 19, 2017 at 11:42 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA patch to add the connection status in query tool, this feature will allow user to check the database connection status in query tool itself, it will also provide the detailed status as a tooltip when user hovers on it, the most benefit of the feature will be when user open query tool in new Browser Tab where Browser tree is not visible to user, user can also configure the status polling time using preference dialog.RM#2475Apart from that I have also removed the ..sqleditor/static/css/sqleditor.css reference from ../datagrid/templates/datagrid /index.html file because we are already bundling the "sqleditor.css" file in main "style.css" file.
Thanks to Chethana for his UI related inputs and to Surinder for helping me on html alignment issues.--Regards,--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Вложения
--
Harshal Dhumal
Sr. Software Engineer
On Tue, Dec 19, 2017 at 7:47 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
On Tue, Dec 19, 2017 at 7:24 PM, Dave Page <dpage@pgadmin.org> wrote:HiInteresting. A few thoughts:- The pulsating icon is very off-putting. I think we need to make it only flash a couple of times when we actually need to attract the attention of the user.As per my discussion with Chethana, In his opinion user tends to notice things that way more quickly.Are you sure you wish to flash only couple of times on error?- We shouldn't really use tooltips like this, as it may confuse folks with screen readers. Should we make the icon clickable (which should have a visual hint)? Maybe a drop-down status panel.Sure let me check.- Do we need to poll separately for the status? Instead, why not update it whenever polling for results, or executing something?Then user won't be able to know the current connection status prior to query execution, the purpose of the feature is to make user aware of current connection status even if there is no query running, As most user tends to leave open their query tool window after their work it will be useful when flask session gets expired and connection to server gets closed after that.
- Status Ideal and Active can be piggy backed (when we are polling query result).
- In case of connection closed then we are reconnecting seamlessly (as per your last comment on RM2475).
So letting user know in advance that connection is closed does not provide any benefit.
Eventually user will look of any reconnect button/option in query tool to reconnect if we tell connection status in advance.
- If flask session expires then (irrespective of connection status) status poll http request will be redirected to login page.
So we won't get actual connection status in this case.
Thanks!On Tue, Dec 19, 2017 at 11:42 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA patch to add the connection status in query tool, this feature will allow user to check the database connection status in query tool itself, it will also provide the detailed status as a tooltip when user hovers on it, the most benefit of the feature will be when user open query tool in new Browser Tab where Browser tree is not visible to user, user can also configure the status polling time using preference dialog.RM#2475Apart from that I have also removed the ..sqleditor/static/css/sqleditor.css reference from ../datagrid/templates/datagrid /index.html file because we are already bundling the "sqleditor.css" file in main "style.css" file.
Thanks to Chethana for his UI related inputs and to Surinder for helping me on html alignment issues.--Regards,--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Wed, Dec 20, 2017 at 12:17 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
--Harshal DhumalSr. Software EngineerOn Tue, Dec 19, 2017 at 7:47 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: On Tue, Dec 19, 2017 at 7:24 PM, Dave Page <dpage@pgadmin.org> wrote:HiInteresting. A few thoughts:- The pulsating icon is very off-putting. I think we need to make it only flash a couple of times when we actually need to attract the attention of the user.As per my discussion with Chethana, In his opinion user tends to notice things that way more quickly.Are you sure you wish to flash only couple of times on error?- We shouldn't really use tooltips like this, as it may confuse folks with screen readers. Should we make the icon clickable (which should have a visual hint)? Maybe a drop-down status panel.Sure let me check.- Do we need to poll separately for the status? Instead, why not update it whenever polling for results, or executing something?Then user won't be able to know the current connection status prior to query execution, the purpose of the feature is to make user aware of current connection status even if there is no query running, As most user tends to leave open their query tool window after their work it will be useful when flask session gets expired and connection to server gets closed after that.- Status Ideal and Active can be piggy backed (when we are polling query result).
Checking for idle connection while polling the result is not possible. because w
hen you press execute button that
means
are trying to execute some query then how do you check for idle status when there is already a
query running, you will always get Busy status :)
- In case of connection closed then we are reconnecting seamlessly (as per your last comment on RM2475).So letting user know in advance that connection is closed does not provide any benefit.
I wrote that for desktop version, because we are automatically logging-in user with each request if user is not authorized.
Eventually user will look of any reconnect button/option in query tool to reconnect if we tell connection status in advance.
- If flask session expires then (irrespective of connection status) status poll http request will be redirected to login page.So we won't get actual connection status in this case.
Thanks!On Tue, Dec 19, 2017 at 11:42 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA patch to add the connection status in query tool, this feature will allow user to check the database connection status in query tool itself, it will also provide the detailed status as a tooltip when user hovers on it, the most benefit of the feature will be when user open query tool in new Browser Tab where Browser tree is not visible to user, user can also configure the status polling time using preference dialog.RM#2475Apart from that I have also removed the ..sqleditor/static/css/sqleditor.css reference from ../datagrid/templates/datagrid /index.html file because we are already bundling the "sqleditor.css" file in main "style.css" file.
Thanks to Chethana for his UI related inputs and to Surinder for helping me on html alignment issues.--Regards,--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Wed, Dec 20, 2017 at 1:03 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
![Inline image 1](/media/maillist_attaches/pgadmin-hackers/2017/12/20/CAFiP3vzOz-Msh5xwLU-ydD_ooYgZ+cd-0unWDxwBELarszndWA@mail.gmail.com/Screen Shot 2017-12-20 at 1.34.44 pm.png)
On Wed, Dec 20, 2017 at 12:17 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: --Harshal DhumalSr. Software EngineerOn Tue, Dec 19, 2017 at 7:47 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: On Tue, Dec 19, 2017 at 7:24 PM, Dave Page <dpage@pgadmin.org> wrote:HiInteresting. A few thoughts:- The pulsating icon is very off-putting. I think we need to make it only flash a couple of times when we actually need to attract the attention of the user.As per my discussion with Chethana, In his opinion user tends to notice things that way more quickly.Are you sure you wish to flash only couple of times on error?- We shouldn't really use tooltips like this, as it may confuse folks with screen readers. Should we make the icon clickable (which should have a visual hint)? Maybe a drop-down status panel.Sure let me check.- Do we need to poll separately for the status? Instead, why not update it whenever polling for results, or executing something?Then user won't be able to know the current connection status prior to query execution, the purpose of the feature is to make user aware of current connection status even if there is no query running, As most user tends to leave open their query tool window after their work it will be useful when flask session gets expired and connection to server gets closed after that.- Status Ideal and Active can be piggy backed (when we are polling query result).Checking for idle connection while polling the result is not possible. because when you press execute buttonthatmeansare trying to execute some query then how do you check for idle status whenthere is already aquery running, you will always get Busy status :)
We are using async connection. So to get result we're polling result every 0.1 seconds and wait for connection poll read.
So in same poll http request you can alway call
connection.get_transaction_status().
I just tried with select pg_sleep(1) and below is result.
Note the last line it says 0 means transaction status was changed to Ideal when query execution was completed and connection poll status was 1 (POLL_READ).
![Inline image 1](/media/maillist_attaches/pgadmin-hackers/2017/12/20/CAFiP3vzOz-Msh5xwLU-ydD_ooYgZ+cd-0unWDxwBELarszndWA@mail.gmail.com/Screen Shot 2017-12-20 at 1.34.44 pm.png)
- In case of connection closed then we are reconnecting seamlessly (as per your last comment on RM2475).So letting user know in advance that connection is closed does not provide any benefit.I wrote that for desktop version, because we are automatically logging-in user with each request if user is not authorized.Eventually user will look of any reconnect button/option in query tool to reconnect if we tell connection status in advance.- If flask session expires then (irrespective of connection status) status poll http request will be redirected to login page.So we won't get actual connection status in this case.Thanks!On Tue, Dec 19, 2017 at 11:42 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA patch to add the connection status in query tool, this feature will allow user to check the database connection status in query tool itself, it will also provide the detailed status as a tooltip when user hovers on it, the most benefit of the feature will be when user open query tool in new Browser Tab where Browser tree is not visible to user, user can also configure the status polling time using preference dialog.RM#2475Apart from that I have also removed the ..sqleditor/static/css/sqleditor.css reference from ../datagrid/templates/datagrid /index.html file because we are already bundling the "sqleditor.css" file in main "style.css" file.
Thanks to Chethana for his UI related inputs and to Surinder for helping me on html alignment issues.--Regards,--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Вложения
On Wed, Dec 20, 2017 at 1:51 PM, Harshal Dhumal <harshal.dhumal@enterprisedb. com> wrote:
On Wed, Dec 20, 2017 at 1:03 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: On Wed, Dec 20, 2017 at 12:17 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: --Harshal DhumalSr. Software EngineerOn Tue, Dec 19, 2017 at 7:47 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: On Tue, Dec 19, 2017 at 7:24 PM, Dave Page <dpage@pgadmin.org> wrote:HiInteresting. A few thoughts:- The pulsating icon is very off-putting. I think we need to make it only flash a couple of times when we actually need to attract the attention of the user.As per my discussion with Chethana, In his opinion user tends to notice things that way more quickly.Are you sure you wish to flash only couple of times on error?- We shouldn't really use tooltips like this, as it may confuse folks with screen readers. Should we make the icon clickable (which should have a visual hint)? Maybe a drop-down status panel.Sure let me check.- Do we need to poll separately for the status? Instead, why not update it whenever polling for results, or executing something?Then user won't be able to know the current connection status prior to query execution, the purpose of the feature is to make user aware of current connection status even if there is no query running, As most user tends to leave open their query tool window after their work it will be useful when flask session gets expired and connection to server gets closed after that.- Status Ideal and Active can be piggy backed (when we are polling query result).Checking for idle connection while polling the result is not possible. because when you press execute buttonthatmeansare trying to execute some query then how do you check for idle status whenthere is already aquery running, you will always get Busy status :)We are using async connection. So to get result we're polling result every 0.1 seconds and wait for connection poll read.So in same poll http request you can alway callconnection.get_transactio
n_status(). I just tried with select pg_sleep(1) and below is result.Note the last line it says 0 means transaction status was changed to Ideal when query execution was completed and connection poll status was 1 (POLL_READ).
As I mentioned in my previous email the
purpose of the feature is to make user aware of current connection status even
if there is no query running in query tool OR in easy words prior to query execution and after the
query execution
and not in-between the query execution.- In case of connection closed then we are reconnecting seamlessly (as per your last comment on RM2475).So letting user know in advance that connection is closed does not provide any benefit.I wrote that for desktop version, because we are automatically logging-in user with each request if user is not authorized.Eventually user will look of any reconnect button/option in query tool to reconnect if we tell connection status in advance.- If flask session expires then (irrespective of connection status) status poll http request will be redirected to login page.So we won't get actual connection status in this case.Thanks!On Tue, Dec 19, 2017 at 11:42 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA patch to add the connection status in query tool, this feature will allow user to check the database connection status in query tool itself, it will also provide the detailed status as a tooltip when user hovers on it, the most benefit of the feature will be when user open query tool in new Browser Tab where Browser tree is not visible to user, user can also configure the status polling time using preference dialog.RM#2475Apart from that I have also removed the ..sqleditor/static/css/sqleditor.css reference from ../datagrid/templates/datagrid /index.html file because we are already bundling the "sqleditor.css" file in main "style.css" file.
Thanks to Chethana for his UI related inputs and to Surinder for helping me on html alignment issues.--Regards,--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Вложения
Hi Team,
--
I have refined the icon once again for database connection status in query tool itself.
Below are the 5 different status that I have attached as screenshot -
1_busy
2_error_in_transaction
3_valid_transaction_in_idle
4_database_connected
5_database_disconnected
Please provide your inputs.
Regards,
Chethana kumar
On Tue, Dec 19, 2017 at 5:12 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,PFA patch to add the connection status in query tool, this feature will allow user to check the database connection status in query tool itself, it will also provide the detailed status as a tooltip when user hovers on it, the most benefit of the feature will be when user open query tool in new Browser Tab where Browser tree is not visible to user, user can also configure the status polling time using preference dialog.RM#2475Apart from that I have also removed the ..sqleditor/static/css/sqleditor.css reference from ../datagrid/templates/datagrid /index.html file because we are already bundling the "sqleditor.css" file in main "style.css" file.
Thanks to Chethana for his UI related inputs and to Surinder for helping me on html alignment issues.--Regards,
Chethana Kumar
Principal UI/UX Designer
EnterpriseDB Corporation
![](http://www.enterprisedb.com/sites/default/files/EDB-logo-4c.png)
![](http://www.enterprisedb.com/sites/default/files/EDB-logo-4c.png)
The Postgres Database Company
P: +91 86981 57146
Вложения
Hi
There are 2 icons that look the same except for colour. That’s not going to work for some users with colour blindness.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK:http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK:http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Hi Team,I have refined the icon once again for database connection status in query tool itself.Below are the 5 different status that I have attached as screenshot -1_busy2_error_in_transaction3_valid_transaction_in_idle4_database_connected5_database_disconnectedPlease provide your inputs.Regards,Chethana kumarOn Tue, Dec 19, 2017 at 5:12 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:Hi,PFA patch to add the connection status in query tool, this feature will allow user to check the database connection status in query tool itself, it will also provide the detailed status as a tooltip when user hovers on it, the most benefit of the feature will be when user open query tool in new Browser Tab where Browser tree is not visible to user, user can also configure the status polling time using preference dialog.RM#2475Apart from that I have also removed the ..sqleditor/static/css/sqleditor.css reference from ../datagrid/templates/datagrid /index.html file because we are already bundling the "sqleditor.css" file in main "style.css" file.
Thanks to Chethana for his UI related inputs and to Surinder for helping me on html alignment issues.--Regards,--Chethana KumarPrincipal UI/UX DesignerEnterpriseDB CorporationThe Postgres Database CompanyP: +91 86981 57146
<1_busy.jpg>
<2_error_in_transaction.jpg>
<3_valid_transaction_in_idle.jpg>
<4_database_connected.jpg>
<5_database_disconnected.jpg>
Yes Dave.
Now it is clearly differentiated, please check and confirm.
Thanks,
Chethana kumar
--
On Fri, Dec 22, 2017 at 12:08 AM, Dave Page <dpage@pgadmin.org> wrote:
HiThere are 2 icons that look the same except for colour. That’s not going to work for some users with colour blindness.--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK:http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On 21 Dec 2017, at 15:32, Chethana Kumar <chethana.kumar@enterprisedb.com> wrote: Hi Team,I have refined the icon once again for database connection status in query tool itself.Below are the 5 different status that I have attached as screenshot -1_busy2_error_in_transaction3_valid_transaction_in_idle4_database_connected5_database_disconnectedPlease provide your inputs.Regards,Chethana kumarOn Tue, Dec 19, 2017 at 5:12 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA patch to add the connection status in query tool, this feature will allow user to check the database connection status in query tool itself, it will also provide the detailed status as a tooltip when user hovers on it, the most benefit of the feature will be when user open query tool in new Browser Tab where Browser tree is not visible to user, user can also configure the status polling time using preference dialog.RM#2475Apart from that I have also removed the ..sqleditor/static/css/sqleditor.css reference from ../datagrid/templates/datagrid /index.html file because we are already bundling the "sqleditor.css" file in main "style.css" file.
Thanks to Chethana for his UI related inputs and to Surinder for helping me on html alignment issues.--Regards,--Chethana KumarPrincipal UI/UX DesignerEnterpriseDB CorporationThe Postgres Database CompanyP: +91 86981 57146<1_busy.jpg><2_error_in_transaction.jpg><3_valid_transaction_in_idle.jpg> <4_database_connected.jpg><5_database_disconnected.jpg>
Chethana Kumar
Principal UI/UX Designer
EnterpriseDB Corporation
![](http://www.enterprisedb.com/sites/default/files/EDB-logo-4c.png)
![](http://www.enterprisedb.com/sites/default/files/EDB-logo-4c.png)
The Postgres Database Company
P: +91 86981 57146
Вложения
Hi Chetana,
We have all the suggested icons in font awesome icon pack :)
Connected: http://fontawesome.io/icon/link
Disconnected: http://fontawesome.io/icon/chain-broken/
Idle in TX: http://fontawesome.io/icon/clock-o/
Error in TX: http://fontawesome.io/icon/exclamation-triangle/
On Fri, Dec 22, 2017 at 11:53 AM, Chethana Kumar <chethana.kumar@enterprisedb.com> wrote:
Yes Dave.Now it is clearly differentiated, please check and confirm.Thanks,Chethana kumarOn Fri, Dec 22, 2017 at 12:08 AM, Dave Page <dpage@pgadmin.org> wrote:HiThere are 2 icons that look the same except for colour. That’s not going to work for some users with colour blindness.--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK:http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On 21 Dec 2017, at 15:32, Chethana Kumar <chethana.kumar@enterprisedb.com> wrote: Hi Team,I have refined the icon once again for database connection status in query tool itself.Below are the 5 different status that I have attached as screenshot -1_busy2_error_in_transaction3_valid_transaction_in_idle4_database_connected5_database_disconnectedPlease provide your inputs.Regards,Chethana kumarOn Tue, Dec 19, 2017 at 5:12 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA patch to add the connection status in query tool, this feature will allow user to check the database connection status in query tool itself, it will also provide the detailed status as a tooltip when user hovers on it, the most benefit of the feature will be when user open query tool in new Browser Tab where Browser tree is not visible to user, user can also configure the status polling time using preference dialog.RM#2475Apart from that I have also removed the ..sqleditor/static/css/sqleditor.css reference from ../datagrid/templates/datagrid /index.html file because we are already bundling the "sqleditor.css" file in main "style.css" file.
Thanks to Chethana for his UI related inputs and to Surinder for helping me on html alignment issues.--Regards,--Chethana KumarPrincipal UI/UX DesignerEnterpriseDB CorporationThe Postgres Database CompanyP: +91 86981 57146<1_busy.jpg><2_error_in_transaction.jpg><3_valid_transaction_in_idle.jpg> <4_database_connected.jpg><5_database_disconnected.jpg>--Chethana KumarPrincipal UI/UX DesignerEnterpriseDB CorporationThe Postgres Database CompanyP: +91 86981 57146
Hi,
PFA updated patch based on new design suggested by Chethana.
The patch also includes some misc fixes related to object validation.
RM#2475
Please review.
--![](https://drive.google.com/a/enterprisedb.com/uc?id=0B6jGeB3BfKRMV0t4MEp0YnZCTTA&export=download)
Regards,
On Fri, Dec 22, 2017 at 11:53 AM, Chethana Kumar <chethana.kumar@enterprisedb.com> wrote:
Yes Dave.Now it is clearly differentiated, please check and confirm.Thanks,Chethana kumarOn Fri, Dec 22, 2017 at 12:08 AM, Dave Page <dpage@pgadmin.org> wrote:HiThere are 2 icons that look the same except for colour. That’s not going to work for some users with colour blindness.--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK:http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On 21 Dec 2017, at 15:32, Chethana Kumar <chethana.kumar@enterprisedb.com> wrote: Hi Team,I have refined the icon once again for database connection status in query tool itself.Below are the 5 different status that I have attached as screenshot -1_busy2_error_in_transaction3_valid_transaction_in_idle4_database_connected5_database_disconnectedPlease provide your inputs.Regards,Chethana kumarOn Tue, Dec 19, 2017 at 5:12 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA patch to add the connection status in query tool, this feature will allow user to check the database connection status in query tool itself, it will also provide the detailed status as a tooltip when user hovers on it, the most benefit of the feature will be when user open query tool in new Browser Tab where Browser tree is not visible to user, user can also configure the status polling time using preference dialog.RM#2475Apart from that I have also removed the ..sqleditor/static/css/sqleditor.css reference from ../datagrid/templates/datagrid /index.html file because we are already bundling the "sqleditor.css" file in main "style.css" file.
Thanks to Chethana for his UI related inputs and to Surinder for helping me on html alignment issues.--Regards,--Chethana KumarPrincipal UI/UX DesignerEnterpriseDB CorporationThe Postgres Database CompanyP: +91 86981 57146<1_busy.jpg><2_error_in_transaction.jpg><3_valid_transaction_in_idle.jpg> <4_database_connected.jpg><5_database_disconnected.jpg>--Chethana KumarPrincipal UI/UX DesignerEnterpriseDB CorporationThe Postgres Database CompanyP: +91 86981 57146
Вложения
Hi
--
On Thu, Dec 28, 2017 at 9:38 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,PFA updated patch based on new design suggested by Chethana.The patch also includes some misc fixes related to object validation.RM#2475
This seems much nicer, but I still think there are some tweaks to make:
1) If I open a query tool, and then stop the application server, the icon is updated to show the broken connection. However, unless I execute a query in the query tool before the server is shut down, the connection status won't recover when the server is restarted. If I do run a query first (SELECT 1; will do), then the connection status will recover.
2) I think the "connected" icon should be in $primary-blue (#2c76b4). The green is ugly and not overly easy to read. It's also distracting as it catches the eye, which the default, non-error state should not do.
3) I'm not overly happy with the the status text popover. After some thought, I think it's because there are no visual clues that you should click on the icon to see it - and Karen seems to be of a similar opinion. Can we put a small marker there, perhaps a triangle on the bottom-right, like you get on a spreadsheet cell if you add a comment/note? We should also have a hotkey and I guess a tooltip, e.g. "Connection status Ctrl+Alt+S" or similar.
Thanks!
Please review.--Regards,On Fri, Dec 22, 2017 at 11:53 AM, Chethana Kumar <chethana.kumar@enterprisedb.com> wrote: Yes Dave.Now it is clearly differentiated, please check and confirm.Thanks,Chethana kumarOn Fri, Dec 22, 2017 at 12:08 AM, Dave Page <dpage@pgadmin.org> wrote:HiThere are 2 icons that look the same except for colour. That’s not going to work for some users with colour blindness.--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK:http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On 21 Dec 2017, at 15:32, Chethana Kumar <chethana.kumar@enterprisedb.com> wrote: Hi Team,I have refined the icon once again for database connection status in query tool itself.Below are the 5 different status that I have attached as screenshot -1_busy2_error_in_transaction3_valid_transaction_in_idle4_database_connected5_database_disconnectedPlease provide your inputs.Regards,Chethana kumarOn Tue, Dec 19, 2017 at 5:12 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA patch to add the connection status in query tool, this feature will allow user to check the database connection status in query tool itself, it will also provide the detailed status as a tooltip when user hovers on it, the most benefit of the feature will be when user open query tool in new Browser Tab where Browser tree is not visible to user, user can also configure the status polling time using preference dialog.RM#2475Apart from that I have also removed the ..sqleditor/static/css/sqleditor.css reference from ../datagrid/templates/datagrid /index.html file because we are already bundling the "sqleditor.css" file in main "style.css" file.
Thanks to Chethana for his UI related inputs and to Surinder for helping me on html alignment issues.--Regards,--Chethana KumarPrincipal UI/UX DesignerEnterpriseDB CorporationThe Postgres Database Company<1_busy.jpg><2_error_in_transaction.jpg><3_valid_transaction_in_idle.jpg> <4_database_connected.jpg><5_database_disconnected.jpg>--Chethana KumarPrincipal UI/UX DesignerEnterpriseDB CorporationThe Postgres Database Company
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Hi Dave,
PFA updated patch,
On Wed, Jan 3, 2018 at 10:44 PM, Dave Page <dpage@pgadmin.org> wrote:
HiOn Thu, Dec 28, 2017 at 9:38 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA updated patch based on new design suggested by Chethana.The patch also includes some misc fixes related to object validation.RM#2475This seems much nicer, but I still think there are some tweaks to make:1) If I open a query tool, and then stop the application server, the icon is updated to show the broken connection. However, unless I execute a query in the query tool before the server is shut down, the connection status won't recover when the server is restarted. If I do run a query first (SELECT 1; will do), then the connection status will recover.
I have logged /issues/2983
https://redmine.postgresql.org2) I think the "connected" icon should be in $primary-blue (#2c76b4). The green is ugly and not overly easy to read. It's also distracting as it catches the eye, which the default, non-error state should not do.
Fixed
3) I'm not overly happy with the the status text popover. After some thought, I think it's because there are no visual clues that you should click on the icon to see it - and Karen seems to be of a similar opinion. Can we put a small marker there, perhaps a triangle on the bottom-right, like you get on a spreadsheet cell if you add a comment/note? We should also have a hotkey and I guess a tooltip, e.g. "Connection status Ctrl+Alt+S" or similar.
Fixed
, added accesskey 'T' for TX status tooltip shortcut as 'S' is already taken for Save file option
Thanks!Please review.--Regards,On Fri, Dec 22, 2017 at 11:53 AM, Chethana Kumar <chethana.kumar@enterprisedb.com> wrote: Yes Dave.Now it is clearly differentiated, please check and confirm.Thanks,Chethana kumarOn Fri, Dec 22, 2017 at 12:08 AM, Dave Page <dpage@pgadmin.org> wrote:HiThere are 2 icons that look the same except for colour. That’s not going to work for some users with colour blindness.--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK:http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On 21 Dec 2017, at 15:32, Chethana Kumar <chethana.kumar@enterprisedb.com> wrote: Hi Team,I have refined the icon once again for database connection status in query tool itself.Below are the 5 different status that I have attached as screenshot -1_busy2_error_in_transaction3_valid_transaction_in_idle4_database_connected5_database_disconnectedPlease provide your inputs.Regards,Chethana kumarOn Tue, Dec 19, 2017 at 5:12 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA patch to add the connection status in query tool, this feature will allow user to check the database connection status in query tool itself, it will also provide the detailed status as a tooltip when user hovers on it, the most benefit of the feature will be when user open query tool in new Browser Tab where Browser tree is not visible to user, user can also configure the status polling time using preference dialog.RM#2475Apart from that I have also removed the ..sqleditor/static/css/sqleditor.css reference from ../datagrid/templates/datagrid /index.html file because we are already bundling the "sqleditor.css" file in main "style.css" file.
Thanks to Chethana for his UI related inputs and to Surinder for helping me on html alignment issues.--Regards,--Chethana KumarPrincipal UI/UX DesignerEnterpriseDB CorporationThe Postgres Database Company<1_busy.jpg><2_error_in_transaction.jpg><3_valid_transaction_in_idle.jpg> <4_database_connected.jpg><5_database_disconnected.jpg>--Chethana KumarPrincipal UI/UX DesignerEnterpriseDB CorporationThe Postgres Database Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Вложения
On Fri, Jan 5, 2018 at 8:49 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Dave,PFA updated patch,On Wed, Jan 3, 2018 at 10:44 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Thu, Dec 28, 2017 at 9:38 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA updated patch based on new design suggested by Chethana.The patch also includes some misc fixes related to object validation.RM#2475This seems much nicer, but I still think there are some tweaks to make:1) If I open a query tool, and then stop the application server, the icon is updated to show the broken connection. However, unless I execute a query in the query tool before the server is shut down, the connection status won't recover when the server is restarted. If I do run a query first (SELECT 1; will do), then the connection status will recover.I have loggedhttps://redmine.postgresql.org/issues/2983
I'm not sure that's the same issue is it?
2) I think the "connected" icon should be in $primary-blue (#2c76b4). The green is ugly and not overly easy to read. It's also distracting as it catches the eye, which the default, non-error state should not do.Fixed3) I'm not overly happy with the the status text popover. After some thought, I think it's because there are no visual clues that you should click on the icon to see it - and Karen seems to be of a similar opinion. Can we put a small marker there, perhaps a triangle on the bottom-right, like you get on a spreadsheet cell if you add a comment/note? We should also have a hotkey and I guess a tooltip, e.g. "Connection status Ctrl+Alt+S" or similar.Fixed, added accesskey 'T' for TX status tooltip shortcut as 'S' is already taken for Save file optionThanks!Please review.--Regards,On Fri, Dec 22, 2017 at 11:53 AM, Chethana Kumar <chethana.kumar@enterprisedb.com> wrote: Yes Dave.Now it is clearly differentiated, please check and confirm.Thanks,Chethana kumarOn Fri, Dec 22, 2017 at 12:08 AM, Dave Page <dpage@pgadmin.org> wrote:HiThere are 2 icons that look the same except for colour. That’s not going to work for some users with colour blindness.--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK:http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On 21 Dec 2017, at 15:32, Chethana Kumar <chethana.kumar@enterprisedb.com> wrote: Hi Team,I have refined the icon once again for database connection status in query tool itself.Below are the 5 different status that I have attached as screenshot -1_busy2_error_in_transaction3_valid_transaction_in_idle4_database_connected5_database_disconnectedPlease provide your inputs.Regards,Chethana kumarOn Tue, Dec 19, 2017 at 5:12 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA patch to add the connection status in query tool, this feature will allow user to check the database connection status in query tool itself, it will also provide the detailed status as a tooltip when user hovers on it, the most benefit of the feature will be when user open query tool in new Browser Tab where Browser tree is not visible to user, user can also configure the status polling time using preference dialog.RM#2475Apart from that I have also removed the ..sqleditor/static/css/sqleditor.css reference from ../datagrid/templates/datagrid /index.html file because we are already bundling the "sqleditor.css" file in main "style.css" file.
Thanks to Chethana for his UI related inputs and to Surinder for helping me on html alignment issues.--Regards,--Chethana KumarPrincipal UI/UX DesignerEnterpriseDB CorporationThe Postgres Database Company<1_busy.jpg><2_error_in_transaction.jpg><3_valid_transaction_in_idle.jpg> <4_database_connected.jpg><5_database_disconnected.jpg>--Chethana KumarPrincipal UI/UX DesignerEnterpriseDB CorporationThe Postgres Database Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Fri, Jan 5, 2018 at 2:57 PM, Dave Page <dpage@pgadmin.org> wrote:
On Fri, Jan 5, 2018 at 8:49 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA updated patch,On Wed, Jan 3, 2018 at 10:44 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Thu, Dec 28, 2017 at 9:38 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA updated patch based on new design suggested by Chethana.The patch also includes some misc fixes related to object validation.RM#2475This seems much nicer, but I still think there are some tweaks to make:1) If I open a query tool, and then stop the application server, the icon is updated to show the broken connection. However, unless I execute a query in the query tool before the server is shut down, the connection status won't recover when the server is restarted. If I do run a query first (SELECT 1; will do), then the connection status will recover.I have loggedhttps://redmine.postgresql.org/issues/2983 I'm not sure that's the same issue is it?
Yes, it's the same issue due to which pgAdmin is not able to restore connection.
2) I think the "connected" icon should be in $primary-blue (#2c76b4). The green is ugly and not overly easy to read. It's also distracting as it catches the eye, which the default, non-error state should not do.Fixed3) I'm not overly happy with the the status text popover. After some thought, I think it's because there are no visual clues that you should click on the icon to see it - and Karen seems to be of a similar opinion. Can we put a small marker there, perhaps a triangle on the bottom-right, like you get on a spreadsheet cell if you add a comment/note? We should also have a hotkey and I guess a tooltip, e.g. "Connection status Ctrl+Alt+S" or similar.Fixed, added accesskey 'T' for TX status tooltip shortcut as 'S' is already taken for Save file optionThanks!Please review.--Regards,On Fri, Dec 22, 2017 at 11:53 AM, Chethana Kumar <chethana.kumar@enterprisedb.com> wrote: Yes Dave.Now it is clearly differentiated, please check and confirm.Thanks,Chethana kumarOn Fri, Dec 22, 2017 at 12:08 AM, Dave Page <dpage@pgadmin.org> wrote:HiThere are 2 icons that look the same except for colour. That’s not going to work for some users with colour blindness.--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK:http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On 21 Dec 2017, at 15:32, Chethana Kumar <chethana.kumar@enterprisedb.com> wrote: Hi Team,I have refined the icon once again for database connection status in query tool itself.Below are the 5 different status that I have attached as screenshot -1_busy2_error_in_transaction3_valid_transaction_in_idle4_database_connected5_database_disconnectedPlease provide your inputs.Regards,Chethana kumarOn Tue, Dec 19, 2017 at 5:12 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA patch to add the connection status in query tool, this feature will allow user to check the database connection status in query tool itself, it will also provide the detailed status as a tooltip when user hovers on it, the most benefit of the feature will be when user open query tool in new Browser Tab where Browser tree is not visible to user, user can also configure the status polling time using preference dialog.RM#2475Apart from that I have also removed the ..sqleditor/static/css/sqleditor.css reference from ../datagrid/templates/datagrid /index.html file because we are already bundling the "sqleditor.css" file in main "style.css" file.
Thanks to Chethana for his UI related inputs and to Surinder for helping me on html alignment issues.--Regards,--Chethana KumarPrincipal UI/UX DesignerEnterpriseDB CorporationThe Postgres Database Company<1_busy.jpg><2_error_in_transaction.jpg><3_valid_transaction_in_idle.jpg> <4_database_connected.jpg><5_database_disconnected.jpg>--Chethana KumarPrincipal UI/UX DesignerEnterpriseDB CorporationThe Postgres Database Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Hi
--
On Fri, Jan 5, 2018 at 8:49 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Dave,PFA updated patch,On Wed, Jan 3, 2018 at 10:44 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Thu, Dec 28, 2017 at 9:38 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA updated patch based on new design suggested by Chethana.The patch also includes some misc fixes related to object validation.RM#2475This seems much nicer, but I still think there are some tweaks to make:1) If I open a query tool, and then stop the application server, the icon is updated to show the broken connection. However, unless I execute a query in the query tool before the server is shut down, the connection status won't recover when the server is restarted. If I do run a query first (SELECT 1; will do), then the connection status will recover.I have loggedhttps://redmine.postgresql.org/issues/2983 2) I think the "connected" icon should be in $primary-blue (#2c76b4). The green is ugly and not overly easy to read. It's also distracting as it catches the eye, which the default, non-error state should not do.Fixed
Much better.
3) I'm not overly happy with the the status text popover. After some thought, I think it's because there are no visual clues that you should click on the icon to see it - and Karen seems to be of a similar opinion. Can we put a small marker there, perhaps a triangle on the bottom-right, like you get on a spreadsheet cell if you add a comment/note? We should also have a hotkey and I guess a tooltip, e.g. "Connection status Ctrl+Alt+S" or similar.Fixed, added accesskey 'T' for TX status tooltip shortcut as 'S' is already taken for Save file option
Hmm - having seen it, I don't think the marker helps us.
Can you remove it, and fix the tooltip (which doesn't seem to work)? If we always have the tooltip say "Connection status Ctrl+Alt+T" (or whatever is appropriate for the platform/browser), then that should give the user enough hint to click.
Thanks!
Thanks!Please review.--Regards,On Fri, Dec 22, 2017 at 11:53 AM, Chethana Kumar <chethana.kumar@enterprisedb.com> wrote: Yes Dave.Now it is clearly differentiated, please check and confirm.Thanks,Chethana kumarOn Fri, Dec 22, 2017 at 12:08 AM, Dave Page <dpage@pgadmin.org> wrote:HiThere are 2 icons that look the same except for colour. That’s not going to work for some users with colour blindness.--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK:http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On 21 Dec 2017, at 15:32, Chethana Kumar <chethana.kumar@enterprisedb.com> wrote: Hi Team,I have refined the icon once again for database connection status in query tool itself.Below are the 5 different status that I have attached as screenshot -1_busy2_error_in_transaction3_valid_transaction_in_idle4_database_connected5_database_disconnectedPlease provide your inputs.Regards,Chethana kumarOn Tue, Dec 19, 2017 at 5:12 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA patch to add the connection status in query tool, this feature will allow user to check the database connection status in query tool itself, it will also provide the detailed status as a tooltip when user hovers on it, the most benefit of the feature will be when user open query tool in new Browser Tab where Browser tree is not visible to user, user can also configure the status polling time using preference dialog.RM#2475Apart from that I have also removed the ..sqleditor/static/css/sqleditor.css reference from ../datagrid/templates/datagrid /index.html file because we are already bundling the "sqleditor.css" file in main "style.css" file.
Thanks to Chethana for his UI related inputs and to Surinder for helping me on html alignment issues.--Regards,--Chethana KumarPrincipal UI/UX DesignerEnterpriseDB CorporationThe Postgres Database Company<1_busy.jpg><2_error_in_transaction.jpg><3_valid_transaction_in_idle.jpg> <4_database_connected.jpg><5_database_disconnected.jpg>--Chethana KumarPrincipal UI/UX DesignerEnterpriseDB CorporationThe Postgres Database Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Hi Dave,
PFA updated patch.
On Mon, Jan 8, 2018 at 5:11 PM, Dave Page <dpage@pgadmin.org> wrote:
HiOn Fri, Jan 5, 2018 at 8:49 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA updated patch,On Wed, Jan 3, 2018 at 10:44 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Thu, Dec 28, 2017 at 9:38 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA updated patch based on new design suggested by Chethana.The patch also includes some misc fixes related to object validation.RM#2475This seems much nicer, but I still think there are some tweaks to make:1) If I open a query tool, and then stop the application server, the icon is updated to show the broken connection. However, unless I execute a query in the query tool before the server is shut down, the connection status won't recover when the server is restarted. If I do run a query first (SELECT 1; will do), then the connection status will recover.I have loggedhttps://redmine.postgresql.org/issues/2983 2) I think the "connected" icon should be in $primary-blue (#2c76b4). The green is ugly and not overly easy to read. It's also distracting as it catches the eye, which the default, non-error state should not do.FixedMuch better.3) I'm not overly happy with the the status text popover. After some thought, I think it's because there are no visual clues that you should click on the icon to see it - and Karen seems to be of a similar opinion. Can we put a small marker there, perhaps a triangle on the bottom-right, like you get on a spreadsheet cell if you add a comment/note? We should also have a hotkey and I guess a tooltip, e.g. "Connection status Ctrl+Alt+S" or similar.Fixed, added accesskey 'T' for TX status tooltip shortcut as 'S' is already taken for Save file optionHmm - having seen it, I don't think the marker helps us.Can you remove it, and fix the tooltip (which doesn't seem to work)? If we always have the tooltip say "Connection status Ctrl+Alt+T" (or whatever is appropriate for the platform/browser), then that should give the user enough hint to click.
Fixed.
I have removed the marker & added tooltip instead but it is not possible to add specific shortcut keys in tooltip because accesskey may vary depending on OS & browser.
Thanks!Thanks!Please review.--Regards,On Fri, Dec 22, 2017 at 11:53 AM, Chethana Kumar <chethana.kumar@enterprisedb.com> wrote: Yes Dave.Now it is clearly differentiated, please check and confirm.Thanks,Chethana kumarOn Fri, Dec 22, 2017 at 12:08 AM, Dave Page <dpage@pgadmin.org> wrote:HiThere are 2 icons that look the same except for colour. That’s not going to work for some users with colour blindness.--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK:http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On 21 Dec 2017, at 15:32, Chethana Kumar <chethana.kumar@enterprisedb.com> wrote: Hi Team,I have refined the icon once again for database connection status in query tool itself.Below are the 5 different status that I have attached as screenshot -1_busy2_error_in_transaction3_valid_transaction_in_idle4_database_connected5_database_disconnectedPlease provide your inputs.Regards,Chethana kumarOn Tue, Dec 19, 2017 at 5:12 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA patch to add the connection status in query tool, this feature will allow user to check the database connection status in query tool itself, it will also provide the detailed status as a tooltip when user hovers on it, the most benefit of the feature will be when user open query tool in new Browser Tab where Browser tree is not visible to user, user can also configure the status polling time using preference dialog.RM#2475Apart from that I have also removed the ..sqleditor/static/css/sqleditor.css reference from ../datagrid/templates/datagrid /index.html file because we are already bundling the "sqleditor.css" file in main "style.css" file.
Thanks to Chethana for his UI related inputs and to Surinder for helping me on html alignment issues.--Regards,--Chethana KumarPrincipal UI/UX DesignerEnterpriseDB CorporationThe Postgres Database Company<1_busy.jpg><2_error_in_transaction.jpg><3_valid_transaction_in_idle.jpg> <4_database_connected.jpg><5_database_disconnected.jpg>--Chethana KumarPrincipal UI/UX DesignerEnterpriseDB CorporationThe Postgres Database Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Вложения
On Mon, Jan 8, 2018 at 1:24 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Dave,PFA updated patch.On Mon, Jan 8, 2018 at 5:11 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Fri, Jan 5, 2018 at 8:49 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA updated patch,On Wed, Jan 3, 2018 at 10:44 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Thu, Dec 28, 2017 at 9:38 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA updated patch based on new design suggested by Chethana.The patch also includes some misc fixes related to object validation.RM#2475This seems much nicer, but I still think there are some tweaks to make:1) If I open a query tool, and then stop the application server, the icon is updated to show the broken connection. However, unless I execute a query in the query tool before the server is shut down, the connection status won't recover when the server is restarted. If I do run a query first (SELECT 1; will do), then the connection status will recover.I have loggedhttps://redmine.postgresql.org/issues/2983 2) I think the "connected" icon should be in $primary-blue (#2c76b4). The green is ugly and not overly easy to read. It's also distracting as it catches the eye, which the default, non-error state should not do.FixedMuch better.3) I'm not overly happy with the the status text popover. After some thought, I think it's because there are no visual clues that you should click on the icon to see it - and Karen seems to be of a similar opinion. Can we put a small marker there, perhaps a triangle on the bottom-right, like you get on a spreadsheet cell if you add a comment/note? We should also have a hotkey and I guess a tooltip, e.g. "Connection status Ctrl+Alt+S" or similar.Fixed, added accesskey 'T' for TX status tooltip shortcut as 'S' is already taken for Save file optionHmm - having seen it, I don't think the marker helps us.Can you remove it, and fix the tooltip (which doesn't seem to work)? If we always have the tooltip say "Connection status Ctrl+Alt+T" (or whatever is appropriate for the platform/browser), then that should give the user enough hint to click.Fixed.I have removed the marker & added tooltip instead but it is not possible to add specific shortcut keys in tooltip because accesskey may vary depending on OS & browser.
That's better - though I think the tool tip is better as something like:
Connection status (click for details) (<accesskey>+T)
I'm still not overly happy with all the polling that's going on though. It's a lot of requests, especially with multiple QTs open. I think we need to be able to disable the feature entirely through a switch in the Preferences. In that case, no icon would be shown, and polling would be disabled - i.e. everything would be as it is now.
What do you think?
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Mon, Jan 8, 2018 at 7:21 PM, Dave Page <dpage@pgadmin.org> wrote:
On Mon, Jan 8, 2018 at 1:24 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA updated patch.On Mon, Jan 8, 2018 at 5:11 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Fri, Jan 5, 2018 at 8:49 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA updated patch,On Wed, Jan 3, 2018 at 10:44 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Thu, Dec 28, 2017 at 9:38 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA updated patch based on new design suggested by Chethana.The patch also includes some misc fixes related to object validation.RM#2475This seems much nicer, but I still think there are some tweaks to make:1) If I open a query tool, and then stop the application server, the icon is updated to show the broken connection. However, unless I execute a query in the query tool before the server is shut down, the connection status won't recover when the server is restarted. If I do run a query first (SELECT 1; will do), then the connection status will recover.I have loggedhttps://redmine.postgresql.org/issues/2983 2) I think the "connected" icon should be in $primary-blue (#2c76b4). The green is ugly and not overly easy to read. It's also distracting as it catches the eye, which the default, non-error state should not do.FixedMuch better.3) I'm not overly happy with the the status text popover. After some thought, I think it's because there are no visual clues that you should click on the icon to see it - and Karen seems to be of a similar opinion. Can we put a small marker there, perhaps a triangle on the bottom-right, like you get on a spreadsheet cell if you add a comment/note? We should also have a hotkey and I guess a tooltip, e.g. "Connection status Ctrl+Alt+S" or similar.Fixed, added accesskey 'T' for TX status tooltip shortcut as 'S' is already taken for Save file optionHmm - having seen it, I don't think the marker helps us.Can you remove it, and fix the tooltip (which doesn't seem to work)? If we always have the tooltip say "Connection status Ctrl+Alt+T" (or whatever is appropriate for the platform/browser), then that should give the user enough hint to click.Fixed.I have removed the marker & added tooltip instead but it is not possible to add specific shortcut keys in tooltip because accesskey may vary depending on OS & browser.That's better - though I think the tool tip is better as something like:Connection status (click for details) (<accesskey>+T)I'm still not overly happy with all the polling that's going on though. It's a lot of requests, especially with multiple QTs open. I think we need to be able to disable the feature entirely through a switch in the Preferences. In that case, no icon would be shown, and polling would be disabled - i.e. everything would be as it is now.What do you think?
+1
-- Thanks, Ashesh
--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Yes, I agree, it's a good idea to have it optional, I'll work on it and send updated patch.
by the way what should be default behaviour? Should we make it disabled by default?
On Mon, Jan 8, 2018 at 7:26 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
On Mon, Jan 8, 2018 at 7:21 PM, Dave Page <dpage@pgadmin.org> wrote:On Mon, Jan 8, 2018 at 1:24 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA updated patch.On Mon, Jan 8, 2018 at 5:11 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Fri, Jan 5, 2018 at 8:49 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA updated patch,On Wed, Jan 3, 2018 at 10:44 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Thu, Dec 28, 2017 at 9:38 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA updated patch based on new design suggested by Chethana.The patch also includes some misc fixes related to object validation.RM#2475This seems much nicer, but I still think there are some tweaks to make:1) If I open a query tool, and then stop the application server, the icon is updated to show the broken connection. However, unless I execute a query in the query tool before the server is shut down, the connection status won't recover when the server is restarted. If I do run a query first (SELECT 1; will do), then the connection status will recover.I have loggedhttps://redmine.postgresql.org/issues/2983 2) I think the "connected" icon should be in $primary-blue (#2c76b4). The green is ugly and not overly easy to read. It's also distracting as it catches the eye, which the default, non-error state should not do.FixedMuch better.3) I'm not overly happy with the the status text popover. After some thought, I think it's because there are no visual clues that you should click on the icon to see it - and Karen seems to be of a similar opinion. Can we put a small marker there, perhaps a triangle on the bottom-right, like you get on a spreadsheet cell if you add a comment/note? We should also have a hotkey and I guess a tooltip, e.g. "Connection status Ctrl+Alt+S" or similar.Fixed, added accesskey 'T' for TX status tooltip shortcut as 'S' is already taken for Save file optionHmm - having seen it, I don't think the marker helps us.Can you remove it, and fix the tooltip (which doesn't seem to work)? If we always have the tooltip say "Connection status Ctrl+Alt+T" (or whatever is appropriate for the platform/browser), then that should give the user enough hint to click.Fixed.I have removed the marker & added tooltip instead but it is not possible to add specific shortcut keys in tooltip because accesskey may vary depending on OS & browser.That's better - though I think the tool tip is better as something like:Connection status (click for details) (<accesskey>+T)I'm still not overly happy with all the polling that's going on though. It's a lot of requests, especially with multiple QTs open. I think we need to be able to disable the feature entirely through a switch in the Preferences. In that case, no icon would be shown, and polling would be disabled - i.e. everything would be as it is now.What do you think?+1-- Thanks, Ashesh--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Mon, Jan 8, 2018 at 2:04 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Yes, I agree, it's a good idea to have it optional, I'll work on it and send updated patch.by the way what should be default behaviour? Should we make it disabled by default?
No - users probably won't find it then. I wonder if we should make the default poll interval a couple of seconds (or more) though.
On Mon, Jan 8, 2018 at 7:26 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote: On Mon, Jan 8, 2018 at 7:21 PM, Dave Page <dpage@pgadmin.org> wrote:On Mon, Jan 8, 2018 at 1:24 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA updated patch.On Mon, Jan 8, 2018 at 5:11 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Fri, Jan 5, 2018 at 8:49 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA updated patch,On Wed, Jan 3, 2018 at 10:44 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Thu, Dec 28, 2017 at 9:38 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA updated patch based on new design suggested by Chethana.The patch also includes some misc fixes related to object validation.RM#2475This seems much nicer, but I still think there are some tweaks to make:1) If I open a query tool, and then stop the application server, the icon is updated to show the broken connection. However, unless I execute a query in the query tool before the server is shut down, the connection status won't recover when the server is restarted. If I do run a query first (SELECT 1; will do), then the connection status will recover.I have loggedhttps://redmine.postgresql.org/issues/2983 2) I think the "connected" icon should be in $primary-blue (#2c76b4). The green is ugly and not overly easy to read. It's also distracting as it catches the eye, which the default, non-error state should not do.FixedMuch better.3) I'm not overly happy with the the status text popover. After some thought, I think it's because there are no visual clues that you should click on the icon to see it - and Karen seems to be of a similar opinion. Can we put a small marker there, perhaps a triangle on the bottom-right, like you get on a spreadsheet cell if you add a comment/note? We should also have a hotkey and I guess a tooltip, e.g. "Connection status Ctrl+Alt+S" or similar.Fixed, added accesskey 'T' for TX status tooltip shortcut as 'S' is already taken for Save file optionHmm - having seen it, I don't think the marker helps us.Can you remove it, and fix the tooltip (which doesn't seem to work)? If we always have the tooltip say "Connection status Ctrl+Alt+T" (or whatever is appropriate for the platform/browser), then that should give the user enough hint to click.Fixed.I have removed the marker & added tooltip instead but it is not possible to add specific shortcut keys in tooltip because accesskey may vary depending on OS & browser.That's better - though I think the tool tip is better as something like:Connection status (click for details) (<accesskey>+T)I'm still not overly happy with all the polling that's going on though. It's a lot of requests, especially with multiple QTs open. I think we need to be able to disable the feature entirely through a switch in the Preferences. In that case, no icon would be shown, and polling would be disabled - i.e. everything would be as it is now.What do you think?+1-- Thanks, Ashesh--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Hi Dave,
Please find updated patch.
On Mon, Jan 8, 2018 at 7:21 PM, Dave Page <dpage@pgadmin.org> wrote:
On Mon, Jan 8, 2018 at 1:24 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA updated patch.On Mon, Jan 8, 2018 at 5:11 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Fri, Jan 5, 2018 at 8:49 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA updated patch,On Wed, Jan 3, 2018 at 10:44 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Thu, Dec 28, 2017 at 9:38 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA updated patch based on new design suggested by Chethana.The patch also includes some misc fixes related to object validation.RM#2475This seems much nicer, but I still think there are some tweaks to make:1) If I open a query tool, and then stop the application server, the icon is updated to show the broken connection. However, unless I execute a query in the query tool before the server is shut down, the connection status won't recover when the server is restarted. If I do run a query first (SELECT 1; will do), then the connection status will recover.I have loggedhttps://redmine.postgresql.org/issues/2983 2) I think the "connected" icon should be in $primary-blue (#2c76b4). The green is ugly and not overly easy to read. It's also distracting as it catches the eye, which the default, non-error state should not do.FixedMuch better.3) I'm not overly happy with the the status text popover. After some thought, I think it's because there are no visual clues that you should click on the icon to see it - and Karen seems to be of a similar opinion. Can we put a small marker there, perhaps a triangle on the bottom-right, like you get on a spreadsheet cell if you add a comment/note? We should also have a hotkey and I guess a tooltip, e.g. "Connection status Ctrl+Alt+S" or similar.Fixed, added accesskey 'T' for TX status tooltip shortcut as 'S' is already taken for Save file optionHmm - having seen it, I don't think the marker helps us.Can you remove it, and fix the tooltip (which doesn't seem to work)? If we always have the tooltip say "Connection status Ctrl+Alt+T" (or whatever is appropriate for the platform/browser), then that should give the user enough hint to click.Fixed.I have removed the marker & added tooltip instead but it is not possible to add specific shortcut keys in tooltip because accesskey may vary depending on OS & browser.That's better - though I think the tool tip is better as something like:Connection status (click for details) (<accesskey>+T)I'm still not overly happy with all the polling that's going on though. It's a lot of requests, especially with multiple QTs open. I think we need to be able to disable the feature entirely through a switch in the Preferences. In that case, no icon would be shown, and polling would be disabled - i.e. everything would be as it is now.What do you think?
Fixed
Made it configurable & set default polling time to 10sec.
Please review.
--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Вложения
Hi
--
On Tue, Jan 9, 2018 at 6:33 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Dave,Please find updated patch.
I turned off the status option, but polling is still happening. This should definitely stop! :-)
Can you also reverse the enable/disable switch and the interval setting on the preferences page? I think Enable/Disable should be at the top, and be followed by the interval.
Thanks.
On Mon, Jan 8, 2018 at 7:21 PM, Dave Page <dpage@pgadmin.org> wrote:On Mon, Jan 8, 2018 at 1:24 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA updated patch.On Mon, Jan 8, 2018 at 5:11 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Fri, Jan 5, 2018 at 8:49 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA updated patch,On Wed, Jan 3, 2018 at 10:44 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Thu, Dec 28, 2017 at 9:38 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA updated patch based on new design suggested by Chethana.The patch also includes some misc fixes related to object validation.RM#2475This seems much nicer, but I still think there are some tweaks to make:1) If I open a query tool, and then stop the application server, the icon is updated to show the broken connection. However, unless I execute a query in the query tool before the server is shut down, the connection status won't recover when the server is restarted. If I do run a query first (SELECT 1; will do), then the connection status will recover.I have loggedhttps://redmine.postgresql.org/issues/2983 2) I think the "connected" icon should be in $primary-blue (#2c76b4). The green is ugly and not overly easy to read. It's also distracting as it catches the eye, which the default, non-error state should not do.FixedMuch better.3) I'm not overly happy with the the status text popover. After some thought, I think it's because there are no visual clues that you should click on the icon to see it - and Karen seems to be of a similar opinion. Can we put a small marker there, perhaps a triangle on the bottom-right, like you get on a spreadsheet cell if you add a comment/note? We should also have a hotkey and I guess a tooltip, e.g. "Connection status Ctrl+Alt+S" or similar.Fixed, added accesskey 'T' for TX status tooltip shortcut as 'S' is already taken for Save file optionHmm - having seen it, I don't think the marker helps us.Can you remove it, and fix the tooltip (which doesn't seem to work)? If we always have the tooltip say "Connection status Ctrl+Alt+T" (or whatever is appropriate for the platform/browser), then that should give the user enough hint to click.Fixed.I have removed the marker & added tooltip instead but it is not possible to add specific shortcut keys in tooltip because accesskey may vary depending on OS & browser.That's better - though I think the tool tip is better as something like:Connection status (click for details) (<accesskey>+T)I'm still not overly happy with all the polling that's going on though. It's a lot of requests, especially with multiple QTs open. I think we need to be able to disable the feature entirely through a switch in the Preferences. In that case, no icon would be shown, and polling would be disabled - i.e. everything would be as it is now.What do you think?FixedMade it configurable & set default polling time to 10sec.Please review.--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Hi Dave,
PFA updated patch.
On Tue, Jan 9, 2018 at 7:57 PM, Dave Page <dpage@pgadmin.org> wrote:
HiOn Tue, Jan 9, 2018 at 6:33 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,Please find updated patch.I turned off the status option, but polling is still happening. This should definitely stop! :-)
Fixed typo in variable.
Can you also reverse the enable/disable switch and the interval setting on the preferences page? I think Enable/Disable should be at the top, and be followed by the interval.
Fixed.
But just a heads up we won't be able to put '?' after 'Connection status' eg: '
Connection status?'
Then string sorting again puts it after 'Connection status refresh rate' :)
Thanks.On Mon, Jan 8, 2018 at 7:21 PM, Dave Page <dpage@pgadmin.org> wrote:On Mon, Jan 8, 2018 at 1:24 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA updated patch.On Mon, Jan 8, 2018 at 5:11 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Fri, Jan 5, 2018 at 8:49 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA updated patch,On Wed, Jan 3, 2018 at 10:44 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Thu, Dec 28, 2017 at 9:38 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA updated patch based on new design suggested by Chethana.The patch also includes some misc fixes related to object validation.RM#2475This seems much nicer, but I still think there are some tweaks to make:1) If I open a query tool, and then stop the application server, the icon is updated to show the broken connection. However, unless I execute a query in the query tool before the server is shut down, the connection status won't recover when the server is restarted. If I do run a query first (SELECT 1; will do), then the connection status will recover.I have loggedhttps://redmine.postgresql.org/issues/2983 2) I think the "connected" icon should be in $primary-blue (#2c76b4). The green is ugly and not overly easy to read. It's also distracting as it catches the eye, which the default, non-error state should not do.FixedMuch better.3) I'm not overly happy with the the status text popover. After some thought, I think it's because there are no visual clues that you should click on the icon to see it - and Karen seems to be of a similar opinion. Can we put a small marker there, perhaps a triangle on the bottom-right, like you get on a spreadsheet cell if you add a comment/note? We should also have a hotkey and I guess a tooltip, e.g. "Connection status Ctrl+Alt+S" or similar.Fixed, added accesskey 'T' for TX status tooltip shortcut as 'S' is already taken for Save file optionHmm - having seen it, I don't think the marker helps us.Can you remove it, and fix the tooltip (which doesn't seem to work)? If we always have the tooltip say "Connection status Ctrl+Alt+T" (or whatever is appropriate for the platform/browser), then that should give the user enough hint to click.Fixed.I have removed the marker & added tooltip instead but it is not possible to add specific shortcut keys in tooltip because accesskey may vary depending on OS & browser.That's better - though I think the tool tip is better as something like:Connection status (click for details) (<accesskey>+T)I'm still not overly happy with all the polling that's going on though. It's a lot of requests, especially with multiple QTs open. I think we need to be able to disable the feature entirely through a switch in the Preferences. In that case, no icon would be shown, and polling would be disabled - i.e. everything would be as it is now.What do you think?FixedMade it configurable & set default polling time to 10sec.Please review.--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Вложения
Murtuza, I think we should only poll if sqleditor/datagrid is visible.
We've wcDocker.EVENT.VISIBILITY_CHANGED event when panel visibility changes.
--
Harshal Dhumal
Sr. Software Engineer
On Wed, Jan 10, 2018 at 1:55 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Dave,PFA updated patch.On Tue, Jan 9, 2018 at 7:57 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Tue, Jan 9, 2018 at 6:33 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,Please find updated patch.I turned off the status option, but polling is still happening. This should definitely stop! :-)Fixed typo in variable.Can you also reverse the enable/disable switch and the interval setting on the preferences page? I think Enable/Disable should be at the top, and be followed by the interval.Fixed.But just a heads up we won't be able to put '?' after 'Connection status' eg: 'Connection status?'Then string sorting again puts it after 'Connection status refresh rate' :)Thanks.On Mon, Jan 8, 2018 at 7:21 PM, Dave Page <dpage@pgadmin.org> wrote:On Mon, Jan 8, 2018 at 1:24 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA updated patch.On Mon, Jan 8, 2018 at 5:11 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Fri, Jan 5, 2018 at 8:49 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA updated patch,On Wed, Jan 3, 2018 at 10:44 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Thu, Dec 28, 2017 at 9:38 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA updated patch based on new design suggested by Chethana.The patch also includes some misc fixes related to object validation.RM#2475This seems much nicer, but I still think there are some tweaks to make:1) If I open a query tool, and then stop the application server, the icon is updated to show the broken connection. However, unless I execute a query in the query tool before the server is shut down, the connection status won't recover when the server is restarted. If I do run a query first (SELECT 1; will do), then the connection status will recover.I have loggedhttps://redmine.postgresql.org/issues/2983 2) I think the "connected" icon should be in $primary-blue (#2c76b4). The green is ugly and not overly easy to read. It's also distracting as it catches the eye, which the default, non-error state should not do.FixedMuch better.3) I'm not overly happy with the the status text popover. After some thought, I think it's because there are no visual clues that you should click on the icon to see it - and Karen seems to be of a similar opinion. Can we put a small marker there, perhaps a triangle on the bottom-right, like you get on a spreadsheet cell if you add a comment/note? We should also have a hotkey and I guess a tooltip, e.g. "Connection status Ctrl+Alt+S" or similar.Fixed, added accesskey 'T' for TX status tooltip shortcut as 'S' is already taken for Save file optionHmm - having seen it, I don't think the marker helps us.Can you remove it, and fix the tooltip (which doesn't seem to work)? If we always have the tooltip say "Connection status Ctrl+Alt+T" (or whatever is appropriate for the platform/browser), then that should give the user enough hint to click.Fixed.I have removed the marker & added tooltip instead but it is not possible to add specific shortcut keys in tooltip because accesskey may vary depending on OS & browser.That's better - though I think the tool tip is better as something like:Connection status (click for details) (<accesskey>+T)I'm still not overly happy with all the polling that's going on though. It's a lot of requests, especially with multiple QTs open. I think we need to be able to disable the feature entirely through a switch in the Preferences. In that case, no icon would be shown, and polling would be disabled - i.e. everything would be as it is now.What do you think?FixedMade it configurable & set default polling time to 10sec.Please review.--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
User can open Query tool in new browser window where we'll not have wcDocker panel.
On Thu, Jan 11, 2018 at 12:00 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Murtuza, I think we should only poll if sqleditor/datagrid is visible.We've wcDocker.EVENT.VISIBILITY_CHANGED event when panel visibility changes. --Harshal DhumalSr. Software EngineerOn Wed, Jan 10, 2018 at 1:55 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA updated patch.On Tue, Jan 9, 2018 at 7:57 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Tue, Jan 9, 2018 at 6:33 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,Please find updated patch.I turned off the status option, but polling is still happening. This should definitely stop! :-)Fixed typo in variable.Can you also reverse the enable/disable switch and the interval setting on the preferences page? I think Enable/Disable should be at the top, and be followed by the interval.Fixed.But just a heads up we won't be able to put '?' after 'Connection status' eg: 'Connection status?'Then string sorting again puts it after 'Connection status refresh rate' :)Thanks.On Mon, Jan 8, 2018 at 7:21 PM, Dave Page <dpage@pgadmin.org> wrote:On Mon, Jan 8, 2018 at 1:24 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA updated patch.On Mon, Jan 8, 2018 at 5:11 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Fri, Jan 5, 2018 at 8:49 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA updated patch,On Wed, Jan 3, 2018 at 10:44 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Thu, Dec 28, 2017 at 9:38 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA updated patch based on new design suggested by Chethana.The patch also includes some misc fixes related to object validation.RM#2475This seems much nicer, but I still think there are some tweaks to make:1) If I open a query tool, and then stop the application server, the icon is updated to show the broken connection. However, unless I execute a query in the query tool before the server is shut down, the connection status won't recover when the server is restarted. If I do run a query first (SELECT 1; will do), then the connection status will recover.I have loggedhttps://redmine.postgresql.org/issues/2983 2) I think the "connected" icon should be in $primary-blue (#2c76b4). The green is ugly and not overly easy to read. It's also distracting as it catches the eye, which the default, non-error state should not do.FixedMuch better.3) I'm not overly happy with the the status text popover. After some thought, I think it's because there are no visual clues that you should click on the icon to see it - and Karen seems to be of a similar opinion. Can we put a small marker there, perhaps a triangle on the bottom-right, like you get on a spreadsheet cell if you add a comment/note? We should also have a hotkey and I guess a tooltip, e.g. "Connection status Ctrl+Alt+S" or similar.Fixed, added accesskey 'T' for TX status tooltip shortcut as 'S' is already taken for Save file optionHmm - having seen it, I don't think the marker helps us.Can you remove it, and fix the tooltip (which doesn't seem to work)? If we always have the tooltip say "Connection status Ctrl+Alt+T" (or whatever is appropriate for the platform/browser), then that should give the user enough hint to click.Fixed.I have removed the marker & added tooltip instead but it is not possible to add specific shortcut keys in tooltip because accesskey may vary depending on OS & browser.That's better - though I think the tool tip is better as something like:Connection status (click for details) (<accesskey>+T)I'm still not overly happy with all the polling that's going on though. It's a lot of requests, especially with multiple QTs open. I think we need to be able to disable the feature entirely through a switch in the Preferences. In that case, no icon would be shown, and polling would be disabled - i.e. everything would be as it is now.What do you think?FixedMade it configurable & set default polling time to 10sec.Please review.--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Thu, Jan 11, 2018 at 12:06 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
User can open Query tool in new browser window where we'll not have wcDocker panel.
In that case we can use window onfocus and onblur events.
In sqleditor there are cases where we've written conditional code based on whether sqleditor is opened in new window or not.
On Thu, Jan 11, 2018 at 12:00 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Murtuza, I think we should only poll if sqleditor/datagrid is visible.We've wcDocker.EVENT.VISIBILITY_CHANGED event when panel visibility changes. --Harshal DhumalSr. Software EngineerOn Wed, Jan 10, 2018 at 1:55 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA updated patch.On Tue, Jan 9, 2018 at 7:57 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Tue, Jan 9, 2018 at 6:33 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,Please find updated patch.I turned off the status option, but polling is still happening. This should definitely stop! :-)Fixed typo in variable.Can you also reverse the enable/disable switch and the interval setting on the preferences page? I think Enable/Disable should be at the top, and be followed by the interval.Fixed.But just a heads up we won't be able to put '?' after 'Connection status' eg: 'Connection status?'Then string sorting again puts it after 'Connection status refresh rate' :)Thanks.On Mon, Jan 8, 2018 at 7:21 PM, Dave Page <dpage@pgadmin.org> wrote:On Mon, Jan 8, 2018 at 1:24 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA updated patch.On Mon, Jan 8, 2018 at 5:11 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Fri, Jan 5, 2018 at 8:49 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA updated patch,On Wed, Jan 3, 2018 at 10:44 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Thu, Dec 28, 2017 at 9:38 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA updated patch based on new design suggested by Chethana.The patch also includes some misc fixes related to object validation.RM#2475This seems much nicer, but I still think there are some tweaks to make:1) If I open a query tool, and then stop the application server, the icon is updated to show the broken connection. However, unless I execute a query in the query tool before the server is shut down, the connection status won't recover when the server is restarted. If I do run a query first (SELECT 1; will do), then the connection status will recover.I have loggedhttps://redmine.postgresql.org/issues/2983 2) I think the "connected" icon should be in $primary-blue (#2c76b4). The green is ugly and not overly easy to read. It's also distracting as it catches the eye, which the default, non-error state should not do.FixedMuch better.3) I'm not overly happy with the the status text popover. After some thought, I think it's because there are no visual clues that you should click on the icon to see it - and Karen seems to be of a similar opinion. Can we put a small marker there, perhaps a triangle on the bottom-right, like you get on a spreadsheet cell if you add a comment/note? We should also have a hotkey and I guess a tooltip, e.g. "Connection status Ctrl+Alt+S" or similar.Fixed, added accesskey 'T' for TX status tooltip shortcut as 'S' is already taken for Save file optionHmm - having seen it, I don't think the marker helps us.Can you remove it, and fix the tooltip (which doesn't seem to work)? If we always have the tooltip say "Connection status Ctrl+Alt+T" (or whatever is appropriate for the platform/browser), then that should give the user enough hint to click.Fixed.I have removed the marker & added tooltip instead but it is not possible to add specific shortcut keys in tooltip because accesskey may vary depending on OS & browser.That's better - though I think the tool tip is better as something like:Connection status (click for details) (<accesskey>+T)I'm still not overly happy with all the polling that's going on though. It's a lot of requests, especially with multiple QTs open. I think we need to be able to disable the feature entirely through a switch in the Preferences. In that case, no icon would be shown, and polling would be disabled - i.e. everything would be as it is now.What do you think?FixedMade it configurable & set default polling time to 10sec.Please review.--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Thu, Jan 11, 2018 at 7:00 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
On Thu, Jan 11, 2018 at 12:06 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: User can open Query tool in new browser window where we'll not have wcDocker panel.In that case we can use window onfocus and onblur events.In sqleditor there are cases where we've written conditional code based on whether sqleditor is opened in new window or not.
This is a great suggestion (the idea in general). We need to make this happen - it'll go a long way to minimising our concerns about the amount of polling.
On Thu, Jan 11, 2018 at 12:00 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Murtuza, I think we should only poll if sqleditor/datagrid is visible.We've wcDocker.EVENT.VISIBILITY_CHANGED event when panel visibility changes. --Harshal DhumalSr. Software EngineerOn Wed, Jan 10, 2018 at 1:55 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA updated patch.On Tue, Jan 9, 2018 at 7:57 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Tue, Jan 9, 2018 at 6:33 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,Please find updated patch.I turned off the status option, but polling is still happening. This should definitely stop! :-)Fixed typo in variable.Can you also reverse the enable/disable switch and the interval setting on the preferences page? I think Enable/Disable should be at the top, and be followed by the interval.Fixed.But just a heads up we won't be able to put '?' after 'Connection status' eg: 'Connection status?'Then string sorting again puts it after 'Connection status refresh rate' :)Thanks.On Mon, Jan 8, 2018 at 7:21 PM, Dave Page <dpage@pgadmin.org> wrote:On Mon, Jan 8, 2018 at 1:24 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA updated patch.On Mon, Jan 8, 2018 at 5:11 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Fri, Jan 5, 2018 at 8:49 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA updated patch,On Wed, Jan 3, 2018 at 10:44 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Thu, Dec 28, 2017 at 9:38 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA updated patch based on new design suggested by Chethana.The patch also includes some misc fixes related to object validation.RM#2475This seems much nicer, but I still think there are some tweaks to make:1) If I open a query tool, and then stop the application server, the icon is updated to show the broken connection. However, unless I execute a query in the query tool before the server is shut down, the connection status won't recover when the server is restarted. If I do run a query first (SELECT 1; will do), then the connection status will recover.I have loggedhttps://redmine.postgresql.org/issues/2983 2) I think the "connected" icon should be in $primary-blue (#2c76b4). The green is ugly and not overly easy to read. It's also distracting as it catches the eye, which the default, non-error state should not do.FixedMuch better.3) I'm not overly happy with the the status text popover. After some thought, I think it's because there are no visual clues that you should click on the icon to see it - and Karen seems to be of a similar opinion. Can we put a small marker there, perhaps a triangle on the bottom-right, like you get on a spreadsheet cell if you add a comment/note? We should also have a hotkey and I guess a tooltip, e.g. "Connection status Ctrl+Alt+S" or similar.Fixed, added accesskey 'T' for TX status tooltip shortcut as 'S' is already taken for Save file optionHmm - having seen it, I don't think the marker helps us.Can you remove it, and fix the tooltip (which doesn't seem to work)? If we always have the tooltip say "Connection status Ctrl+Alt+T" (or whatever is appropriate for the platform/browser), then that should give the user enough hint to click.Fixed.I have removed the marker & added tooltip instead but it is not possible to add specific shortcut keys in tooltip because accesskey may vary depending on OS & browser.That's better - though I think the tool tip is better as something like:Connection status (click for details) (<accesskey>+T)I'm still not overly happy with all the polling that's going on though. It's a lot of requests, especially with multiple QTs open. I think we need to be able to disable the feature entirely through a switch in the Preferences. In that case, no icon would be shown, and polling would be disabled - i.e. everything would be as it is now.What do you think?FixedMade it configurable & set default polling time to 10sec.Please review.--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Hi Dave,
PFA updated patch with additional checks to prevent unnecessary polling added as suggested.
Please review.
--![](https://drive.google.com/a/enterprisedb.com/uc?id=0B6jGeB3BfKRMV0t4MEp0YnZCTTA&export=download)
Regards,
On Thu, Jan 11, 2018 at 2:33 PM, Dave Page <dpage@pgadmin.org> wrote:
On Thu, Jan 11, 2018 at 7:00 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: On Thu, Jan 11, 2018 at 12:06 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: User can open Query tool in new browser window where we'll not have wcDocker panel.In that case we can use window onfocus and onblur events.In sqleditor there are cases where we've written conditional code based on whether sqleditor is opened in new window or not.This is a great suggestion (the idea in general). We need to make this happen - it'll go a long way to minimising our concerns about the amount of polling.On Thu, Jan 11, 2018 at 12:00 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Murtuza, I think we should only poll if sqleditor/datagrid is visible.We've wcDocker.EVENT.VISIBILITY_CHANGED event when panel visibility changes. --Harshal DhumalSr. Software EngineerOn Wed, Jan 10, 2018 at 1:55 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA updated patch.On Tue, Jan 9, 2018 at 7:57 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Tue, Jan 9, 2018 at 6:33 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,Please find updated patch.I turned off the status option, but polling is still happening. This should definitely stop! :-)Fixed typo in variable.Can you also reverse the enable/disable switch and the interval setting on the preferences page? I think Enable/Disable should be at the top, and be followed by the interval.Fixed.But just a heads up we won't be able to put '?' after 'Connection status' eg: 'Connection status?'Then string sorting again puts it after 'Connection status refresh rate' :)Thanks.On Mon, Jan 8, 2018 at 7:21 PM, Dave Page <dpage@pgadmin.org> wrote:On Mon, Jan 8, 2018 at 1:24 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA updated patch.On Mon, Jan 8, 2018 at 5:11 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Fri, Jan 5, 2018 at 8:49 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA updated patch,On Wed, Jan 3, 2018 at 10:44 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Thu, Dec 28, 2017 at 9:38 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA updated patch based on new design suggested by Chethana.The patch also includes some misc fixes related to object validation.RM#2475This seems much nicer, but I still think there are some tweaks to make:1) If I open a query tool, and then stop the application server, the icon is updated to show the broken connection. However, unless I execute a query in the query tool before the server is shut down, the connection status won't recover when the server is restarted. If I do run a query first (SELECT 1; will do), then the connection status will recover.I have loggedhttps://redmine.postgresql.org/issues/2983 2) I think the "connected" icon should be in $primary-blue (#2c76b4). The green is ugly and not overly easy to read. It's also distracting as it catches the eye, which the default, non-error state should not do.FixedMuch better.3) I'm not overly happy with the the status text popover. After some thought, I think it's because there are no visual clues that you should click on the icon to see it - and Karen seems to be of a similar opinion. Can we put a small marker there, perhaps a triangle on the bottom-right, like you get on a spreadsheet cell if you add a comment/note? We should also have a hotkey and I guess a tooltip, e.g. "Connection status Ctrl+Alt+S" or similar.Fixed, added accesskey 'T' for TX status tooltip shortcut as 'S' is already taken for Save file optionHmm - having seen it, I don't think the marker helps us.Can you remove it, and fix the tooltip (which doesn't seem to work)? If we always have the tooltip say "Connection status Ctrl+Alt+T" (or whatever is appropriate for the platform/browser), then that should give the user enough hint to click.Fixed.I have removed the marker & added tooltip instead but it is not possible to add specific shortcut keys in tooltip because accesskey may vary depending on OS & browser.That's better - though I think the tool tip is better as something like:Connection status (click for details) (<accesskey>+T)I'm still not overly happy with all the polling that's going on though. It's a lot of requests, especially with multiple QTs open. I think we need to be able to disable the feature entirely through a switch in the Preferences. In that case, no icon would be shown, and polling would be disabled - i.e. everything would be as it is now.What do you think?FixedMade it configurable & set default polling time to 10sec.Please review.--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Вложения
Thanks - patch applied!
Can you please update the docs for the new config options, and any screenshot updates that are required?
On Fri, Jan 12, 2018 at 2:10 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Dave,PFA updated patch with additional checks to prevent unnecessary polling added as suggested.Please review.--Regards,On Thu, Jan 11, 2018 at 2:33 PM, Dave Page <dpage@pgadmin.org> wrote:On Thu, Jan 11, 2018 at 7:00 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: On Thu, Jan 11, 2018 at 12:06 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: User can open Query tool in new browser window where we'll not have wcDocker panel.In that case we can use window onfocus and onblur events.In sqleditor there are cases where we've written conditional code based on whether sqleditor is opened in new window or not.This is a great suggestion (the idea in general). We need to make this happen - it'll go a long way to minimising our concerns about the amount of polling.On Thu, Jan 11, 2018 at 12:00 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Murtuza, I think we should only poll if sqleditor/datagrid is visible.We've wcDocker.EVENT.VISIBILITY_CHANGED event when panel visibility changes. --Harshal DhumalSr. Software EngineerOn Wed, Jan 10, 2018 at 1:55 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA updated patch.On Tue, Jan 9, 2018 at 7:57 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Tue, Jan 9, 2018 at 6:33 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,Please find updated patch.I turned off the status option, but polling is still happening. This should definitely stop! :-)Fixed typo in variable.Can you also reverse the enable/disable switch and the interval setting on the preferences page? I think Enable/Disable should be at the top, and be followed by the interval.Fixed.But just a heads up we won't be able to put '?' after 'Connection status' eg: 'Connection status?'Then string sorting again puts it after 'Connection status refresh rate' :)Thanks.On Mon, Jan 8, 2018 at 7:21 PM, Dave Page <dpage@pgadmin.org> wrote:On Mon, Jan 8, 2018 at 1:24 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA updated patch.On Mon, Jan 8, 2018 at 5:11 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Fri, Jan 5, 2018 at 8:49 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA updated patch,On Wed, Jan 3, 2018 at 10:44 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Thu, Dec 28, 2017 at 9:38 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA updated patch based on new design suggested by Chethana.The patch also includes some misc fixes related to object validation.RM#2475This seems much nicer, but I still think there are some tweaks to make:1) If I open a query tool, and then stop the application server, the icon is updated to show the broken connection. However, unless I execute a query in the query tool before the server is shut down, the connection status won't recover when the server is restarted. If I do run a query first (SELECT 1; will do), then the connection status will recover.I have loggedhttps://redmine.postgresql.org/issues/2983 2) I think the "connected" icon should be in $primary-blue (#2c76b4). The green is ugly and not overly easy to read. It's also distracting as it catches the eye, which the default, non-error state should not do.FixedMuch better.3) I'm not overly happy with the the status text popover. After some thought, I think it's because there are no visual clues that you should click on the icon to see it - and Karen seems to be of a similar opinion. Can we put a small marker there, perhaps a triangle on the bottom-right, like you get on a spreadsheet cell if you add a comment/note? We should also have a hotkey and I guess a tooltip, e.g. "Connection status Ctrl+Alt+S" or similar.Fixed, added accesskey 'T' for TX status tooltip shortcut as 'S' is already taken for Save file optionHmm - having seen it, I don't think the marker helps us.Can you remove it, and fix the tooltip (which doesn't seem to work)? If we always have the tooltip say "Connection status Ctrl+Alt+T" (or whatever is appropriate for the platform/browser), then that should give the user enough hint to click.Fixed.I have removed the marker & added tooltip instead but it is not possible to add specific shortcut keys in tooltip because accesskey may vary depending on OS & browser.That's better - though I think the tool tip is better as something like:Connection status (click for details) (<accesskey>+T)I'm still not overly happy with all the polling that's going on though. It's a lot of requests, especially with multiple QTs open. I think we need to be able to disable the feature entirely through a switch in the Preferences. In that case, no icon would be shown, and polling would be disabled - i.e. everything would be as it is now.What do you think?FixedMade it configurable & set default polling time to 10sec.Please review.--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Sure, I'll do that.
On Fri, Jan 12, 2018 at 8:05 PM, Dave Page <dpage@pgadmin.org> wrote:
Thanks - patch applied!Can you please update the docs for the new config options, and any screenshot updates that are required?On Fri, Jan 12, 2018 at 2:10 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA updated patch with additional checks to prevent unnecessary polling added as suggested.Please review.--Regards,On Thu, Jan 11, 2018 at 2:33 PM, Dave Page <dpage@pgadmin.org> wrote:On Thu, Jan 11, 2018 at 7:00 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: On Thu, Jan 11, 2018 at 12:06 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: User can open Query tool in new browser window where we'll not have wcDocker panel.In that case we can use window onfocus and onblur events.In sqleditor there are cases where we've written conditional code based on whether sqleditor is opened in new window or not.This is a great suggestion (the idea in general). We need to make this happen - it'll go a long way to minimising our concerns about the amount of polling.On Thu, Jan 11, 2018 at 12:00 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Murtuza, I think we should only poll if sqleditor/datagrid is visible.We've wcDocker.EVENT.VISIBILITY_CHANGED event when panel visibility changes. --Harshal DhumalSr. Software EngineerOn Wed, Jan 10, 2018 at 1:55 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA updated patch.On Tue, Jan 9, 2018 at 7:57 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Tue, Jan 9, 2018 at 6:33 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,Please find updated patch.I turned off the status option, but polling is still happening. This should definitely stop! :-)Fixed typo in variable.Can you also reverse the enable/disable switch and the interval setting on the preferences page? I think Enable/Disable should be at the top, and be followed by the interval.Fixed.But just a heads up we won't be able to put '?' after 'Connection status' eg: 'Connection status?'Then string sorting again puts it after 'Connection status refresh rate' :)Thanks.On Mon, Jan 8, 2018 at 7:21 PM, Dave Page <dpage@pgadmin.org> wrote:On Mon, Jan 8, 2018 at 1:24 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA updated patch.On Mon, Jan 8, 2018 at 5:11 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Fri, Jan 5, 2018 at 8:49 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA updated patch,On Wed, Jan 3, 2018 at 10:44 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Thu, Dec 28, 2017 at 9:38 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA updated patch based on new design suggested by Chethana.The patch also includes some misc fixes related to object validation.RM#2475This seems much nicer, but I still think there are some tweaks to make:1) If I open a query tool, and then stop the application server, the icon is updated to show the broken connection. However, unless I execute a query in the query tool before the server is shut down, the connection status won't recover when the server is restarted. If I do run a query first (SELECT 1; will do), then the connection status will recover.I have loggedhttps://redmine.postgresql.org/issues/2983 2) I think the "connected" icon should be in $primary-blue (#2c76b4). The green is ugly and not overly easy to read. It's also distracting as it catches the eye, which the default, non-error state should not do.FixedMuch better.3) I'm not overly happy with the the status text popover. After some thought, I think it's because there are no visual clues that you should click on the icon to see it - and Karen seems to be of a similar opinion. Can we put a small marker there, perhaps a triangle on the bottom-right, like you get on a spreadsheet cell if you add a comment/note? We should also have a hotkey and I guess a tooltip, e.g. "Connection status Ctrl+Alt+S" or similar.Fixed, added accesskey 'T' for TX status tooltip shortcut as 'S' is already taken for Save file optionHmm - having seen it, I don't think the marker helps us.Can you remove it, and fix the tooltip (which doesn't seem to work)? If we always have the tooltip say "Connection status Ctrl+Alt+T" (or whatever is appropriate for the platform/browser), then that should give the user enough hint to click.Fixed.I have removed the marker & added tooltip instead but it is not possible to add specific shortcut keys in tooltip because accesskey may vary depending on OS & browser.That's better - though I think the tool tip is better as something like:Connection status (click for details) (<accesskey>+T)I'm still not overly happy with all the polling that's going on though. It's a lot of requests, especially with multiple QTs open. I think we need to be able to disable the feature entirely through a switch in the Preferences. In that case, no icon would be shown, and polling would be disabled - i.e. everything would be as it is now.What do you think?FixedMade it configurable & set default polling time to 10sec.Please review.--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Hi Dave,
PFA patch to update docs & screenshots for the new connection status feature.
--![](https://drive.google.com/a/enterprisedb.com/uc?id=0B6jGeB3BfKRMV0t4MEp0YnZCTTA&export=download)
Regards,
On Fri, Jan 12, 2018 at 8:08 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Sure, I'll do that.On Fri, Jan 12, 2018 at 8:05 PM, Dave Page <dpage@pgadmin.org> wrote:Thanks - patch applied!Can you please update the docs for the new config options, and any screenshot updates that are required?On Fri, Jan 12, 2018 at 2:10 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA updated patch with additional checks to prevent unnecessary polling added as suggested.Please review.--Regards,On Thu, Jan 11, 2018 at 2:33 PM, Dave Page <dpage@pgadmin.org> wrote:On Thu, Jan 11, 2018 at 7:00 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: On Thu, Jan 11, 2018 at 12:06 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: User can open Query tool in new browser window where we'll not have wcDocker panel.In that case we can use window onfocus and onblur events.In sqleditor there are cases where we've written conditional code based on whether sqleditor is opened in new window or not.This is a great suggestion (the idea in general). We need to make this happen - it'll go a long way to minimising our concerns about the amount of polling.On Thu, Jan 11, 2018 at 12:00 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Murtuza, I think we should only poll if sqleditor/datagrid is visible.We've wcDocker.EVENT.VISIBILITY_CHANGED event when panel visibility changes. --Harshal DhumalSr. Software EngineerOn Wed, Jan 10, 2018 at 1:55 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA updated patch.On Tue, Jan 9, 2018 at 7:57 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Tue, Jan 9, 2018 at 6:33 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,Please find updated patch.I turned off the status option, but polling is still happening. This should definitely stop! :-)Fixed typo in variable.Can you also reverse the enable/disable switch and the interval setting on the preferences page? I think Enable/Disable should be at the top, and be followed by the interval.Fixed.But just a heads up we won't be able to put '?' after 'Connection status' eg: 'Connection status?'Then string sorting again puts it after 'Connection status refresh rate' :)Thanks.On Mon, Jan 8, 2018 at 7:21 PM, Dave Page <dpage@pgadmin.org> wrote:On Mon, Jan 8, 2018 at 1:24 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA updated patch.On Mon, Jan 8, 2018 at 5:11 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Fri, Jan 5, 2018 at 8:49 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA updated patch,On Wed, Jan 3, 2018 at 10:44 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Thu, Dec 28, 2017 at 9:38 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA updated patch based on new design suggested by Chethana.The patch also includes some misc fixes related to object validation.RM#2475This seems much nicer, but I still think there are some tweaks to make:1) If I open a query tool, and then stop the application server, the icon is updated to show the broken connection. However, unless I execute a query in the query tool before the server is shut down, the connection status won't recover when the server is restarted. If I do run a query first (SELECT 1; will do), then the connection status will recover.I have loggedhttps://redmine.postgresql.org/issues/2983 2) I think the "connected" icon should be in $primary-blue (#2c76b4). The green is ugly and not overly easy to read. It's also distracting as it catches the eye, which the default, non-error state should not do.FixedMuch better.3) I'm not overly happy with the the status text popover. After some thought, I think it's because there are no visual clues that you should click on the icon to see it - and Karen seems to be of a similar opinion. Can we put a small marker there, perhaps a triangle on the bottom-right, like you get on a spreadsheet cell if you add a comment/note? We should also have a hotkey and I guess a tooltip, e.g. "Connection status Ctrl+Alt+S" or similar.Fixed, added accesskey 'T' for TX status tooltip shortcut as 'S' is already taken for Save file optionHmm - having seen it, I don't think the marker helps us.Can you remove it, and fix the tooltip (which doesn't seem to work)? If we always have the tooltip say "Connection status Ctrl+Alt+T" (or whatever is appropriate for the platform/browser), then that should give the user enough hint to click.Fixed.I have removed the marker & added tooltip instead but it is not possible to add specific shortcut keys in tooltip because accesskey may vary depending on OS & browser.That's better - though I think the tool tip is better as something like:Connection status (click for details) (<accesskey>+T)I'm still not overly happy with all the polling that's going on though. It's a lot of requests, especially with multiple QTs open. I think we need to be able to disable the feature entirely through a switch in the Preferences. In that case, no icon would be shown, and polling would be disabled - i.e. everything would be as it is now.What do you think?FixedMade it configurable & set default polling time to 10sec.Please review.--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Вложения
Hi
Unfortunately there's variation in the spec of the images. Can you please check with Chethana on the correct sizing and resolution etc? For example, query_sql_editor.png was previously 755x209, but now is 2042x402.
Thanks!
On Mon, Jan 15, 2018 at 7:21 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Dave,PFA patch to update docs & screenshots for the new connection status feature.--Regards,On Fri, Jan 12, 2018 at 8:08 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Sure, I'll do that.On Fri, Jan 12, 2018 at 8:05 PM, Dave Page <dpage@pgadmin.org> wrote:Thanks - patch applied!Can you please update the docs for the new config options, and any screenshot updates that are required?On Fri, Jan 12, 2018 at 2:10 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA updated patch with additional checks to prevent unnecessary polling added as suggested.Please review.--Regards,On Thu, Jan 11, 2018 at 2:33 PM, Dave Page <dpage@pgadmin.org> wrote:On Thu, Jan 11, 2018 at 7:00 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: On Thu, Jan 11, 2018 at 12:06 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: User can open Query tool in new browser window where we'll not have wcDocker panel.In that case we can use window onfocus and onblur events.In sqleditor there are cases where we've written conditional code based on whether sqleditor is opened in new window or not.This is a great suggestion (the idea in general). We need to make this happen - it'll go a long way to minimising our concerns about the amount of polling.On Thu, Jan 11, 2018 at 12:00 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Murtuza, I think we should only poll if sqleditor/datagrid is visible.We've wcDocker.EVENT.VISIBILITY_CHANGED event when panel visibility changes. --Harshal DhumalSr. Software EngineerOn Wed, Jan 10, 2018 at 1:55 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA updated patch.On Tue, Jan 9, 2018 at 7:57 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Tue, Jan 9, 2018 at 6:33 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,Please find updated patch.I turned off the status option, but polling is still happening. This should definitely stop! :-)Fixed typo in variable.Can you also reverse the enable/disable switch and the interval setting on the preferences page? I think Enable/Disable should be at the top, and be followed by the interval.Fixed.But just a heads up we won't be able to put '?' after 'Connection status' eg: 'Connection status?'Then string sorting again puts it after 'Connection status refresh rate' :)Thanks.On Mon, Jan 8, 2018 at 7:21 PM, Dave Page <dpage@pgadmin.org> wrote:On Mon, Jan 8, 2018 at 1:24 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA updated patch.On Mon, Jan 8, 2018 at 5:11 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Fri, Jan 5, 2018 at 8:49 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA updated patch,On Wed, Jan 3, 2018 at 10:44 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Thu, Dec 28, 2017 at 9:38 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA updated patch based on new design suggested by Chethana.The patch also includes some misc fixes related to object validation.RM#2475This seems much nicer, but I still think there are some tweaks to make:1) If I open a query tool, and then stop the application server, the icon is updated to show the broken connection. However, unless I execute a query in the query tool before the server is shut down, the connection status won't recover when the server is restarted. If I do run a query first (SELECT 1; will do), then the connection status will recover.I have loggedhttps://redmine.postgresql.org/issues/2983 2) I think the "connected" icon should be in $primary-blue (#2c76b4). The green is ugly and not overly easy to read. It's also distracting as it catches the eye, which the default, non-error state should not do.FixedMuch better.3) I'm not overly happy with the the status text popover. After some thought, I think it's because there are no visual clues that you should click on the icon to see it - and Karen seems to be of a similar opinion. Can we put a small marker there, perhaps a triangle on the bottom-right, like you get on a spreadsheet cell if you add a comment/note? We should also have a hotkey and I guess a tooltip, e.g. "Connection status Ctrl+Alt+S" or similar.Fixed, added accesskey 'T' for TX status tooltip shortcut as 'S' is already taken for Save file optionHmm - having seen it, I don't think the marker helps us.Can you remove it, and fix the tooltip (which doesn't seem to work)? If we always have the tooltip say "Connection status Ctrl+Alt+T" (or whatever is appropriate for the platform/browser), then that should give the user enough hint to click.Fixed.I have removed the marker & added tooltip instead but it is not possible to add specific shortcut keys in tooltip because accesskey may vary depending on OS & browser.That's better - though I think the tool tip is better as something like:Connection status (click for details) (<accesskey>+T)I'm still not overly happy with all the polling that's going on though. It's a lot of requests, especially with multiple QTs open. I think we need to be able to disable the feature entirely through a switch in the Preferences. In that case, no icon would be shown, and polling would be disabled - i.e. everything would be as it is now.What do you think?FixedMade it configurable & set default polling time to 10sec.Please review.--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Hi Dave,
On Mon, Jan 15, 2018 at 2:57 PM, Dave Page <dpage@pgadmin.org> wrote:
HiUnfortunately there's variation in the spec of the images. Can you please check with Chethana on the correct sizing and resolution etc? For example, query_sql_editor.png was previously 755x209, but now is 2042x402.
Fixed.
PFA updated patch.
Thanks!On Mon, Jan 15, 2018 at 7:21 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA patch to update docs & screenshots for the new connection status feature.--Regards,On Fri, Jan 12, 2018 at 8:08 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Sure, I'll do that.On Fri, Jan 12, 2018 at 8:05 PM, Dave Page <dpage@pgadmin.org> wrote:Thanks - patch applied!Can you please update the docs for the new config options, and any screenshot updates that are required?On Fri, Jan 12, 2018 at 2:10 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA updated patch with additional checks to prevent unnecessary polling added as suggested.Please review.--Regards,On Thu, Jan 11, 2018 at 2:33 PM, Dave Page <dpage@pgadmin.org> wrote:On Thu, Jan 11, 2018 at 7:00 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: On Thu, Jan 11, 2018 at 12:06 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: User can open Query tool in new browser window where we'll not have wcDocker panel.In that case we can use window onfocus and onblur events.In sqleditor there are cases where we've written conditional code based on whether sqleditor is opened in new window or not.This is a great suggestion (the idea in general). We need to make this happen - it'll go a long way to minimising our concerns about the amount of polling.On Thu, Jan 11, 2018 at 12:00 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Murtuza, I think we should only poll if sqleditor/datagrid is visible.We've wcDocker.EVENT.VISIBILITY_CHANGED event when panel visibility changes. --Harshal DhumalSr. Software EngineerOn Wed, Jan 10, 2018 at 1:55 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA updated patch.On Tue, Jan 9, 2018 at 7:57 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Tue, Jan 9, 2018 at 6:33 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,Please find updated patch.I turned off the status option, but polling is still happening. This should definitely stop! :-)Fixed typo in variable.Can you also reverse the enable/disable switch and the interval setting on the preferences page? I think Enable/Disable should be at the top, and be followed by the interval.Fixed.But just a heads up we won't be able to put '?' after 'Connection status' eg: 'Connection status?'Then string sorting again puts it after 'Connection status refresh rate' :)Thanks.On Mon, Jan 8, 2018 at 7:21 PM, Dave Page <dpage@pgadmin.org> wrote:On Mon, Jan 8, 2018 at 1:24 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA updated patch.On Mon, Jan 8, 2018 at 5:11 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Fri, Jan 5, 2018 at 8:49 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA updated patch,On Wed, Jan 3, 2018 at 10:44 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Thu, Dec 28, 2017 at 9:38 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA updated patch based on new design suggested by Chethana.The patch also includes some misc fixes related to object validation.RM#2475This seems much nicer, but I still think there are some tweaks to make:1) If I open a query tool, and then stop the application server, the icon is updated to show the broken connection. However, unless I execute a query in the query tool before the server is shut down, the connection status won't recover when the server is restarted. If I do run a query first (SELECT 1; will do), then the connection status will recover.I have loggedhttps://redmine.postgresql.org/issues/2983 2) I think the "connected" icon should be in $primary-blue (#2c76b4). The green is ugly and not overly easy to read. It's also distracting as it catches the eye, which the default, non-error state should not do.FixedMuch better.3) I'm not overly happy with the the status text popover. After some thought, I think it's because there are no visual clues that you should click on the icon to see it - and Karen seems to be of a similar opinion. Can we put a small marker there, perhaps a triangle on the bottom-right, like you get on a spreadsheet cell if you add a comment/note? We should also have a hotkey and I guess a tooltip, e.g. "Connection status Ctrl+Alt+S" or similar.Fixed, added accesskey 'T' for TX status tooltip shortcut as 'S' is already taken for Save file optionHmm - having seen it, I don't think the marker helps us.Can you remove it, and fix the tooltip (which doesn't seem to work)? If we always have the tooltip say "Connection status Ctrl+Alt+T" (or whatever is appropriate for the platform/browser), then that should give the user enough hint to click.Fixed.I have removed the marker & added tooltip instead but it is not possible to add specific shortcut keys in tooltip because accesskey may vary depending on OS & browser.That's better - though I think the tool tip is better as something like:Connection status (click for details) (<accesskey>+T)I'm still not overly happy with all the polling that's going on though. It's a lot of requests, especially with multiple QTs open. I think we need to be able to disable the feature entirely through a switch in the Preferences. In that case, no icon would be shown, and polling would be disabled - i.e. everything would be as it is now.What do you think?FixedMade it configurable & set default polling time to 10sec.Please review.--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Вложения
Thanks, applied.
On Mon, Jan 15, 2018 at 11:35 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Dave,On Mon, Jan 15, 2018 at 2:57 PM, Dave Page <dpage@pgadmin.org> wrote:HiUnfortunately there's variation in the spec of the images. Can you please check with Chethana on the correct sizing and resolution etc? For example, query_sql_editor.png was previously 755x209, but now is 2042x402.Fixed.PFA updated patch.Thanks!On Mon, Jan 15, 2018 at 7:21 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA patch to update docs & screenshots for the new connection status feature.--Regards,On Fri, Jan 12, 2018 at 8:08 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Sure, I'll do that.On Fri, Jan 12, 2018 at 8:05 PM, Dave Page <dpage@pgadmin.org> wrote:Thanks - patch applied!Can you please update the docs for the new config options, and any screenshot updates that are required?On Fri, Jan 12, 2018 at 2:10 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA updated patch with additional checks to prevent unnecessary polling added as suggested.Please review.--Regards,On Thu, Jan 11, 2018 at 2:33 PM, Dave Page <dpage@pgadmin.org> wrote:On Thu, Jan 11, 2018 at 7:00 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: On Thu, Jan 11, 2018 at 12:06 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: User can open Query tool in new browser window where we'll not have wcDocker panel.In that case we can use window onfocus and onblur events.In sqleditor there are cases where we've written conditional code based on whether sqleditor is opened in new window or not.This is a great suggestion (the idea in general). We need to make this happen - it'll go a long way to minimising our concerns about the amount of polling.On Thu, Jan 11, 2018 at 12:00 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Murtuza, I think we should only poll if sqleditor/datagrid is visible.We've wcDocker.EVENT.VISIBILITY_CHANGED event when panel visibility changes. --Harshal DhumalSr. Software EngineerOn Wed, Jan 10, 2018 at 1:55 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA updated patch.On Tue, Jan 9, 2018 at 7:57 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Tue, Jan 9, 2018 at 6:33 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,Please find updated patch.I turned off the status option, but polling is still happening. This should definitely stop! :-)Fixed typo in variable.Can you also reverse the enable/disable switch and the interval setting on the preferences page? I think Enable/Disable should be at the top, and be followed by the interval.Fixed.But just a heads up we won't be able to put '?' after 'Connection status' eg: 'Connection status?'Then string sorting again puts it after 'Connection status refresh rate' :)Thanks.On Mon, Jan 8, 2018 at 7:21 PM, Dave Page <dpage@pgadmin.org> wrote:On Mon, Jan 8, 2018 at 1:24 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA updated patch.On Mon, Jan 8, 2018 at 5:11 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Fri, Jan 5, 2018 at 8:49 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,PFA updated patch,On Wed, Jan 3, 2018 at 10:44 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Thu, Dec 28, 2017 at 9:38 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA updated patch based on new design suggested by Chethana.The patch also includes some misc fixes related to object validation.RM#2475This seems much nicer, but I still think there are some tweaks to make:1) If I open a query tool, and then stop the application server, the icon is updated to show the broken connection. However, unless I execute a query in the query tool before the server is shut down, the connection status won't recover when the server is restarted. If I do run a query first (SELECT 1; will do), then the connection status will recover.I have loggedhttps://redmine.postgresql.org/issues/2983 2) I think the "connected" icon should be in $primary-blue (#2c76b4). The green is ugly and not overly easy to read. It's also distracting as it catches the eye, which the default, non-error state should not do.FixedMuch better.3) I'm not overly happy with the the status text popover. After some thought, I think it's because there are no visual clues that you should click on the icon to see it - and Karen seems to be of a similar opinion. Can we put a small marker there, perhaps a triangle on the bottom-right, like you get on a spreadsheet cell if you add a comment/note? We should also have a hotkey and I guess a tooltip, e.g. "Connection status Ctrl+Alt+S" or similar.Fixed, added accesskey 'T' for TX status tooltip shortcut as 'S' is already taken for Save file optionHmm - having seen it, I don't think the marker helps us.Can you remove it, and fix the tooltip (which doesn't seem to work)? If we always have the tooltip say "Connection status Ctrl+Alt+T" (or whatever is appropriate for the platform/browser), then that should give the user enough hint to click.Fixed.I have removed the marker & added tooltip instead but it is not possible to add specific shortcut keys in tooltip because accesskey may vary depending on OS & browser.That's better - though I think the tool tip is better as something like:Connection status (click for details) (<accesskey>+T)I'm still not overly happy with all the polling that's going on though. It's a lot of requests, especially with multiple QTs open. I think we need to be able to disable the feature entirely through a switch in the Preferences. In that case, no icon would be shown, and polling would be disabled - i.e. everything would be as it is now.What do you think?FixedMade it configurable & set default polling time to 10sec.Please review.--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company