Обсуждение: [JDBC] [pgjdbc/pgjdbc] 989b4d: fix: revert ExpressionProperties toProperties in ...

Поиск
Список
Период
Сортировка

[JDBC] [pgjdbc/pgjdbc] 989b4d: fix: revert ExpressionProperties toProperties in ...

От
Vladimir Sitnikov
Дата:
Branch: refs/heads/master
  Home:   https://github.com/pgjdbc/pgjdbc
  Commit: 989b4d235ec6776f31284d15618195cf7f8a7a79
      https://github.com/pgjdbc/pgjdbc/commit/989b4d235ec6776f31284d15618195cf7f8a7a79
  Author: Vladimir Sitnikov <sitnikov.vladimir@gmail.com>
  Date:   2017-02-12 (Sun, 12 Feb 2017)

  Changed paths:
    M pgjdbc/src/main/java/org/postgresql/ds/common/BaseDataSource.java

  Log Message:
  -----------
  fix: revert ExpressionProperties to Properties in BaseDataSource

ExpressionProperties is used for a specific property to avoid unexpected behaviors for already existing properties
(e.g.passwords with ${...}) 


  Commit: f1190d8c2eb1c506616e2298aabad211ba3bdb0a
      https://github.com/pgjdbc/pgjdbc/commit/f1190d8c2eb1c506616e2298aabad211ba3bdb0a
  Author: Vladimir Sitnikov <sitnikov.vladimir@gmail.com>
  Date:   2017-02-12 (Sun, 12 Feb 2017)

  Changed paths:
    M pgjdbc/src/main/java/org/postgresql/util/ReaderInputStream.java
    M pgjdbc/src/test/java/org/postgresql/test/jdbc2/Jdbc2TestSuite.java

  Log Message:
  -----------
  fix: correct edge cases for setCharacterStream(int, Reader)

ReaderInputStream behaved wrong (e.g. might return 0 instead of -1) at the end of the input in certain cases.


  Commit: b3553276ad48cbb47cd4849d3a08b7ee61be8ace
      https://github.com/pgjdbc/pgjdbc/commit/b3553276ad48cbb47cd4849d3a08b7ee61be8ace
  Author: Vladimir Sitnikov <sitnikov.vladimir@gmail.com>
  Date:   2017-02-12 (Sun, 12 Feb 2017)

  Changed paths:
    M pgjdbc/src/test/java/org/postgresql/test/jdbc4/jdbc41/Jdbc41TestSuite.java
    A pgjdbc/src/test/java/org/postgresql/test/jdbc4/jdbc41/SharedTimerClassLoaderLeakTest.java
    R pgjdbc/src/test/java/org/postgresql/test/util/SharedTimerClassLoaderLeakTest.java

  Log Message:
  -----------
  test: add SharedTimerClassLoaderLeakTest to the regular test suite


Compare: https://github.com/pgjdbc/pgjdbc/compare/e69e4a1d5502...b3553276ad48

Re: [JDBC] [pgjdbc/pgjdbc] 989b4d: fix: revert ExpressionPropertiesto Properties in ...

От
John R Pierce
Дата:
On 2/12/2017 9:55 AM, Vladimir Sitnikov wrote:
  Branch: refs/heads/master Home:   https://github.com/pgjdbc/pgjdbc Commit: 989b4d235ec6776f31284d15618195cf7f8a7a79     https://github.com/pgjdbc/pgjdbc/commit/989b4d235ec6776f31284d15618195cf7f8a7a79 Author: Vladimir Sitnikov <sitnikov.vladimir@gmail.com> Date:   2017-02-12 (Sun, 12 Feb 2017)

why is this email list getting git commit messages all the sudden?


-- 
john r pierce, recycling bits in santa cruz

Re: [pgjdbc/pgjdbc] 989b4d: fix: revert ExpressionPropertiesto Properties in ...

От
John R Pierce
Дата:
On 2/12/2017 9:55 AM, Vladimir Sitnikov wrote:
  Branch: refs/heads/master Home:   https://github.com/pgjdbc/pgjdbc Commit: 989b4d235ec6776f31284d15618195cf7f8a7a79     https://github.com/pgjdbc/pgjdbc/commit/989b4d235ec6776f31284d15618195cf7f8a7a79 Author: Vladimir Sitnikov <sitnikov.vladimir@gmail.com> Date:   2017-02-12 (Sun, 12 Feb 2017)

why is this email list getting git commit messages all the sudden?


-- 
john r pierce, recycling bits in santa cruz

Re: [JDBC] [pgjdbc/pgjdbc] 989b4d: fix: revert ExpressionPropertiesto Properties in ...

От
Dave Cramer
Дата:
I am forwarding them. Is this a problem?


On 12 February 2017 at 14:24, John R Pierce <pierce@hogranch.com> wrote:
On 2/12/2017 9:55 AM, Vladimir Sitnikov wrote:
  Branch: refs/heads/master Home:   https://github.com/pgjdbc/pgjdbc Commit: 989b4d235ec6776f31284d15618195cf7f8a7a79     https://github.com/pgjdbc/pgjdbc/commit/989b4d235ec6776f31284d15618195cf7f8a7a79 Author: Vladimir Sitnikov <sitnikov.vladimir@gmail.com> Date:   2017-02-12 (Sun, 12 Feb 2017)

why is this email list getting git commit messages all the sudden?


-- 
john r pierce, recycling bits in santa cruz

Re: [pgjdbc/pgjdbc] 989b4d: fix: revert ExpressionPropertiesto Properties in ...

От
Dave Cramer
Дата:
I am forwarding them. Is this a problem?


On 12 February 2017 at 14:24, John R Pierce <pierce@hogranch.com> wrote:
On 2/12/2017 9:55 AM, Vladimir Sitnikov wrote:
  Branch: refs/heads/master Home:   https://github.com/pgjdbc/pgjdbc Commit: 989b4d235ec6776f31284d15618195cf7f8a7a79     https://github.com/pgjdbc/pgjdbc/commit/989b4d235ec6776f31284d15618195cf7f8a7a79 Author: Vladimir Sitnikov <sitnikov.vladimir@gmail.com> Date:   2017-02-12 (Sun, 12 Feb 2017)

why is this email list getting git commit messages all the sudden?


-- 
john r pierce, recycling bits in santa cruz

Re: [pgjdbc/pgjdbc] 989b4d: fix: revert ExpressionPropertiesto Properties in ...

От
John R Pierce
Дата:
On 2/12/2017 11:29 AM, Dave Cramer wrote:
I am forwarding them. Is this a problem?


just curious.   they are of zero interest to me, as my interest in pg jdbc is from a casual user standpoint.  I can filter them out as long as they have the [pgjdbc/pgjdbc] tag on them...



-- 
john r pierce, recycling bits in santa cruz

Re: [JDBC] [pgjdbc/pgjdbc] 989b4d: fix: revert ExpressionPropertiesto Properties in ...

От
John R Pierce
Дата:
On 2/12/2017 11:29 AM, Dave Cramer wrote:
I am forwarding them. Is this a problem?


just curious.   they are of zero interest to me, as my interest in pg jdbc is from a casual user standpoint.  I can filter them out as long as they have the [pgjdbc/pgjdbc] tag on them...



-- 
john r pierce, recycling bits in santa cruz

Re: [JDBC] [pgjdbc/pgjdbc] 989b4d: fix: revert ExpressionPropertiesto Properties in ...

От
Vladimir Sitnikov
Дата:
What was the intention?

Is it for archiving purposes?
Then we might want to have separate list for that (like https://www.postgresql.org/list/pgsql-committers/ )

Vladimir

Re: [pgjdbc/pgjdbc] 989b4d: fix: revert ExpressionPropertiesto Properties in ...

От
Vladimir Sitnikov
Дата:
What was the intention?

Is it for archiving purposes?
Then we might want to have separate list for that (like https://www.postgresql.org/list/pgsql-committers/ )

Vladimir

Re: [JDBC] [pgjdbc/pgjdbc] 989b4d: fix: revert ExpressionPropertiesto Properties in ...

От
Dave Cramer
Дата:
Well I don't really want the commit messages, but at this point I don't have a good way to filter them out.

What the intent is; is to archive the discussion. Github is not searchable, and doesn't archive the discussion.

ASF does this, but I believe they use a git bot see this message for example.

http://mail-archives.apache.org/mod_mbox/incubator-madlib-dev/201612.mbox/%3C20161212225020.DA5BBE38C2%40git1-us-west.apache.org%3E


On 12 February 2017 at 14:38, Vladimir Sitnikov <sitnikov.vladimir@gmail.com> wrote:
What was the intention?

Is it for archiving purposes?
Then we might want to have separate list for that (like https://www.postgresql.org/list/pgsql-committers/ )

Vladimir

Re: [pgjdbc/pgjdbc] 989b4d: fix: revert ExpressionPropertiesto Properties in ...

От
Dave Cramer
Дата:
Well I don't really want the commit messages, but at this point I don't have a good way to filter them out.

What the intent is; is to archive the discussion. Github is not searchable, and doesn't archive the discussion.

ASF does this, but I believe they use a git bot see this message for example.

http://mail-archives.apache.org/mod_mbox/incubator-madlib-dev/201612.mbox/%3C20161212225020.DA5BBE38C2%40git1-us-west.apache.org%3E


On 12 February 2017 at 14:38, Vladimir Sitnikov <sitnikov.vladimir@gmail.com> wrote:
What was the intention?

Is it for archiving purposes?
Then we might want to have separate list for that (like https://www.postgresql.org/list/pgsql-committers/ )

Vladimir

Re: [JDBC] [pgjdbc/pgjdbc] 989b4d: fix: revert ExpressionPropertiesto Properties in ...

От
Brad DeJong
Дата:

Vladimir Sitnikov wrote:

> ... Then we might want to have seperate list for that ...

+1

 

I like the idea of having archived and searchable commits, but not on the main list.

Re: [pgjdbc/pgjdbc] 989b4d: fix: revert ExpressionPropertiesto Properties in ...

От
Brad DeJong
Дата:

Vladimir Sitnikov wrote:

> ... Then we might want to have seperate list for that ...

+1

 

I like the idea of having archived and searchable commits, but not on the main list.

Re: [pgjdbc/pgjdbc] 989b4d: fix: revert ExpressionPropertiesto Properties in ...

От
Dave Cramer
Дата:

On 13 February 2017 at 10:12, Brad DeJong <Brad.Dejong@infor.com> wrote:

Vladimir Sitnikov wrote:

> ... Then we might want to have seperate list for that ...

+1

 

I like the idea of having archived and searchable commits, but not on the main list.


Anyone know how to write a git bot ? 

Re: [JDBC] [pgjdbc/pgjdbc] 989b4d: fix: revert ExpressionPropertiesto Properties in ...

От
Dave Cramer
Дата:

On 13 February 2017 at 10:12, Brad DeJong <Brad.Dejong@infor.com> wrote:

Vladimir Sitnikov wrote:

> ... Then we might want to have seperate list for that ...

+1

 

I like the idea of having archived and searchable commits, but not on the main list.


Anyone know how to write a git bot ? 

Re: [pgjdbc/pgjdbc] 989b4d: fix: revert ExpressionPropertiesto Properties in ...

От
Vladimir Sitnikov
Дата:
Register a github user, add relevant pgjdbc-commits@postgresql.org email (via https://github.com/settings/emails ), make it subscribe to pgjdbc repositories and have fun.

I'm not sure what would be the quality of the resulting mails.

Is that feasible?

I'm not sure if there are services that would extract Github information (e.g. comments) and convert that to email thread format (that is pre-populate the archives).

Vladimir

Re: [JDBC] [pgjdbc/pgjdbc] 989b4d: fix: revert ExpressionPropertiesto Properties in ...

От
Vladimir Sitnikov
Дата:
Register a github user, add relevant pgjdbc-commits@postgresql.org email (via https://github.com/settings/emails ), make it subscribe to pgjdbc repositories and have fun.

I'm not sure what would be the quality of the resulting mails.

Is that feasible?

I'm not sure if there are services that would extract Github information (e.g. comments) and convert that to email thread format (that is pre-populate the archives).

Vladimir

Re: [pgjdbc/pgjdbc] 989b4d: fix: revert ExpressionPropertiesto Properties in ...

От
Dave Cramer
Дата:

On 13 February 2017 at 11:05, Vladimir Sitnikov <sitnikov.vladimir@gmail.com> wrote:
Register a github user, add relevant pgjdbc-commits@postgresql.org email (via https://github.com/settings/emails ), make it subscribe to pgjdbc repositories and have fun.

I'm not sure what would be the quality of the resulting mails.

Is that feasible?

I'm not sure if there are services that would extract Github information (e.g. comments) and convert that to email thread format (that is pre-populate the archives).

Apparently the ASF has a bot, I'm trying to get info on it.




Re: [JDBC] [pgjdbc/pgjdbc] 989b4d: fix: revert ExpressionPropertiesto Properties in ...

От
Dave Cramer
Дата:

On 13 February 2017 at 11:05, Vladimir Sitnikov <sitnikov.vladimir@gmail.com> wrote:
Register a github user, add relevant pgjdbc-commits@postgresql.org email (via https://github.com/settings/emails ), make it subscribe to pgjdbc repositories and have fun.

I'm not sure what would be the quality of the resulting mails.

Is that feasible?

I'm not sure if there are services that would extract Github information (e.g. comments) and convert that to email thread format (that is pre-populate the archives).

Apparently the ASF has a bot, I'm trying to get info on it.