Обсуждение: Increasing size of results grid
Folks,
I'd like to use pgadmin3 for more demos. But I find I can't because the
font size of the results grid is fixed as being fairly small, and
there's no way to make it larger.
How difficult would it be to make the results pane have a selectable
font size (and auto-adjust row size, I suppose)?
-- -- Josh Berkus PostgreSQL Experts Inc.
http://www.pgexperts.com
Hi, Le 11/10/2010 20:54, Josh Berkus a écrit : > [...] > I'd like to use pgadmin3 for more demos. But I find I can't because the > font size of the results grid is fixed as being fairly small, and > there's no way to make it larger. > There is a way. Go in the Options window, select the Preferences tab and change the Font. It will make, among other components the result grid bigger. > How difficult would it be to make the results pane have a selectable > font size (and auto-adjust row size, I suppose)? > I don't think it would be really difficult to have a specific parameter for the results pane. -- Guillaumehttp://www.postgresql.frhttp://dalibo.com
On Mon, Oct 11, 2010 at 10:37 PM, Guillaume Lelarge <guillaume@lelarge.info> wrote: > Hi, > > Le 11/10/2010 20:54, Josh Berkus a écrit : >> [...] >> I'd like to use pgadmin3 for more demos. But I find I can't because the >> font size of the results grid is fixed as being fairly small, and >> there's no way to make it larger. >> > > There is a way. Go in the Options window, select the Preferences tab and > change the Font. It will make, among other components the result grid > bigger. Thats what I thought, but I tested it on Mac and found it didn't work. wxMac bug? -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
On 12 October 2010 09:16, Dave Page <dpage@pgadmin.org> wrote: > On Mon, Oct 11, 2010 at 10:37 PM, Guillaume Lelarge > <guillaume@lelarge.info> wrote: >> Hi, >> >> Le 11/10/2010 20:54, Josh Berkus a écrit : >>> [...] >>> I'd like to use pgadmin3 for more demos. But I find I can't because the >>> font size of the results grid is fixed as being fairly small, and >>> there's no way to make it larger. >>> >> >> There is a way. Go in the Options window, select the Preferences tab and >> change the Font. It will make, among other components the result grid >> bigger. > > Thats what I thought, but I tested it on Mac and found it didn't work. > wxMac bug? Or, if you're a bit awesome, implement the ability to use CTRL + scrollwheel and CTRL + (+/-) to zoom in/out. -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935
Le 12/10/2010 10:16, Dave Page a écrit : > On Mon, Oct 11, 2010 at 10:37 PM, Guillaume Lelarge > <guillaume@lelarge.info> wrote: >> Hi, >> >> Le 11/10/2010 20:54, Josh Berkus a écrit : >>> [...] >>> I'd like to use pgadmin3 for more demos. But I find I can't because the >>> font size of the results grid is fixed as being fairly small, and >>> there's no way to make it larger. >>> >> >> There is a way. Go in the Options window, select the Preferences tab and >> change the Font. It will make, among other components the result grid >> bigger. > > Thats what I thought, but I tested it on Mac and found it didn't work. > wxMac bug? > Could be. I actually don't have my mac with me. I'll be able to check wednesday or thursday depending on the end of the strike in France. Works at least on Linux. -- Guillaumehttp://www.postgresql.frhttp://dalibo.com
Le 12/10/2010 10:22, Thom Brown a écrit : > On 12 October 2010 09:16, Dave Page <dpage@pgadmin.org> wrote: >> On Mon, Oct 11, 2010 at 10:37 PM, Guillaume Lelarge >> <guillaume@lelarge.info> wrote: >>> Hi, >>> >>> Le 11/10/2010 20:54, Josh Berkus a écrit : >>>> [...] >>>> I'd like to use pgadmin3 for more demos. But I find I can't because the >>>> font size of the results grid is fixed as being fairly small, and >>>> there's no way to make it larger. >>>> >>> >>> There is a way. Go in the Options window, select the Preferences tab and >>> change the Font. It will make, among other components the result grid >>> bigger. >> >> Thats what I thought, but I tested it on Mac and found it didn't work. >> wxMac bug? > > Or, if you're a bit awesome, implement the ability to use CTRL + > scrollwheel and CTRL + (+/-) to zoom in/out. > Could be funny to add this. I'll try to see if it works tonight. -- Guillaumehttp://www.postgresql.frhttp://dalibo.com
> Thats what I thought, but I tested it on Mac and found it didn't work.
> wxMac bug?
Doesn't work on my Mac either. Did not check it on Linux.
-- -- Josh Berkus PostgreSQL Experts Inc.
http://www.pgexperts.com
Le 12/10/2010 10:16, Dave Page a écrit : > On Mon, Oct 11, 2010 at 10:37 PM, Guillaume Lelarge > <guillaume@lelarge.info> wrote: >> Hi, >> >> Le 11/10/2010 20:54, Josh Berkus a écrit : >>> [...] >>> I'd like to use pgadmin3 for more demos. But I find I can't because the >>> font size of the results grid is fixed as being fairly small, and >>> there's no way to make it larger. >>> >> >> There is a way. Go in the Options window, select the Preferences tab and >> change the Font. It will make, among other components the result grid >> bigger. > > Thats what I thought, but I tested it on Mac and found it didn't work. > wxMac bug? > I think it is more a wxGTK/wxWin bug which changes the font of the cell when you use the function to change the font of the labels. Can someone on Mac tries this patch? I cannot on mine because I'm actually not able to built a good executable (good meaning which-doesn't-crash). -- Guillaume http://www.postgresql.fr http://dalibo.com
Вложения
Le 12/10/2010 10:22, Thom Brown a écrit : > On 12 October 2010 09:16, Dave Page <dpage@pgadmin.org> wrote: >> On Mon, Oct 11, 2010 at 10:37 PM, Guillaume Lelarge >> <guillaume@lelarge.info> wrote: >>> Hi, >>> >>> Le 11/10/2010 20:54, Josh Berkus a écrit : >>>> [...] >>>> I'd like to use pgadmin3 for more demos. But I find I can't because the >>>> font size of the results grid is fixed as being fairly small, and >>>> there's no way to make it larger. >>>> >>> >>> There is a way. Go in the Options window, select the Preferences tab and >>> change the Font. It will make, among other components the result grid >>> bigger. >> >> Thats what I thought, but I tested it on Mac and found it didn't work. >> wxMac bug? > > Or, if you're a bit awesome, implement the ability to use CTRL + > scrollwheel and CTRL + (+/-) to zoom in/out. > Turns out to be pretty simple. See the attached patch. It "only" handles Ctrl+MouseWheel. The other part shouldn't be hard to do. -- Guillaume http://www.postgresql.fr http://dalibo.com
Вложения
On Mon, Oct 18, 2010 at 10:59 PM, Guillaume Lelarge <guillaume@lelarge.info> wrote: > Le 12/10/2010 10:16, Dave Page a écrit : >> On Mon, Oct 11, 2010 at 10:37 PM, Guillaume Lelarge >> <guillaume@lelarge.info> wrote: >>> Hi, >>> >>> Le 11/10/2010 20:54, Josh Berkus a écrit : >>>> [...] >>>> I'd like to use pgadmin3 for more demos. But I find I can't because the >>>> font size of the results grid is fixed as being fairly small, and >>>> there's no way to make it larger. >>>> >>> >>> There is a way. Go in the Options window, select the Preferences tab and >>> change the Font. It will make, among other components the result grid >>> bigger. >> >> Thats what I thought, but I tested it on Mac and found it didn't work. >> wxMac bug? >> > > I think it is more a wxGTK/wxWin bug which changes the font of the cell > when you use the function to change the font of the labels. > > Can someone on Mac tries this patch? It picks up the main UI font, rather than the Query Tool font (which is used by ctlSQLBox). I'm not sure that's the appropriate behaviour. It also forces it to bold, because that's how the column/row headers are shown. We'd also need to ensure it also affects the edit grid, and other grids we may be using such as those on the debugger. > I cannot on mine because I'm > actually not able to built a good executable (good meaning > which-doesn't-crash). Oh? Not the fault of one of my recent commits I hope? -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Le 19/10/2010 00:27, Dave Page a écrit : > On Mon, Oct 18, 2010 at 10:59 PM, Guillaume Lelarge > <guillaume@lelarge.info> wrote: >> Le 12/10/2010 10:16, Dave Page a écrit : >>> On Mon, Oct 11, 2010 at 10:37 PM, Guillaume Lelarge >>> <guillaume@lelarge.info> wrote: >>>> Hi, >>>> >>>> Le 11/10/2010 20:54, Josh Berkus a écrit : >>>>> [...] >>>>> I'd like to use pgadmin3 for more demos. But I find I can't because the >>>>> font size of the results grid is fixed as being fairly small, and >>>>> there's no way to make it larger. >>>>> >>>> >>>> There is a way. Go in the Options window, select the Preferences tab and >>>> change the Font. It will make, among other components the result grid >>>> bigger. >>> >>> Thats what I thought, but I tested it on Mac and found it didn't work. >>> wxMac bug? >>> >> >> I think it is more a wxGTK/wxWin bug which changes the font of the cell >> when you use the function to change the font of the labels. >> >> Can someone on Mac tries this patch? > > It picks up the main UI font, rather than the Query Tool font (which > is used by ctlSQLBox). I'm not sure that's the appropriate behaviour. > It also forces it to bold, because that's how the column/row headers > are shown. > Yeah, just wanted to make sure we had to use the SetDefaultCellFont() method. Will use the Query Tool font. > We'd also need to ensure it also affects the edit grid, and other > grids we may be using such as those on the debugger. > +1 >> I cannot on mine because I'm >> actually not able to built a good executable (good meaning >> which-doesn't-crash). > > Oh? Not the fault of one of my recent commits I hope? > Nope. I'm not able to produce a single good Mac binary since a few months. But I don't think it has anything to do with an issue on the source code, it's more on the way I build it. -- Guillaumehttp://www.postgresql.frhttp://dalibo.com
Hi, I'm using Pgadmin a lot and i'm runing GNU/Linux. Is there a raison that pgadmin doesn't support native X11 copy/paste (from the mouse : select to copy and 3rd button to paste) ? I'm not a cpp developper, but it seems that thereis a function in wxClipboard for this : UsePrimarySelection <http://docs.wxwidgets.org/2.9/classwx_clipboard.html#ec2787c528e42791547a424e647b9dc2> (bool primary=false) On platforms supporting it (all X11-based ports), wxClipboard <http://docs.wxwidgets.org/2.9/classwx_clipboard.html> uses the CLIPBOARD X11 selection by default. Regards and thanks for this great job ! Philippe
Le 19/10/2010 12:09, Philippe Rimbault a écrit : > Hi, > > I'm using Pgadmin a lot and i'm runing GNU/Linux. > Is there a raison that pgadmin doesn't support native X11 copy/paste > (from the mouse : select to copy and 3rd button to paste) ? Lack of time (and probably the fact that I wasn't aware of it). > I'm not a cpp developper, but it seems that thereis a function in > wxClipboard for this : > > UsePrimarySelection > <http://docs.wxwidgets.org/2.9/classwx_clipboard.html#ec2787c528e42791547a424e647b9dc2> > (bool primary=false) On platforms supporting it (all X11-based ports), > wxClipboard <http://docs.wxwidgets.org/2.9/classwx_clipboard.html> uses > the CLIPBOARD X11 selection by default. > All these relate to wxWidgets 2.9, while we are still using 2.8. And we won't use 2.9 as it is a development branch. I'm still waiting to see a move to 3.0 before working on this (and also a lot of time). Though, there is probably a way to do that on 2.8 too. I added a ticket on this issue. -- Guillaumehttp://www.postgresql.frhttp://dalibo.com
Le 19/10/2010 08:15, Guillaume Lelarge a écrit : > Le 19/10/2010 00:27, Dave Page a écrit : >> On Mon, Oct 18, 2010 at 10:59 PM, Guillaume Lelarge >> <guillaume@lelarge.info> wrote: >>> Le 12/10/2010 10:16, Dave Page a écrit : >>>> On Mon, Oct 11, 2010 at 10:37 PM, Guillaume Lelarge >>>> <guillaume@lelarge.info> wrote: >>>>> Hi, >>>>> >>>>> Le 11/10/2010 20:54, Josh Berkus a écrit : >>>>>> [...] >>>>>> I'd like to use pgadmin3 for more demos. But I find I can't because the >>>>>> font size of the results grid is fixed as being fairly small, and >>>>>> there's no way to make it larger. >>>>>> >>>>> >>>>> There is a way. Go in the Options window, select the Preferences tab and >>>>> change the Font. It will make, among other components the result grid >>>>> bigger. >>>> >>>> Thats what I thought, but I tested it on Mac and found it didn't work. >>>> wxMac bug? >>>> >>> >>> I think it is more a wxGTK/wxWin bug which changes the font of the cell >>> when you use the function to change the font of the labels. >>> >>> Can someone on Mac tries this patch? >> >> It picks up the main UI font, rather than the Query Tool font (which >> is used by ctlSQLBox). I'm not sure that's the appropriate behaviour. >> It also forces it to bold, because that's how the column/row headers >> are shown. >> > > Yeah, just wanted to make sure we had to use the SetDefaultCellFont() > method. > > Will use the Query Tool font. > Done. >> We'd also need to ensure it also affects the edit grid, and other >> grids we may be using such as those on the debugger. >> > > +1 > If they use the ctlSQLResult, they should be fine. I tried on the edit grid and it worked. Two patchs attached: one for the font customization (which could be commited to 1.12 and master), one for the mousewheel support (which will only be applied to master). Any comments before I commit them? -- Guillaume http://www.postgresql.fr http://dalibo.com
On Tue, Oct 19, 2010 at 7:43 PM, Guillaume Lelarge <guillaume@lelarge.info> wrote: > Le 19/10/2010 08:15, Guillaume Lelarge a écrit : >> Le 19/10/2010 00:27, Dave Page a écrit : >>> On Mon, Oct 18, 2010 at 10:59 PM, Guillaume Lelarge >>> <guillaume@lelarge.info> wrote: >>>> Le 12/10/2010 10:16, Dave Page a écrit : >>>>> On Mon, Oct 11, 2010 at 10:37 PM, Guillaume Lelarge >>>>> <guillaume@lelarge.info> wrote: >>>>>> Hi, >>>>>> >>>>>> Le 11/10/2010 20:54, Josh Berkus a écrit : >>>>>>> [...] >>>>>>> I'd like to use pgadmin3 for more demos. But I find I can't because the >>>>>>> font size of the results grid is fixed as being fairly small, and >>>>>>> there's no way to make it larger. >>>>>>> >>>>>> >>>>>> There is a way. Go in the Options window, select the Preferences tab and >>>>>> change the Font. It will make, among other components the result grid >>>>>> bigger. >>>>> >>>>> Thats what I thought, but I tested it on Mac and found it didn't work. >>>>> wxMac bug? >>>>> >>>> >>>> I think it is more a wxGTK/wxWin bug which changes the font of the cell >>>> when you use the function to change the font of the labels. >>>> >>>> Can someone on Mac tries this patch? >>> >>> It picks up the main UI font, rather than the Query Tool font (which >>> is used by ctlSQLBox). I'm not sure that's the appropriate behaviour. >>> It also forces it to bold, because that's how the column/row headers >>> are shown. >>> >> >> Yeah, just wanted to make sure we had to use the SetDefaultCellFont() >> method. >> >> Will use the Query Tool font. >> > > Done. > >>> We'd also need to ensure it also affects the edit grid, and other >>> grids we may be using such as those on the debugger. >>> >> >> +1 >> > > If they use the ctlSQLResult, they should be fine. I tried on the edit > grid and it worked. Without wishing to sound too annoying, I'm actually thinking we need to tie this font to the main UI font contrary to my previous thoughts. Otherwise it might be odd compared to the other grids. I'm not sure though. Josh - which font setting did you expect to work here? -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
> Josh - which font setting did you expect to work here?
I'd prefer the SQL query window font setting, unless we had a specific
"grid" font setting. I don't want to increase the size of all my object
labels in order to display a larger query result.
-- -- Josh Berkus PostgreSQL Experts Inc.
http://www.pgexperts.com
On Tue, Oct 19, 2010 at 7:53 PM, Josh Berkus <josh@agliodbs.com> wrote: > >> Josh - which font setting did you expect to work here? > > I'd prefer the SQL query window font setting, unless we had a specific > "grid" font setting. I don't want to increase the size of all my object > labels in order to display a larger query result. OK, that seems reasonable. So this setting would affect both the grid and sqlbox on the query tool. Guillaume, do we need to manually fix the other grids (which should use the label font)? -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
On 19 October 2010 19:43, Guillaume Lelarge <guillaume@lelarge.info> wrote: > Le 19/10/2010 08:15, Guillaume Lelarge a écrit : >> Le 19/10/2010 00:27, Dave Page a écrit : >>> On Mon, Oct 18, 2010 at 10:59 PM, Guillaume Lelarge >>> <guillaume@lelarge.info> wrote: >>>> Le 12/10/2010 10:16, Dave Page a écrit : >>>>> On Mon, Oct 11, 2010 at 10:37 PM, Guillaume Lelarge >>>>> <guillaume@lelarge.info> wrote: >>>>>> Hi, >>>>>> >>>>>> Le 11/10/2010 20:54, Josh Berkus a écrit : >>>>>>> [...] >>>>>>> I'd like to use pgadmin3 for more demos. But I find I can't because the >>>>>>> font size of the results grid is fixed as being fairly small, and >>>>>>> there's no way to make it larger. >>>>>>> >>>>>> >>>>>> There is a way. Go in the Options window, select the Preferences tab and >>>>>> change the Font. It will make, among other components the result grid >>>>>> bigger. >>>>> >>>>> Thats what I thought, but I tested it on Mac and found it didn't work. >>>>> wxMac bug? >>>>> >>>> >>>> I think it is more a wxGTK/wxWin bug which changes the font of the cell >>>> when you use the function to change the font of the labels. >>>> >>>> Can someone on Mac tries this patch? >>> >>> It picks up the main UI font, rather than the Query Tool font (which >>> is used by ctlSQLBox). I'm not sure that's the appropriate behaviour. >>> It also forces it to bold, because that's how the column/row headers >>> are shown. >>> >> >> Yeah, just wanted to make sure we had to use the SetDefaultCellFont() >> method. >> >> Will use the Query Tool font. >> > > Done. > >>> We'd also need to ensure it also affects the edit grid, and other >>> grids we may be using such as those on the debugger. >>> >> >> +1 >> > > If they use the ctlSQLResult, they should be fine. I tried on the edit > grid and it worked. > > Two patchs attached: one for the font customization (which could be > commited to 1.12 and master), one for the mousewheel support (which will > only be applied to master). > > Any comments before I commit them? Yes, the scrollwheel zoom should really also increase the height of rows and size of text on column titles/row numbers too if that's possible. And I'm wondering if the zoom should be persistent. -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935
Le 19/10/2010 20:56, Dave Page a écrit : > On Tue, Oct 19, 2010 at 7:53 PM, Josh Berkus <josh@agliodbs.com> wrote: >> >>> Josh - which font setting did you expect to work here? >> >> I'd prefer the SQL query window font setting, unless we had a specific >> "grid" font setting. I don't want to increase the size of all my object >> labels in order to display a larger query result. > > OK, that seems reasonable. So this setting would affect both the grid > and sqlbox on the query tool. > We can probably do both: * use the query font for the grid on 1.12* add a new setting for grid font on 1.13 I completely agree with Josh when he says we don't want to increase the size of all labels in order to display a larger query result. > Guillaume, do we need to manually fix the other grids (which should > use the label font)? > On the edit grid, no, because it uses the same component. I'm less sure with the debugger tool, and I have no way to check this easily. -- Guillaumehttp://www.postgresql.frhttp://dalibo.com
Le 19/10/2010 21:15, Thom Brown a écrit : > On 19 October 2010 19:43, Guillaume Lelarge <guillaume@lelarge.info> wrote: >> Le 19/10/2010 08:15, Guillaume Lelarge a écrit : >>> Le 19/10/2010 00:27, Dave Page a écrit : >>>> On Mon, Oct 18, 2010 at 10:59 PM, Guillaume Lelarge >>>> <guillaume@lelarge.info> wrote: >>>>> Le 12/10/2010 10:16, Dave Page a écrit : >>>>>> On Mon, Oct 11, 2010 at 10:37 PM, Guillaume Lelarge >>>>>> <guillaume@lelarge.info> wrote: >>>>>>> Hi, >>>>>>> >>>>>>> Le 11/10/2010 20:54, Josh Berkus a écrit : >>>>>>>> [...] >>>>>>>> I'd like to use pgadmin3 for more demos. But I find I can't because the >>>>>>>> font size of the results grid is fixed as being fairly small, and >>>>>>>> there's no way to make it larger. >>>>>>>> >>>>>>> >>>>>>> There is a way. Go in the Options window, select the Preferences tab and >>>>>>> change the Font. It will make, among other components the result grid >>>>>>> bigger. >>>>>> >>>>>> Thats what I thought, but I tested it on Mac and found it didn't work. >>>>>> wxMac bug? >>>>>> >>>>> >>>>> I think it is more a wxGTK/wxWin bug which changes the font of the cell >>>>> when you use the function to change the font of the labels. >>>>> >>>>> Can someone on Mac tries this patch? >>>> >>>> It picks up the main UI font, rather than the Query Tool font (which >>>> is used by ctlSQLBox). I'm not sure that's the appropriate behaviour. >>>> It also forces it to bold, because that's how the column/row headers >>>> are shown. >>>> >>> >>> Yeah, just wanted to make sure we had to use the SetDefaultCellFont() >>> method. >>> >>> Will use the Query Tool font. >>> >> >> Done. >> >>>> We'd also need to ensure it also affects the edit grid, and other >>>> grids we may be using such as those on the debugger. >>>> >>> >>> +1 >>> >> >> If they use the ctlSQLResult, they should be fine. I tried on the edit >> grid and it worked. >> >> Two patchs attached: one for the font customization (which could be >> commited to 1.12 and master), one for the mousewheel support (which will >> only be applied to master). >> >> Any comments before I commit them? > > Yes, the scrollwheel zoom should really also increase the height of > rows and size of text on column titles/row numbers too if that's > possible. You're right. Done in this new attached patch. > And I'm wondering if the zoom should be persistent. > No, I don't think so. Maybe someone has a stronger opinion on this? -- Guillaume http://www.postgresql.fr http://dalibo.com
Вложения
On 19 October 2010 21:08, Guillaume Lelarge <guillaume@lelarge.info> wrote: > Le 19/10/2010 21:15, Thom Brown a écrit : >> On 19 October 2010 19:43, Guillaume Lelarge <guillaume@lelarge.info> wrote: >>> Le 19/10/2010 08:15, Guillaume Lelarge a écrit : >>>> Le 19/10/2010 00:27, Dave Page a écrit : >>>>> On Mon, Oct 18, 2010 at 10:59 PM, Guillaume Lelarge >>>>> <guillaume@lelarge.info> wrote: >>>>>> Le 12/10/2010 10:16, Dave Page a écrit : >>>>>>> On Mon, Oct 11, 2010 at 10:37 PM, Guillaume Lelarge >>>>>>> <guillaume@lelarge.info> wrote: >>>>>>>> Hi, >>>>>>>> >>>>>>>> Le 11/10/2010 20:54, Josh Berkus a écrit : >>>>>>>>> [...] >>>>>>>>> I'd like to use pgadmin3 for more demos. But I find I can't because the >>>>>>>>> font size of the results grid is fixed as being fairly small, and >>>>>>>>> there's no way to make it larger. >>>>>>>>> >>>>>>>> >>>>>>>> There is a way. Go in the Options window, select the Preferences tab and >>>>>>>> change the Font. It will make, among other components the result grid >>>>>>>> bigger. >>>>>>> >>>>>>> Thats what I thought, but I tested it on Mac and found it didn't work. >>>>>>> wxMac bug? >>>>>>> >>>>>> >>>>>> I think it is more a wxGTK/wxWin bug which changes the font of the cell >>>>>> when you use the function to change the font of the labels. >>>>>> >>>>>> Can someone on Mac tries this patch? >>>>> >>>>> It picks up the main UI font, rather than the Query Tool font (which >>>>> is used by ctlSQLBox). I'm not sure that's the appropriate behaviour. >>>>> It also forces it to bold, because that's how the column/row headers >>>>> are shown. >>>>> >>>> >>>> Yeah, just wanted to make sure we had to use the SetDefaultCellFont() >>>> method. >>>> >>>> Will use the Query Tool font. >>>> >>> >>> Done. >>> >>>>> We'd also need to ensure it also affects the edit grid, and other >>>>> grids we may be using such as those on the debugger. >>>>> >>>> >>>> +1 >>>> >>> >>> If they use the ctlSQLResult, they should be fine. I tried on the edit >>> grid and it worked. >>> >>> Two patchs attached: one for the font customization (which could be >>> commited to 1.12 and master), one for the mousewheel support (which will >>> only be applied to master). >>> >>> Any comments before I commit them? >> >> Yes, the scrollwheel zoom should really also increase the height of >> rows and size of text on column titles/row numbers too if that's >> possible. > > You're right. Done in this new attached patch. Yep, that's excellent :) One problem is that if you zoom in and scroll down to a high-numbered row, it's cropped and you can't see the whole number, so that would have to adjust too. Might be unreasonable for me to ask for column widths to also increase proportionately, but it's better than before with your latest patch. -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935
On 19 October 2010 21:24, Thom Brown <thom@linux.com> wrote: > On 19 October 2010 21:08, Guillaume Lelarge <guillaume@lelarge.info> wrote: >> You're right. Done in this new attached patch. > > Yep, that's excellent :) One problem is that if you zoom in and > scroll down to a high-numbered row, it's cropped and you can't see the > whole number, so that would have to adjust too. Might be unreasonable > for me to ask for column widths to also increase proportionately, but > it's better than before with your latest patch. Oh, something else I've noticed. The zoom in the SQL Editor is the opposite of the grid. CTRL+scrollwheel up zooms out rather than in. -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935
Le 19/10/2010 13:29, Thom Brown a écrit : > On 19 October 2010 21:24, Thom Brown <thom@linux.com> wrote: >> On 19 October 2010 21:08, Guillaume Lelarge <guillaume@lelarge.info> wrote: >>> You're right. Done in this new attached patch. >> >> Yep, that's excellent :) One problem is that if you zoom in and >> scroll down to a high-numbered row, it's cropped and you can't see the >> whole number, so that would have to adjust too. Might be unreasonable >> for me to ask for column widths to also increase proportionately, but >> it's better than before with your latest patch. > > Oh, something else I've noticed. The zoom in the SQL Editor is the > opposite of the grid. CTRL+scrollwheel up zooms out rather than in. > Both fixed in this new patch. I also fix a BIG issue: my previous patch doesn't allow the use of the wheel to move rows :) So, what about this patch? good enough, I hope :) -- Guillaume http://www.postgresql.fr http://dalibo.com
Вложения
On 22 October 2010 00:34, Guillaume Lelarge <guillaume@lelarge.info> wrote: > Le 19/10/2010 13:29, Thom Brown a écrit : >> On 19 October 2010 21:24, Thom Brown <thom@linux.com> wrote: >>> On 19 October 2010 21:08, Guillaume Lelarge <guillaume@lelarge.info> wrote: >>>> You're right. Done in this new attached patch. >>> >>> Yep, that's excellent :) One problem is that if you zoom in and >>> scroll down to a high-numbered row, it's cropped and you can't see the >>> whole number, so that would have to adjust too. Might be unreasonable >>> for me to ask for column widths to also increase proportionately, but >>> it's better than before with your latest patch. >> >> Oh, something else I've noticed. The zoom in the SQL Editor is the >> opposite of the grid. CTRL+scrollwheel up zooms out rather than in. >> > > Both fixed in this new patch. I also fix a BIG issue: my previous patch > doesn't allow the use of the wheel to move rows :) > > So, what about this patch? good enough, I hope :) I've tried building it twice because I couldn't see what had changed, except I notice CTRL+scrollwheel up zooms out now on both the SQL pane and results. Shouldn't those both be the other way round? It's just web browsers all work that way. But I can't see the column widths adjusting, or the row number container width increasing either. Running Linux btw. -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935
On 22 October 2010 11:51, Thom Brown <thom@linux.com> wrote: > On 22 October 2010 00:34, Guillaume Lelarge <guillaume@lelarge.info> wrote: >> Le 19/10/2010 13:29, Thom Brown a écrit : >>> On 19 October 2010 21:24, Thom Brown <thom@linux.com> wrote: >>>> On 19 October 2010 21:08, Guillaume Lelarge <guillaume@lelarge.info> wrote: >>>>> You're right. Done in this new attached patch. >>>> >>>> Yep, that's excellent :) One problem is that if you zoom in and >>>> scroll down to a high-numbered row, it's cropped and you can't see the >>>> whole number, so that would have to adjust too. Might be unreasonable >>>> for me to ask for column widths to also increase proportionately, but >>>> it's better than before with your latest patch. >>> >>> Oh, something else I've noticed. The zoom in the SQL Editor is the >>> opposite of the grid. CTRL+scrollwheel up zooms out rather than in. >>> >> >> Both fixed in this new patch. I also fix a BIG issue: my previous patch >> doesn't allow the use of the wheel to move rows :) >> >> So, what about this patch? good enough, I hope :) > > I've tried building it twice because I couldn't see what had changed, > except I notice CTRL+scrollwheel up zooms out now on both the SQL pane > and results. Shouldn't those both be the other way round? It's just > web browsers all work that way. > > But I can't see the column widths adjusting, or the row number > container width increasing either. Running Linux btw. However, I have noticed an extra level of sheen in this version. Have you guys changed something? The tabs look shiny and the toolbar looks less bulky. -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935
Le 22/10/2010 03:51, Thom Brown a écrit : > On 22 October 2010 00:34, Guillaume Lelarge <guillaume@lelarge.info> wrote: >> Le 19/10/2010 13:29, Thom Brown a écrit : >>> On 19 October 2010 21:24, Thom Brown <thom@linux.com> wrote: >>>> On 19 October 2010 21:08, Guillaume Lelarge <guillaume@lelarge.info> wrote: >>>>> You're right. Done in this new attached patch. >>>> >>>> Yep, that's excellent :) One problem is that if you zoom in and >>>> scroll down to a high-numbered row, it's cropped and you can't see the >>>> whole number, so that would have to adjust too. Might be unreasonable >>>> for me to ask for column widths to also increase proportionately, but >>>> it's better than before with your latest patch. >>> >>> Oh, something else I've noticed. The zoom in the SQL Editor is the >>> opposite of the grid. CTRL+scrollwheel up zooms out rather than in. >>> >> >> Both fixed in this new patch. I also fix a BIG issue: my previous patch >> doesn't allow the use of the wheel to move rows :) >> >> So, what about this patch? good enough, I hope :) > > I've tried building it twice because I couldn't see what had changed, > except I notice CTRL+scrollwheel up zooms out now on both the SQL pane > and results. Shouldn't those both be the other way round? It's just > web browsers all work that way. > I didn't do anything for the SQL pane. In fact, it's a capacity of the component we use. My only change was to make it consistent with the way the integrated component works. > But I can't see the column widths adjusting, or the row number > container width increasing either. Running Linux btw. > Row height should change. I had a bug on the column widths stuff. It should now work the wxWidgets way, meaning we only use the labels size to change the width of the columns. New patch attached. -- Guillaume http://www.postgresql.fr http://dalibo.com
Вложения
Le 22/10/2010 04:02, Thom Brown a écrit : > On 22 October 2010 11:51, Thom Brown <thom@linux.com> wrote: >> On 22 October 2010 00:34, Guillaume Lelarge <guillaume@lelarge.info> wrote: >>> Le 19/10/2010 13:29, Thom Brown a écrit : >>>> On 19 October 2010 21:24, Thom Brown <thom@linux.com> wrote: >>>>> On 19 October 2010 21:08, Guillaume Lelarge <guillaume@lelarge.info> wrote: >>>>>> You're right. Done in this new attached patch. >>>>> >>>>> Yep, that's excellent :) One problem is that if you zoom in and >>>>> scroll down to a high-numbered row, it's cropped and you can't see the >>>>> whole number, so that would have to adjust too. Might be unreasonable >>>>> for me to ask for column widths to also increase proportionately, but >>>>> it's better than before with your latest patch. >>>> >>>> Oh, something else I've noticed. The zoom in the SQL Editor is the >>>> opposite of the grid. CTRL+scrollwheel up zooms out rather than in. >>>> >>> >>> Both fixed in this new patch. I also fix a BIG issue: my previous patch >>> doesn't allow the use of the wheel to move rows :) >>> >>> So, what about this patch? good enough, I hope :) >> >> I've tried building it twice because I couldn't see what had changed, >> except I notice CTRL+scrollwheel up zooms out now on both the SQL pane >> and results. Shouldn't those both be the other way round? It's just >> web browsers all work that way. >> >> But I can't see the column widths adjusting, or the row number >> container width increasing either. Running Linux btw. > > However, I have noticed an extra level of sheen in this version. Have > you guys changed something? The tabs look shiny and the toolbar looks > less bulky. > I don't think we did anything to get that result. -- Guillaumehttp://www.postgresql.frhttp://dalibo.com
> There is a way. Go in the Options window, select the Preferences tab andThats what I thought, but I tested it on Mac and found it didn't work.
> change the Font. It will make, among other components the result grid
> bigger.
wxMac bug?
it is not a bug, FontConfiguration on Mac needs to be approved by Steve Jobs; and you do not need another Fontsize.
Harald
GHUM GmbH
Harald Armin Massa
Spielberger Straße 49
70435 Stuttgart
0173/9409607
Amtsgericht Stuttgart, HRB 734971
-
persuadere.
et programmare
On Fri, Oct 22, 2010 at 12:02 PM, Thom Brown <thom@linux.com> wrote: > However, I have noticed an extra level of sheen in this version. Have > you guys changed something? The tabs look shiny and the toolbar looks > less bulky. Are you testing git master? I've been hacking on the UI a little, particularly on the tabs. Haven't touched the toolbar though. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
On 22/10/2010 12:02, Thom Brown wrote: > However, I have noticed an extra level of sheen in this version. Have > you guys changed something? The tabs look shiny and the toolbar looks > less bulky. I get that effect when I clean the dust off my monitor... :-P Ray. -- Raymond O'Donnell :: Galway :: Ireland rod@iol.ie
On 22 October 2010 12:31, Guillaume Lelarge <guillaume@lelarge.info> wrote: > Le 22/10/2010 03:51, Thom Brown a écrit : >> On 22 October 2010 00:34, Guillaume Lelarge <guillaume@lelarge.info> wrote: >>> Le 19/10/2010 13:29, Thom Brown a écrit : >>>> On 19 October 2010 21:24, Thom Brown <thom@linux.com> wrote: >>>>> On 19 October 2010 21:08, Guillaume Lelarge <guillaume@lelarge.info> wrote: >>>>>> You're right. Done in this new attached patch. >>>>> >>>>> Yep, that's excellent :) One problem is that if you zoom in and >>>>> scroll down to a high-numbered row, it's cropped and you can't see the >>>>> whole number, so that would have to adjust too. Might be unreasonable >>>>> for me to ask for column widths to also increase proportionately, but >>>>> it's better than before with your latest patch. >>>> >>>> Oh, something else I've noticed. The zoom in the SQL Editor is the >>>> opposite of the grid. CTRL+scrollwheel up zooms out rather than in. >>>> >>> >>> Both fixed in this new patch. I also fix a BIG issue: my previous patch >>> doesn't allow the use of the wheel to move rows :) >>> >>> So, what about this patch? good enough, I hope :) >> >> I've tried building it twice because I couldn't see what had changed, >> except I notice CTRL+scrollwheel up zooms out now on both the SQL pane >> and results. Shouldn't those both be the other way round? It's just >> web browsers all work that way. >> > > I didn't do anything for the SQL pane. In fact, it's a capacity of the > component we use. My only change was to make it consistent with the way > the integrated component works. Okay, fair enough. :) >> But I can't see the column widths adjusting, or the row number >> container width increasing either. Running Linux btw. >> > > Row height should change. I had a bug on the column widths stuff. It > should now work the wxWidgets way, meaning we only use the labels size > to change the width of the columns. > > New patch attached. Yes, row height correctly changed previously. Okay, the column width also correctly resizes now. The row numbers still crop though when scaling up. As for not changing anything to make it look glossy, not sure what's different then. Nice work though Guillaume :) And I'll continue to be annoying, but would it be easy to make the scrollwheel zoom functionality work on Explain, Messages, History and even the object browser tree? (The font size used on my object browser always looks too large in Ubuntu). All a nice-to-have rather than a need though. -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935
On 22 October 2010 12:46, Dave Page <dpage@pgadmin.org> wrote: > On Fri, Oct 22, 2010 at 12:02 PM, Thom Brown <thom@linux.com> wrote: >> However, I have noticed an extra level of sheen in this version. Have >> you guys changed something? The tabs look shiny and the toolbar looks >> less bulky. > > Are you testing git master? I've been hacking on the UI a little, > particularly on the tabs. Haven't touched the toolbar though. Yes, git master. The toolbar only has less space around icons, so not sure why that is in this case. -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935
Le 22/10/2010 04:49, Thom Brown a écrit : > On 22 October 2010 12:31, Guillaume Lelarge <guillaume@lelarge.info> wrote: >> Le 22/10/2010 03:51, Thom Brown a écrit : >>> On 22 October 2010 00:34, Guillaume Lelarge <guillaume@lelarge.info> wrote: >>>> Le 19/10/2010 13:29, Thom Brown a écrit : >>>>> On 19 October 2010 21:24, Thom Brown <thom@linux.com> wrote: >>>>>> On 19 October 2010 21:08, Guillaume Lelarge <guillaume@lelarge.info> wrote: >>>>>>> You're right. Done in this new attached patch. >>>>>> >>>>>> Yep, that's excellent :) One problem is that if you zoom in and >>>>>> scroll down to a high-numbered row, it's cropped and you can't see the >>>>>> whole number, so that would have to adjust too. Might be unreasonable >>>>>> for me to ask for column widths to also increase proportionately, but >>>>>> it's better than before with your latest patch. >>>>> >>>>> Oh, something else I've noticed. The zoom in the SQL Editor is the >>>>> opposite of the grid. CTRL+scrollwheel up zooms out rather than in. >>>>> >>>> >>>> Both fixed in this new patch. I also fix a BIG issue: my previous patch >>>> doesn't allow the use of the wheel to move rows :) >>>> >>>> So, what about this patch? good enough, I hope :) >>> >>> I've tried building it twice because I couldn't see what had changed, >>> except I notice CTRL+scrollwheel up zooms out now on both the SQL pane >>> and results. Shouldn't those both be the other way round? It's just >>> web browsers all work that way. >>> >> >> I didn't do anything for the SQL pane. In fact, it's a capacity of the >> component we use. My only change was to make it consistent with the way >> the integrated component works. > > Okay, fair enough. :) > >>> But I can't see the column widths adjusting, or the row number >>> container width increasing either. Running Linux btw. >>> >> >> Row height should change. I had a bug on the column widths stuff. It >> should now work the wxWidgets way, meaning we only use the labels size >> to change the width of the columns. >> >> New patch attached. > > Yes, row height correctly changed previously. > > Okay, the column width also correctly resizes now. The row numbers > still crop though when scaling up. > > As for not changing anything to make it look glossy, not sure what's > different then. > > Nice work though Guillaume :) > Thanks, commited. > And I'll continue to be annoying, but would it be easy to make the > scrollwheel zoom functionality work on Explain, Messages, History and > even the object browser tree? (The font size used on my object > browser always looks too large in Ubuntu). All a nice-to-have rather > than a need though. > I created a ticket (#268) for that. No sure we really need this on the browser tree, not even sure that it can be done. -- Guillaumehttp://www.postgresql.frhttp://dalibo.com
Le 19/10/2010 12:51, Guillaume Lelarge a écrit : > Le 19/10/2010 20:56, Dave Page a écrit : >> On Tue, Oct 19, 2010 at 7:53 PM, Josh Berkus <josh@agliodbs.com> wrote: >>> >>>> Josh - which font setting did you expect to work here? >>> >>> I'd prefer the SQL query window font setting, unless we had a specific >>> "grid" font setting. I don't want to increase the size of all my object >>> labels in order to display a larger query result. >> >> OK, that seems reasonable. So this setting would affect both the grid >> and sqlbox on the query tool. >> > > We can probably do both: > > * use the query font for the grid on 1.12 This one is commited. > * add a new setting for grid font on 1.13 No comments, so probably not such a good idea. > I completely agree with Josh when he says we don't want to increase the > size of all labels in order to display a larger query result. > >> Guillaume, do we need to manually fix the other grids (which should >> use the label font)? >> > > On the edit grid, no, because it uses the same component. I'm less sure > with the debugger tool, and I have no way to check this easily. > > -- Guillaumehttp://www.postgresql.frhttp://dalibo.com