Re: add modulo (%) operator to pgbench

Поиск
Список
Период
Сортировка
Искать
От
Fabien COELHO
Тема
Re: add modulo (%) operator to pgbench
Дата
Msg-id
alpine.DEB.2.10.1412311305510.8764@sto
Ответ на
Список
Дерево обсуждения
add modulo (%) operator to pgbench Fabien <coelho@cri.ensmp.fr>
Re: add modulo (%) operator to pgbench Fabien COELHO <coelho@cri.ensmp.fr>
Re: add modulo (%) operator to pgbench Robert Haas <robertmhaas@gmail.com>
Re: add modulo (%) operator to pgbench Alvaro Herrera <alvherre@2ndquadrant.com>
Re: add modulo (%) operator to pgbench Fabien COELHO <coelho@cri.ensmp.fr>
Re: add modulo (%) operator to pgbench Robert Haas <robertmhaas@gmail.com>
Re: add modulo (%) operator to pgbench Fabien COELHO <coelho@cri.ensmp.fr>
Re: add modulo (%) operator to pgbench Robert Haas <robertmhaas@gmail.com>
Re: add modulo (%) operator to pgbench Fabien COELHO <coelho@cri.ensmp.fr>
Re: add modulo (%) operator to pgbench Robert Haas <robertmhaas@gmail.com>
Re: add modulo (%) operator to pgbench Fabien COELHO <coelho@cri.ensmp.fr>
Re: add modulo (%) operator to pgbench Robert Haas <robertmhaas@gmail.com>
Re: add modulo (%) operator to pgbench Fabien COELHO <coelho@cri.ensmp.fr>
Re: add modulo (%) operator to pgbench Robert Haas <robertmhaas@gmail.com>
Re: add modulo (%) operator to pgbench Fabien COELHO <coelho@cri.ensmp.fr>
Re: add modulo (%) operator to pgbench Stephen Frost <sfrost@snowman.net>
Re: add modulo (%) operator to pgbench Fabien COELHO <coelho@cri.ensmp.fr>
Re: add modulo (%) operator to pgbench Tom Lane <tgl@sss.pgh.pa.us>
Re: add modulo (%) operator to pgbench Stephen Frost <sfrost@snowman.net>
Re: add modulo (%) operator to pgbench Fabien COELHO <coelho@cri.ensmp.fr>
Re: add modulo (%) operator to pgbench Kevin Grittner <kgrittn@ymail.com>
Re: add modulo (%) operator to pgbench Tom Lane <tgl@sss.pgh.pa.us>
Re: add modulo (%) operator to pgbench Fabien COELHO <coelho@cri.ensmp.fr>
Re: add modulo (%) operator to pgbench Heikki Linnakangas <hlinnakangas@vmware.com>
Re: add modulo (%) operator to pgbench Fabien COELHO <coelho@cri.ensmp.fr>
Re: add modulo (%) operator to pgbench Heikki Linnakangas <hlinnakangas@vmware.com>
Re: add modulo (%) operator to pgbench Fabien COELHO <coelho@cri.ensmp.fr>
Re: add modulo (%) operator to pgbench Heikki Linnakangas <hlinnakangas@vmware.com>
Re: add modulo (%) operator to pgbench Robert Haas <robertmhaas@gmail.com>
Re: add modulo (%) operator to pgbench Gregory Smith <gregsmithpgsql@gmail.com>
Re: add modulo (%) operator to pgbench Fabien COELHO <coelho@cri.ensmp.fr>
Re: add modulo (%) operator to pgbench Robert Haas <robertmhaas@gmail.com>
Re: add modulo (%) operator to pgbench Gregory Smith <gregsmithpgsql@gmail.com>
Re: add modulo (%) operator to pgbench Heikki Linnakangas <hlinnakangas@vmware.com>
Re: add modulo (%) operator to pgbench Andrew Dunstan <andrew@dunslane.net>
Re: add modulo (%) operator to pgbench Fabien COELHO <coelho@cri.ensmp.fr>
Re: add modulo (%) operator to pgbench Andrew Dunstan <andrew@dunslane.net>
Re: add modulo (%) operator to pgbench Fabien COELHO <coelho@cri.ensmp.fr>
Re: add modulo (%) operator to pgbench Fabien COELHO <coelho@cri.ensmp.fr>
Re: add modulo (%) operator to pgbench Fabien COELHO <coelho@cri.ensmp.fr>
Re: add modulo (%) operator to pgbench David Rowley <dgrowleyml@gmail.com>
Re: add modulo (%) operator to pgbench Fabien COELHO <coelho@cri.ensmp.fr>
Re: add modulo (%) operator to pgbench David Rowley <dgrowleyml@gmail.com>
Re: add modulo (%) operator to pgbench Alvaro Herrera <alvherre@2ndquadrant.com>
Re: add modulo (%) operator to pgbench Fabien COELHO <coelho@cri.ensmp.fr>
Re: add modulo (%) operator to pgbench David Rowley <dgrowleyml@gmail.com>
Re: add modulo (%) operator to pgbench Alvaro Herrera <alvherre@2ndquadrant.com>
Re: add modulo (%) operator to pgbench Fabien COELHO <coelho@cri.ensmp.fr>
Re: add modulo (%) operator to pgbench Fabien COELHO <coelho@cri.ensmp.fr>
Re: add modulo (%) operator to pgbench Fabien COELHO <coelho@cri.ensmp.fr>
Re: add modulo (%) operator to pgbench Alvaro Herrera <alvherre@2ndquadrant.com>
Re: add modulo (%) operator to pgbench Fabien COELHO <coelho@cri.ensmp.fr>
Re: add modulo (%) operator to pgbench Robert Haas <robertmhaas@gmail.com>
Re: add modulo (%) operator to pgbench Fabien COELHO <coelho@cri.ensmp.fr>
Re: add modulo (%) operator to pgbench Stephen Frost <sfrost@snowman.net>
Re: add modulo (%) operator to pgbench Robert Haas <robertmhaas@gmail.com>
Re: add modulo (%) operator to pgbench Robert Haas <robertmhaas@gmail.com>
Re: add modulo (%) operator to pgbench Fabien COELHO <coelho@cri.ensmp.fr>
Re: add modulo (%) operator to pgbench Robert Haas <robertmhaas@gmail.com>
Re: add modulo (%) operator to pgbench Fabien COELHO <coelho@cri.ensmp.fr>
Re: add modulo (%) operator to pgbench Fabien COELHO <coelho@cri.ensmp.fr>
Re: add modulo (%) operator to pgbench Mitsumasa KONDO <kondo.mitsumasa@gmail.com>
Re: add modulo (%) operator to pgbench Fabien COELHO <coelho@cri.ensmp.fr>
Re: add modulo (%) operator to pgbench Fabien COELHO <coelho@cri.ensmp.fr>
Re: add modulo (%) operator to pgbench Mitsumasa KONDO <kondo.mitsumasa@gmail.com>
Re: add modulo (%) operator to pgbench Mitsumasa KONDO <kondo.mitsumasa@gmail.com>
Re: add modulo (%) operator to pgbench Fabien COELHO <coelho@cri.ensmp.fr>
Re: add modulo (%) operator to pgbench Mitsumasa KONDO <kondo.mitsumasa@gmail.com>
Re: add modulo (%) operator to pgbench Fabien COELHO <coelho@cri.ensmp.fr>

Here is a review & updated version of the patch.

Patch applies and compiles without problem on current head,
and worked for the various tests I made with custom scripts.

This patch is a good thing, and I recommand warmly its inclusion. It 
extends greatly pgbench custom capabilities by allowing arbitrary integer 
expressions, and will allow to add other functions (I'll send abs() & a 
hash(), and possibly others).

I'm not sure about what Makefile changes could be necessary for
various environments, it looks ok to me as it is.

I have included the following additional changes in v2:

(1) small update to pgbench documentation. English proof reading is welcome.

(2) improve error reporting to display the file and line from where an error    is raised, and also the column on syntax errors (yyline is always 1...).    The prior status was that there were no way to get this information, which    was quite annoying.  It could probably be improved further.

(3) spacing fixed in a few places.

If Robert is ok with these changes, I think it could be applied.

-- 
Fabien.
В списке pgsql-hackers по дате отправления
От: Heikki Linnakangas
Дата:
От: Tomas Vondra
Дата:
FAQ