David Rowley wrote:
> I'm also just looking at you ERROR() macro, it seems that core code is
> quite careful not to use __VA_ARGS__ on compilers where HAVE__VA_ARGS is
> not defined. I'd say this needs to be fixed too. Have a look at the trick
> used in elog.h for when HAVE__VA_ARGS is not defined.
Hm, I just looked at the previous version which used ERROR rather than
LOCATE and LOCATION, and I liked that approach better. Can we get that
back? I understand that for the purposes of this patch it's easier to
not change existing fprintf()/exit() calls, though.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services