On Wednesday, January 26, 2022 9:43 AM I wrote:
> On Tuesday, January 25, 2022 1:55 PM Peter Smith <smithpb2250@gmail.com>
> wrote:
>
> Changed.
>
> Attach the V71 patch set which addressed the above comments.
> The patch also includes the changes:
> - Changed the function RelationBuildPublicationDesc's signature to be void
> and
> pass the PublicationDesc* from stack instead of palloc-ing it. [1]
> - Removed the Push/Pop ActiveSnapshot related code. IIRC, these functions
> are
> needed when we execute functions which will execute SQL(via SPI functions)
> to
> access the database. I think we don't need the ActiveSnapshot for now as we
> only support built-in immutable in the row filter which should only use the
> argument values passed to the function.
> - Adjusted some comments in pgoutput.c.
There was a miss in the posted patch which didn't initialize the parameter in
RelationBuildPublicationDesc, sorry for that. Attach the correct patch this time.
Best regards,
Hou zj