Обсуждение: iso-8859-1 annotation '-cim' in source code
Hi, Postgres hackers!
While reading the source code, I noticed comments like "
-cim 9/10/89". I think this might be an annotation by a developer to indicate the commit time, but from the commit history (using git), they does not seem to match.Specifically:
- What does “cim” mean here?
- Are these annotations still used in modern code practices within the PostgreSQL project, or have they been replaced by version control commit histories? I guess they are not used anymore as there are only 11 annotations in the source code.
I appreciate any information or historical context you can provide regarding these annotations.
Thank you!
Best regards, Steve Lau.
On Wed, Jul 3, 2024 at 8:46 PM Steve Lau <stevelauc@outlook.com> wrote:
While reading the source code, I noticed comments like "-cim 9/10/89". I think this might be an annotation by a developer to indicate the commit time, but from the commit history (using git), they does not seem to match.
It's the initials of the person who, back in 1989, wrote the preceding comments
* Note: most of these are "incomplete" because I didn't
* need the ones not defined. More should be added* only as necessary -cim 10/26/89
"I" == cim == ???
PostgreSQL inherited the code which is when our git history begins. This comment was part of the original source.
I do not know the full name of the person those initials refer to.
David J.
On Jul 4, 2024, at 12:16 PM, David G. Johnston <david.g.johnston@gmail.com> wrote:On Wed, Jul 3, 2024 at 8:46 PM Steve Lau <stevelauc@outlook.com> wrote:While reading the source code, I noticed comments like "-cim 9/10/89". I think this might be an annotation by a developer to indicate the commit time, but from the commit history (using git), they does not seem to match.It's the initials of the person who, back in 1989, wrote the preceding comments* Note: most of these are "incomplete" because I didn't* need the ones not defined. More should be added
* only as necessary -cim 10/26/89"I" == cim == ???PostgreSQL inherited the code which is when our git history begins. This comment was part of the original source.I do not know the full name of the person those initials refer to.David J.
Hi, thanks for the reply and that helpful information!
Best regards, Steve Lau.
"David G. Johnston" <david.g.johnston@gmail.com> writes:
> On Wed, Jul 3, 2024 at 8:46 PM Steve Lau <stevelauc@outlook.com> wrote:
>> While reading the source code, I noticed comments like "-cim 9/10/89".
> It's the initials of the person who, back in 1989, wrote the preceding
> comments
Right.
> PostgreSQL inherited the code which is when our git history begins. This
> comment was part of the original source.
We lack any source-code-control history before 1996, so there's no
way to be sure who wrote that, unless you can identify some Berkeley
Postgres person with those initials.
There are other cases in the code with other initials. The practice
fell out of favor among the open-source PG community in the late 90s,
possibly because Tom Lockhart and I share the same initials so it
became completely impossible to avoid confusion :-(. I think the
surviving "tgl" comments in the code are mostly his, but I've not
counted carefully.
regards, tom lane
On 2024-Jul-04, Tom Lane wrote: > "David G. Johnston" <david.g.johnston@gmail.com> writes: > > On Wed, Jul 3, 2024 at 8:46 PM Steve Lau <stevelauc@outlook.com> wrote: > >> While reading the source code, I noticed comments like "-cim 9/10/89". > > > It's the initials of the person who, back in 1989, wrote the preceding > > comments > > Right. > > > PostgreSQL inherited the code which is when our git history begins. This > > comment was part of the original source. > > We lack any source-code-control history before 1996, so there's no > way to be sure who wrote that, unless you can identify some Berkeley > Postgres person with those initials. Actually, somebody (thanks, Stas) set up a Github repo of the old history here: https://github.com/kelvich/postgres_pre95 There you can find commits like this https://github.com/kelvich/postgres_pre95/commit/0bf22e7dbb09b68b6e4c34dccc1440ebe98f8049 where tons of "- cim" comments were introduced. Unix account name was "cimarron". You can go on from there if you want, but why? -- Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/ "But static content is just dynamic content that isn't moving!" http://smylers.hates-software.com/2007/08/15/fe244d0c.html
On Jul 4, 2024, at 4:33 PM, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:On 2024-Jul-04, Tom Lane wrote:"David G. Johnston" <david.g.johnston@gmail.com> writes:On Wed, Jul 3, 2024 at 8:46 PM Steve Lau <stevelauc@outlook.com> wrote:While reading the source code, I noticed comments like "-cim 9/10/89".It's the initials of the person who, back in 1989, wrote the preceding
comments
Right.PostgreSQL inherited the code which is when our git history begins. This
comment was part of the original source.
We lack any source-code-control history before 1996, so there's no
way to be sure who wrote that, unless you can identify some Berkeley
Postgres person with those initials.
Actually, somebody (thanks, Stas) set up a Github repo of the old
history here:
https://github.com/kelvich/postgres_pre95
There you can find commits like this
https://github.com/kelvich/postgres_pre95/commit/0bf22e7dbb09b68b6e4c34dccc1440ebe98f8049
where tons of "- cim" comments were introduced. Unix account name was
"cimarron". You can go on from there if you want, but why?
--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
"But static content is just dynamic content that isn't moving!"
http://smylers.hates-software.com/2007/08/15/fe244d0c.html
Thanks for the reply from both you guys!
I really appreciate the link to that pre95 repo, and
> You can go on from there if you want, but why?
I would say I love history stories, but yeah, I agree that it does not mean too much nowadays.
Best regards, Steve Lau.
Alvaro Herrera <alvherre@alvh.no-ip.org> writes: > On 2024-Jul-04, Tom Lane wrote: > >> "David G. Johnston" <david.g.johnston@gmail.com> writes: >> > On Wed, Jul 3, 2024 at 8:46 PM Steve Lau <stevelauc@outlook.com> wrote: >> >> While reading the source code, I noticed comments like "-cim 9/10/89". >> >> > It's the initials of the person who, back in 1989, wrote the preceding >> > comments >> >> Right. >> >> > PostgreSQL inherited the code which is when our git history begins. This >> > comment was part of the original source. >> >> We lack any source-code-control history before 1996, so there's no >> way to be sure who wrote that, unless you can identify some Berkeley >> Postgres person with those initials. > > Actually, somebody (thanks, Stas) set up a Github repo of the old > history here: > https://github.com/kelvich/postgres_pre95 > There you can find commits like this > https://github.com/kelvich/postgres_pre95/commit/0bf22e7dbb09b68b6e4c34dccc1440ebe98f8049 > where tons of "- cim" comments were introduced. Unix account name was > "cimarron". You can go on from there if you want, but why? Searching for "cimarron postgres" returns https://en.wikipedia.org/wiki/Illustra, which mentions a Cimarron Taylor as one of Stonebraker's students, but I can't find anything else relevant in a few minutes of searching. - ilmari
> On 4 Jul 2024, at 14:13, Dagfinn Ilmari Mannsåker <ilmari@ilmari.org> wrote: > > Alvaro Herrera <alvherre@alvh.no-ip.org> writes: > >> On 2024-Jul-04, Tom Lane wrote: >> >>> "David G. Johnston" <david.g.johnston@gmail.com> writes: >>>> On Wed, Jul 3, 2024 at 8:46 PM Steve Lau <stevelauc@outlook.com> wrote: >>>>> While reading the source code, I noticed comments like "-cim 9/10/89". >>> >>>> It's the initials of the person who, back in 1989, wrote the preceding >>>> comments >>> >>> Right. >>> >>>> PostgreSQL inherited the code which is when our git history begins. This >>>> comment was part of the original source. >>> >>> We lack any source-code-control history before 1996, so there's no >>> way to be sure who wrote that, unless you can identify some Berkeley >>> Postgres person with those initials. >> >> Actually, somebody (thanks, Stas) set up a Github repo of the old >> history here: >> https://github.com/kelvich/postgres_pre95 >> There you can find commits like this >> https://github.com/kelvich/postgres_pre95/commit/0bf22e7dbb09b68b6e4c34dccc1440ebe98f8049 >> where tons of "- cim" comments were introduced. Unix account name was >> "cimarron". You can go on from there if you want, but why? > > Searching for "cimarron postgres" returns > https://en.wikipedia.org/wiki/Illustra, which mentions a Cimarron Taylor > as one of Stonebraker's students, but I can't find anything else > relevant in a few minutes of searching. That seems to match up. There is a Cimarron Taylor on LinkedIN who was "Programmer/Analyst" at U.C. Berkeley Database Research Group in January 1978 through January 1990. -- Daniel Gustafsson
On Thu, Jul 4, 2024 at 04:18:43PM +0200, Daniel Gustafsson wrote: > > Searching for "cimarron postgres" returns > > https://en.wikipedia.org/wiki/Illustra, which mentions a Cimarron Taylor > > as one of Stonebraker's students, but I can't find anything else > > relevant in a few minutes of searching. > > That seems to match up. There is a Cimarron Taylor on LinkedIN who was > "Programmer/Analyst" at U.C. Berkeley Database Research Group in January 1978 > through January 1990. And the Stonebraker video lists Cimarron Taylor as one of the 39 Berkely contributors: https://momjian.us/main/blogs/pgblog/2015.html#August_5_2015 https://www.youtube.com/watch?v=BbGeKi6T6QI&t=4269s -- Bruce Momjian <bruce@momjian.us> https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.