Обсуждение: Add tap test for --extra-float-digits option
Hi hackers! I added tap test code for pg_dump --extra-float-digits option because it hadn't tested it. There was no problem when writing test code and running TAP tests.
Вложения
On Thu, Jun 11, 2020 at 02:25:37PM +0900, Dong Wook Lee wrote: > Hi hackers! I added tap test code for pg_dump --extra-float-digits option > because it hadn't tested it. There was no problem when writing test code > and running TAP tests. If we go down to that (there is a test for --compression), what about --rows-per-insert? -- Michael
Вложения
Oh, now I understand. and I added a test of --row-per-insert option.
I'd better find more options missing test
2020년 6월 12일 (금) 오후 4:04, Michael Paquier <michael@paquier.xyz>님이 작성:
On Fri, Jun 12, 2020 at 02:30:35PM +0900, Dong Wook Lee wrote:
> Thank you for your response
> Do you mean to move it under the test of --compression option?
You could move the test where you see is best, and I would have done
that. My point is that we could have a test also for
--rows-per-insert as it deals with the same problem.
--
Michael
Вложения
On Fri, Jun 12, 2020 at 06:15:36PM +0900, Dong Wook Lee wrote: > Oh, now I understand. and I added a test of --row-per-insert option. That's more of an habit to look around, find similar patterns and the check if these are covered. I have applied your patch, and you may want to be careful about a couple of things: - Please avoid top-posting on the mailing lists: https://en.wikipedia.org/wiki/Posting_style#Top-posting Top-posting breaks the logic of a thread. - Your patch format is good. When sending a new version of the patch, it may be better to send things as a complete diff on the master branch (or the branch you are working on), instead of just sending one patch that applies on top of something you sent previously. Here for example your patch 0002 applied on top of 0001 that was sent at the top of the thread. We have also guidelines about patch submission: https://wiki.postgresql.org/wiki/Submitting_a_Patch Thanks! -- Michael
Вложения
> That's more of an habit to look around, find similar patterns and the > check if these are covered. > > I have applied your patch, and you may want to be careful about a > couple of things: > - Please avoid top-posting on the mailing lists: > https://en.wikipedia.org/wiki/Posting_style#Top-posting > Top-posting breaks the logic of a thread. > - Your patch format is good. When sending a new version of the patch, > it may be better to send things as a complete diff on the master > branch (or the branch you are working on), instead of just sending one > patch that applies on top of something you sent previously. Here for > example your patch 0002 applied on top of 0001 that was sent at the > top of the thread. We have also guidelines about patch submission: > https://wiki.postgresql.org/wiki/Submitting_a_Patch > > Thanks! > -- > Michael Hi Michael First of all, thank you for merging my patch. And I'm sorry, I should have been more careful about it. Next time I will follow format. And there is something I will tell you Would you mind if I ask you specify my author info with --author on the git commit? The new contributor can get involved in the PostgreSQL project. When they sent a patch and it was merged to the main repository, it'd be better to keep the author info on the git commit, IMHO. Because many opensource hackers who interested in PostgreSQL project can want to keep a record of author info on commits they wrote. Otherwise, contribution records can not be found by 'git shortlog -sn' and GitHub and OpenHub cannot track their opensource contribution records... So what about using --author for PostgreSQL contributors when merging their patches? like the Linux Kernel project https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8a16c09edc58982d56c49ab577fdcdf830fbc3a5 If so, many contributors would be highly encouraged. Thanks, Dong Wook
On Sat, Jun 13, 2020 at 06:34:46PM +0900, Dong Wook Lee wrote: > First of all, thank you for merging my patch. > And I'm sorry, I should have been more careful about it. Next time I > will follow format. And there is something I will tell you We are all here to learn. It is good to begin with small contributions to get a sense of how the project works, so I think that you are doing well. > Because many opensource hackers who interested in > PostgreSQL project can want to keep a record of author info > on commits they wrote. Otherwise, contribution records can not be found > by 'git shortlog -sn' and GitHub and OpenHub cannot track their > opensource contribution records... > > So what about using --author for PostgreSQL contributors > when merging their patches? like the Linux Kernel project That may be something to discuss with the project policy per-se. When it comes to credit people, committers list authors, reviewers, reporters, etc. directly in the commit log. And your name is mentioned in 64725728, I made sure of it. The latest discussions we had about the commit log format involved encouraging as much as possible the use of a "Discussion" tag in commit logs, the rest depends on each committer, and nobody uses --author. -- Michael