Обсуждение: [COMMITTERS] pgsql: Clean up overly paranoid checks in mac8.c

Clean up overly paranoid checks in mac8.c

Andres' compiler points out, quite correctly, that there's no need for
some of the overly paranoid checks which were put into mac8.c.  Remove
those, as they're useless, add some comments and make a few other minor
improvements- reduce the size of hexlookup by making it a char array
instead of an int array, and pass in the ptr location directly instead
of making hex2_to_uchar re-calculate the location based off the offset
every time.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/7821f7229c6e149046ee0dd8cab57928c4f86a37

Modified Files
--------------
src/backend/utils/adt/mac8.c | 42 +++++++++++++++++++++++++-----------------
1 file changed, 25 insertions(+), 17 deletions(-)

Stephen Frost <sfrost@snowman.net> writes:
> Clean up overly paranoid checks in mac8.c

termite thinks this wasn't quite right.

            regards, tom lane

* Tom Lane (tgl@sss.pgh.pa.us) wrote:
> Stephen Frost <sfrost@snowman.net> writes:
> > Clean up overly paranoid checks in mac8.c
>
> termite thinks this wasn't quite right.

Seems to be that termite's char is unsigned, will be fixing in a moment.

Thanks!

Stephen

I wrote:
> Stephen Frost <sfrost@snowman.net> writes:
>> Clean up overly paranoid checks in mac8.c

> termite thinks this wasn't quite right.

On looking at it a bit more closely, I think you've forgotten that
"char" is signed on some platforms and unsigned on others.  I'd
suggest putting explicit casts to unsigned char into these tests.

            regards, tom lane

* Tom Lane (tgl@sss.pgh.pa.us) wrote:
> I wrote:
> > Stephen Frost <sfrost@snowman.net> writes:
> >> Clean up overly paranoid checks in mac8.c
>
> > termite thinks this wasn't quite right.
>
> On looking at it a bit more closely, I think you've forgotten that
> "char" is signed on some platforms and unsigned on others.  I'd
> suggest putting explicit casts to unsigned char into these tests.

Right, going through it now and adjusting things to be more careful
about that.

Thanks!

Stephen