Re: [COMMITTERS] pgsql: Clean up overly paranoid checks in mac8.c

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: [COMMITTERS] pgsql: Clean up overly paranoid checks in mac8.c
Дата
Msg-id 20683.1489635496@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: [COMMITTERS] pgsql: Clean up overly paranoid checks in mac8.c  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: [COMMITTERS] pgsql: Clean up overly paranoid checks in mac8.c  (Stephen Frost <sfrost@snowman.net>)
Список pgsql-committers
Дерево обсуждения 
I wrote:
> Stephen Frost <sfrost@snowman.net> writes:
>> Clean up overly paranoid checks in mac8.c

> termite thinks this wasn't quite right.

On looking at it a bit more closely, I think you've forgotten that
"char" is signed on some platforms and unsigned on others.  I'd
suggest putting explicit casts to unsigned char into these tests.

            regards, tom lane

В списке pgsql-committers по дате отправления:

Предыдущее
От: Stephen Frost
Дата:
Сообщение: Re: [COMMITTERS] pgsql: Clean up overly paranoid checks in mac8.c
Следующее
От: Stephen Frost
Дата:
Сообщение: Re: [COMMITTERS] pgsql: Clean up overly paranoid checks in mac8.c