Re: [COMMITTERS] pgsql: Clean up overly paranoid checks in mac8.c

Поиск
Список
Период
Сортировка
От Stephen Frost
Тема Re: [COMMITTERS] pgsql: Clean up overly paranoid checks in mac8.c
Дата
Msg-id 20170316033949.GI9812@tamriel.snowman.net
обсуждение исходный текст
Ответ на Re: [COMMITTERS] pgsql: Clean up overly paranoid checks in mac8.c  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-committers
Дерево обсуждения 
* Tom Lane (tgl@sss.pgh.pa.us) wrote:
> I wrote:
> > Stephen Frost <sfrost@snowman.net> writes:
> >> Clean up overly paranoid checks in mac8.c
>
> > termite thinks this wasn't quite right.
>
> On looking at it a bit more closely, I think you've forgotten that
> "char" is signed on some platforms and unsigned on others.  I'd
> suggest putting explicit casts to unsigned char into these tests.

Right, going through it now and adjusting things to be more careful
about that.

Thanks!

Stephen
Вложения

В списке pgsql-committers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: [COMMITTERS] pgsql: Clean up overly paranoid checks in mac8.c
Следующее
От: Stephen Frost
Дата:
Сообщение: [COMMITTERS] pgsql: Be more careful about signed vs. unsigned char