Обсуждение: pg_standby for 8.2 (with last restart point)

Hi all,<br /><br />    For PG versions < 8.3 (specifically 8.2) I wanted the %r parameter to be substituted by the
lastrestart point, just as the recovery code does in > 8.3. I assumed there would be objections to it (else it would
havealready been there in 8.2.x), so started looking for workarounds. After a few ideas, I settled with using the
outputof pg_controldata.<br /><br />    Here's what I have done: I execute pg_controldata and parse it's output to
extractthe same information as xlog.c provides for %r in versions > 8.3. Then I rebuild the XLog filename, just like
xlog.c,and emit it from the script. All this is done in a perl script (at the end of this mail).<br /><br />    My next
stepis: use this script in the restore_command to provide the %r parameter to pg_standby, like so:<br /><br
/>restore_command= 'pg_standby -c -d -s 5 -w 0 -t /tmp/pg_standby.trigger.5433 ../wal_archive/ %f %p `perl
/home/gurjeet/dev/last_restart_point.pl`2>> pg_standby.log'<br /><br />    I have tested this script using the
followingrestore_command, on a HEAD version:<br /><br />restore_command = 'echo before `perl
/home/gurjeet/dev/last_restart_point.pl`>> pg_standby.log && pg_standby -c -d -s 5 -w 0 -t
/tmp/pg_standby.trigger.5433../wal_archive/ %f %p %r 2>> pg_standby.log && echo after `perl
/home/gurjeet/dev/last_restart_point.pl`>> pg_standby.log'<br /><br />    Using the above restore_command, I can
seethat my script is able to detect the change in the restart point (%r) just as soon as the server updates it. Here's
asnippet:<br /><br /><snip><br />...<br />Keep archive history    : 000000010000000100000021 and later<br />
runningrestore     : OK<br />after 000000010000000100000021<br />before 000000010000000100000045<br /><br />Trigger
file       : /tmp/pg_standby.trigger.5433<br />Waiting for WAL file    : 000000010000000100000047<br />WAL file
path      : ../wal_archive//000000010000000100000047<br /> Restoring to...     : pg_xlog/RECOVERYXLOG<br />Sleep
interval     : 5 seconds<br />Max wait interval   : 0 forever<br />Command for restore : cp
"../wal_archive//000000010000000100000047""pg_xlog/RECOVERYXLOG"<br /> Keep archive history    :
000000010000000100000045and later<br />running restore     : OK<br />removing
"../wal_archive//000000010000000100000025"<br/>removing "../wal_archive//00000001000000010000002D"<br /> removing
"../wal_archive//000000010000000100000031"<br/>...<br /><./snip><br /><br /><br />    So, is this a safe way of
extractingthe last restart point for PG < 8.3? Or would it be possible to make PG<8.3 provide this %r through
somepatch?<br /><br />Best regards,<br />Gurjeet.<br /><br />Here's the perl script:<br /><br /><script><br />my
@text= `pg_controldata .`; # here . represents the PGDATA, since the server is executing here.<br />my $line;<br /><br
/>my$time_line_id;<br /> my $redo_log_id;<br />my $redo_rec_off;<br />my $wal_seg_bytes;<br />my $redo_log_seg;<br
/><br/>foreach $line ( @text )<br />{<br />    $line = mychomp( $line );<br /><br />    if( $line =~ m/Latest
checkpoint'sTimeLineID:\s*(([0-9])+)/ )<br />     {<br />        # decimal number<br />        $time_line_id = 0 +
$1;<br/>    }<br />    if( $line =~ m/Latest checkpoint's REDO location:\s*(([0-9]|[A-F])+)\/(([0-9]|[A-F])+)/ )<br
/>   {<br />        # hexadecimal numbers<br />         $redo_log_id = $1;<br />        $redo_rec_off = $3;<br />   
}<br/><br />    if( $line =~ m/Bytes per WAL segment:\s*([0-9]+)/ )<br />    {<br />        # decimal number<br
/>       $wal_seg_bytes = $1;<br />    }<br />}<br /><br />$redo_log_seg = sprintf( "%d", hex( $redo_rec_off ) /
$wal_seg_bytes);<br /><br />print "" . sprintf( "%08X%08X%08X", $time_line_id, $redo_log_id, $redo_log_seg ) . "\n";<br
/><br/># Wrapper around Perl's chomp function<br />sub mychomp<br />{<br />    my ( $tmp ) = @_;<br />     chomp( $tmp
);<br/>    return $tmp;<br />}<br /><br /></script><br /><br /><br />-- <br />gurjeet[.singh]@EnterpriseDB.com<br
/>singh.gurjeet@{gmail | hotmail | indiatimes | yahoo }.com<br /><br />EnterpriseDB <a
href="http://www.enterprisedb.com">http://www.enterprisedb.com</a><br/><br />Mail sent from my BlackLaptop device  

On Fri, 28 Mar 2008, Gurjeet Singh wrote:

> For PG versions < 8.3 (specifically 8.2) I wanted the %r parameter to be 
> substituted by the last restart point, just as the recovery code does in 
> > 8.3. I assumed there would be objections to it (else it would have 
> already been there in 8.2.x)

The idea to add this feature didn't show up before 8.2 was released, it 
came up during the 8.3 development cycle.  This project doesn't make 
functional changes to stable releases, that's the reason why 8.2 will 
never get patched to add the %r feature.

Cute script though.  I know people have asked about simulating this 
behavior, and I don't recall a good sample solution being presented before 
yours.

--
* Greg Smith gsmith@gregsmith.com http://www.gregsmith.com Baltimore, MD

On Fri, Mar 28, 2008 at 3:56 AM, Greg Smith <gsmith@gregsmith.com> wrote:
--
gurjeet[.singh]@EnterpriseDB.com
singh.gurjeet@{ gmail | hotmail | indiatimes | yahoo }.com

EnterpriseDB      http://www.enterprisedb.com

Mail sent from my BlackLaptop device

On Fri, 28 Mar 2008, Gurjeet Singh wrote:

>> This project doesn't make functional changes to stable releases, that's 
>> the reason why 8.2 will never get patched to add the %r feature.
> I completely understand that, but still was hoping that we'd change that.

Well, then you really don't understand this at all then, so let's work on 
that for a bit.  http://www.postgresql.org/support/versioning is the 
official statement, perhaps some examples will help clarify where and why 
the line is where it is.

One of the first patches I ever submitted made a minor change to a contrib 
utility used solely for benchmarking (pgbench) that added a useful 
feature, only if you passed it the right parameter.  That was considered 
for a tiny bit before being rejected as a feature change too large to put 
into a stable branch.

That was a small change in a utility that should never be run on a 
production system.  You're trying to get a change made to the code path 
people rely on for their *backups*.  Good luck with that.

The parable I enjoy pulling out in support of this policy is MySQL bug 
#31001:

http://www.mysqlperformanceblog.com/2007/10/04/mysql-quality-of-old-and-new-features/

where they added a seemingly minor optimization to something and 
accidentally broke the ability to sort in some cases.  There's always a 
small risk that comes with any code change, and this is why you don't ever 
touch working production code unless you're fixing a bug that's more 
troublesome than that risk.

--
* Greg Smith gsmith@gregsmith.com http://www.gregsmith.com Baltimore, MD

Greg Smith <gsmith@gregsmith.com> writes:
> ... That was a small change in a utility that should never be run on a 
> production system.  You're trying to get a change made to the code path 
> people rely on for their *backups*.  Good luck with that.

While I quite agree with Greg's comments about not changing stable
release branches unnecessarily, it seems that there's another
consideration in this case.  If we don't back-patch %r then users
will have to rely on hacky scripts like the one posted upthread.
Is that really a net gain in reliability?

(I'm honestly not sure of the answer; I'm just thinking it might
be open to debate.  In particular I don't remember how complicated
the patch to add %r was.)
        regards, tom lane

On Fri, Mar 28, 2008 at 9:47 AM, Greg Smith <gsmith@gregsmith.com> wrote:

Point well taken. And when I said 'I completely understand that', I meant I understood Postgres' policy for patching older releases. And thanks for the links; it feels good to know that there's an "official" stand on this topic in Postgres, rather than 'no known serious bugs'. :)

I am still looking for comments on the correctness of this script and above mentioned procedure for running it on an 8.2.x release.

Thanks and best regards,
--
gurjeet[.singh]@EnterpriseDB.com
singh.gurjeet@{ gmail | hotmail | indiatimes | yahoo }.com

EnterpriseDB http://www.enterprisedb.com

Mail sent from my BlackLaptop device

On Fri, 28 Mar 2008, Tom Lane wrote:

> While I quite agree with Greg's comments about not changing stable
> release branches unnecessarily, it seems that there's another
> consideration in this case.

I was just trying to set Gurjeet's expectations appropriately while taking 
the suggestion seriously anyway.  This is one of those cases where you 
could argue that since there is no good way to find out what to do here, 
it's an operational bug serious enough to patch.

> In particular I don't remember how complicated the patch to add %r was

Unfortunately it was mixed in with the archive_mode GUC and 
log_startpoints changes so the diff is more complicated than just that: 
http://repo.or.cz/w/PostgreSQL.git?a=commit;h=a14266760bd403abd38be499de1619a825e0438b

A quick glance suggests this part might only be 14 lines added to xlog.c 
though (the 11 lines starting with "case 'r'" and the 3 new variable 
definitions just above it that uses).

--
* Greg Smith gsmith@gregsmith.com http://www.gregsmith.com Baltimore, MD

On Fri, 2008-03-28 at 00:54 -0400, Tom Lane wrote:
> Greg Smith <gsmith@gregsmith.com> writes:
> > ... That was a small change in a utility that should never be run on a
> > production system.  You're trying to get a change made to the code path
> > people rely on for their *backups*.  Good luck with that.
>
> While I quite agree with Greg's comments about not changing stable
> release branches unnecessarily, it seems that there's another
> consideration in this case.  If we don't back-patch %r then users
> will have to rely on hacky scripts like the one posted upthread.
> Is that really a net gain in reliability?
>
> (I'm honestly not sure of the answer; I'm just thinking it might
> be open to debate.  In particular I don't remember how complicated
> the patch to add %r was.)

Here's the original patch, edited to remove pg_standby changes.

I've not even checked whether it will apply, but it seems fairly simple.

Gurjeet, would you like to freshen and test that up for apply to 8.2?

--
  Simon Riggs
  2ndQuadrant  http://www.2ndQuadrant.com

  PostgreSQL UK 2008 Conference: http://www.postgresql.org.uk

On Fri, Mar 28, 2008 at 10:30 AM, Gurjeet Singh <<a
href="mailto:singh.gurjeet@gmail.com">singh.gurjeet@gmail.com</a>>wrote:<br /><div class="gmail_quote"><blockquote
class="gmail_quote"style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br
/>Iam still looking for comments on the correctness of this script and above mentioned procedure for running it on an
8.2.xrelease.<br /></blockquote></div><br />Well, I came across a serious bug in the script. Here's the corrected
versionof the perl script for anyone who might have picked up the script from here:<br /><br />(Am still looking for
anyfeedback on the correctness of the script; especially in the light of the recent possible bugs fixed on the server
side,related to recovery)<br /><br /><span style="font-family: courier new,monospace;"><script></span><br
style="font-family:courier new,monospace;" /><span style="font-family: courier new,monospace;">my @text = `</span><span
class="nfakPe"style="font-family: courier new,monospace;">pg_controldata</span><span style="font-family: courier
new,monospace;">.`; # here . represents the PGDATA, since the server is executing here.</span><br style="font-family:
couriernew,monospace;" /><span style="font-family: courier new,monospace;">my $line;</span><br style="font-family:
couriernew,monospace;" /><br style="font-family: courier new,monospace;" /><span style="font-family: courier
new,monospace;">my$time_line_id;</span><br style="font-family: courier new,monospace;" /><span style="font-family:
couriernew,monospace;"> my $redo_log_id;</span><br style="font-family: courier new,monospace;" /><span
style="font-family:courier new,monospace;">my $redo_rec_off;</span><br style="font-family: courier new,monospace;"
/><spanstyle="font-family: courier new,monospace;">my $wal_seg_bytes;</span><br style="font-family: courier
new,monospace;"/><span style="font-family: courier new,monospace;">my $redo_log_seg;</span><br style="font-family:
couriernew,monospace;" /><br style="font-family: courier new,monospace;" /><span style="font-family: courier
new,monospace;">foreach$line ( @text )</span><br style="font-family: courier new,monospace;" /><span
style="font-family:courier new,monospace;">{</span><br style="font-family: courier new,monospace;" /><span
style="font-family:courier new,monospace;">    $line = mychomp( $line );</span><br style="font-family: courier
new,monospace;"/><br style="font-family: courier new,monospace;" /><span style="font-family: courier
new,monospace;">   if( $line =~ m/Latest checkpoint's TimeLineID:\s*(([0-9])+)/ )</span><br style="font-family: courier
new,monospace;"/><span style="font-family: courier new,monospace;">     {</span><br style="font-family: courier
new,monospace;"/><span style="font-family: courier new,monospace;">        # decimal number</span><br
style="font-family:courier new,monospace;" /><span style="font-family: courier new,monospace;">        $time_line_id =
0+ $1;</span><br style="font-family: courier new,monospace;" /><span style="font-family: courier new,monospace;">   
}</span><brstyle="font-family: courier new,monospace;" /><span style="font-family: courier new,monospace;">    if(
$line=~ m/Latest checkpoint's REDO location:\s*(([0-9]|[A-F])+)\/</span><span style="font-family: courier
new,monospace;">(([0-9]|[A-F])+)/)</span><br style="font-family: courier new,monospace;" /><div class="ArwC7c ckChnd"
id="1fzd"><spanstyle="font-family: courier new,monospace;">    {</span><br style="font-family: courier new,monospace;"
/><spanstyle="font-family: courier new,monospace;">        # hexadecimal numbers</span><br style="font-family: courier
new,monospace;"/><span style="font-family: courier new,monospace;">         $redo_log_id = hex( $1 );</span><br
style="font-family:courier new,monospace;" /><span style="font-family: courier new,monospace;">        $redo_rec_off =
hex($3 );</span><br style="font-family: courier new,monospace;" /><span style="font-family: courier new,monospace;">   
}</span><brstyle="font-family: courier new,monospace;" /><br style="font-family: courier new,monospace;" /><span
style="font-family:courier new,monospace;">    if( $line =~ m/Bytes per WAL segment:\s*([0-9]+)/ )</span><br
style="font-family:courier new,monospace;" /><span style="font-family: courier new,monospace;">    {</span><br
style="font-family:courier new,monospace;" /><span style="font-family: courier new,monospace;">        # decimal
number</span><brstyle="font-family: courier new,monospace;" /><span style="font-family: courier new,monospace;">       
$wal_seg_bytes= $1;</span><br style="font-family: courier new,monospace;" /><span style="font-family: courier
new,monospace;">   }</span><br style="font-family: courier new,monospace;" /><span style="font-family: courier
new,monospace;">}</span><brstyle="font-family: courier new,monospace;" /><br style="font-family: courier
new,monospace;"/><span style="font-family: courier new,monospace;">$redo_log_seg = sprintf( "%d", $redo_rec_off /
$wal_seg_bytes);</span><br style="font-family: courier new,monospace;" /><br style="font-family: courier
new,monospace;"/><span style="font-family: courier new,monospace;">print "" . sprintf( "%08X%08X%08X", $time_line_id,
$redo_log_id,$redo_log_seg ) . "\n";</span><br style="font-family: courier new,monospace;" /><br style="font-family:
couriernew,monospace;" /><span style="font-family: courier new,monospace;"># Wrapper around Perl's chomp
function</span><brstyle="font-family: courier new,monospace;" /><span style="font-family: courier new,monospace;">sub
mychomp</span><brstyle="font-family: courier new,monospace;" /><span style="font-family: courier
new,monospace;">{</span><brstyle="font-family: courier new,monospace;" /><span style="font-family: courier
new,monospace;">   my ( $tmp ) = @_;</span><br style="font-family: courier new,monospace;" /><span style="font-family:
couriernew,monospace;">     chomp( $tmp );</span><br style="font-family: courier new,monospace;" /><span
style="font-family:courier new,monospace;">    return $tmp;</span><br style="font-family: courier new,monospace;"
/><spanstyle="font-family: courier new,monospace;">}</span><br style="font-family: courier new,monospace;" /><br
style="font-family:courier new,monospace;" /><span style="font-family: courier
new,monospace;"></script></span><brstyle="font-family: courier new,monospace;" /><font color="#888888"><br
/></font></div><brclear="all" /><br />-- <br />gurjeet[.singh]@EnterpriseDB.com<br />singh.gurjeet@{ gmail | hotmail |
indiatimes| yahoo }.com<br /><br />EnterpriseDB <a
href="http://www.enterprisedb.com">http://www.enterprisedb.com</a><br/><br />Mail sent from my BlackLaptop device