Обсуждение: Re: [COMMITTERS] pgsql: Enable probes to work with Mac OS X Leopard and other OSes that

On Mon, Mar 17, 2008 at 7:44 PM, Peter Eisentraut <petere@postgresql.org> wrote:
> Log Message:
>  -----------
>  Enable probes to work with Mac OS X Leopard and other OSes that will
>  support DTrace in the future.
>
>  Switch from using DTRACE_PROBEn macros to the dynamically generated macros.
>  Use "dtrace -h" to create a header file that contains the dynamically
>  generated macros to be used in the source code instead of the DTRACE_PROBEn
>  macros.  A dummy header file is generated for builds without DTrace support.

Do we need some support in the buildfarm to create the header file?

-- 
Dave Page
EnterpriseDB UK Ltd: http://www.enterprisedb.com
PostgreSQL UK 2008 Conference: http://www.postgresql.org.uk

Am Dienstag, 18. März 2008 schrieb Dave Page:
> On Mon, Mar 17, 2008 at 7:44 PM, Peter Eisentraut <petere@postgresql.org> 
wrote:
> > Log Message:
> >  -----------
> >  Enable probes to work with Mac OS X Leopard and other OSes that will
> >  support DTrace in the future.
> >
> >  Switch from using DTRACE_PROBEn macros to the dynamically generated
> > macros. Use "dtrace -h" to create a header file that contains the
> > dynamically generated macros to be used in the source code instead of the
> > DTRACE_PROBEn macros.  A dummy header file is generated for builds
> > without DTrace support.
>
> Do we need some support in the buildfarm to create the header file?

The Windows/MSVC build system needs some adjustments.  I have no idea how it 
works, but I'd be glad to explain the details to someone who does.

On Tue, Mar 18, 2008 at 9:40 AM, Peter Eisentraut <peter_e@gmx.net> wrote:
>  >
>  > Do we need some support in the buildfarm to create the header file?
>
>  The Windows/MSVC build system needs some adjustments.  I have no idea how it
>  works, but I'd be glad to explain the details to someone who does.

I was actually thinking of the OS X buildfarm member I setup to
exercise this. From your description it sounded like we need to
generate the probe header manually if we enable dtrace.

I'm sure Magnus would love to hear the details for the MSVC perl scipts :-p


-- 
Dave Page
EnterpriseDB UK Ltd: http://www.enterprisedb.com
PostgreSQL UK 2008 Conference: http://www.postgresql.org.uk

On Tue, Mar 18, 2008 at 11:48 AM, Peter Eisentraut <peter_e@gmx.net> wrote:
> Am Dienstag, 18. März 2008 schrieb Dave Page:
>
> > I was actually thinking of the OS X buildfarm member I setup to
>  > exercise this. From your description it sounded like we need to
>  > generate the probe header manually if we enable dtrace.
>
>  Nope.

OK, I'll enable it on antelope then.

Shouldn't there have been a doc patch with this as well? Last time I
read the docs they said only Solaris supports dtrace.


--
Dave Page
EnterpriseDB UK Ltd: http://www.enterprisedb.com
PostgreSQL UK 2008 Conference: http://www.postgresql.org.uk

Am Dienstag, 18. März 2008 schrieb Dave Page:
> I was actually thinking of the OS X buildfarm member I setup to
> exercise this. From your description it sounded like we need to
> generate the probe header manually if we enable dtrace.

Nope.

Dave Page wrote:

> Shouldn't there have been a doc patch with this as well? Last time I
> read the docs they said only Solaris supports dtrace.

Well, it won't support anything else until somebody tries debugs it ;-)

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

Alvaro Herrera <alvherre@commandprompt.com> writes:
> Dave Page wrote:
>> Shouldn't there have been a doc patch with this as well? Last time I
>> read the docs they said only Solaris supports dtrace.

> Well, it won't support anything else until somebody tries debugs it ;-)

Well, I've got Leopard here, I'd be happy to test it ... but the patch
has rendered 
http://developer.postgresql.org/pgdocs/postgres/dynamic-trace.html
into a pack of lies quite independently of which OSes are supported,
so I'm not very sure what to do.
        regards, tom lane

Am Dienstag, 18. März 2008 schrieb Tom Lane:
> Well, I've got Leopard here, I'd be happy to test it ... but the patch
> has rendered
> http://developer.postgresql.org/pgdocs/postgres/dynamic-trace.html
> into a pack of lies quite independently of which OSes are supported,
> so I'm not very sure what to do.

Ah yes.  Robert, do you think you could update the documentation a bit on how 
to use the tracing?

Peter Eisentraut wrote:
> Am Dienstag, 18. März 2008 schrieb Tom Lane:
>   
>> Well, I've got Leopard here, I'd be happy to test it ... but the patch
>> has rendered
>> http://developer.postgresql.org/pgdocs/postgres/dynamic-trace.html
>> into a pack of lies quite independently of which OSes are supported,
>> so I'm not very sure what to do.
>>     
>
> Ah yes.  Robert, do you think you could update the documentation a bit on how 
> to use the tracing?
>
>   
Yes, the doc needs to be updated. Will submit a patch soon!

Regards,
-Robert