Обсуждение: regress/results directory problem
I was getting CVS errors because regress/GNUmakefile does an 'rm -rf results', removing the CVS directory from results. This was causing my 'cvs update's to fail. My fix was to change 'rm -rf results' to 'rm -f results/*.out'. Does anyone know when this problem was added. I don't see any significant changes in GNUmakefile. -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000+ If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania19026
pgman wrote: > I was getting CVS errors because regress/GNUmakefile does an 'rm -rf > results', removing the CVS directory from results. This was causing my > 'cvs update's to fail. My fix was to change 'rm -rf results' to 'rm -f > results/*.out'. > > Does anyone know when this problem was added. I don't see any > significant changes in GNUmakefile. OK, I found the problem. I do a 'cvs update' as: cvs update -P -d pgsql The -d brings in any directories that may have been created since the last checkout. That is causing problems when the regress/results directory has been deleted and recreated. I am backing out my GNUmakefile change. I am still unclear why this has started happening all of a sudden. -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000+ If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania19026
Bruce Momjian <pgman@candle.pha.pa.us> writes:
>> Does anyone know when this problem was added. I don't see any
>> significant changes in GNUmakefile.
AFAICT, the results directory hasn't been touched in 21 months.
Are you sure you haven't changed your own CVS setup or arguments?
> The -d brings in any directories that may have been created since the
> last checkout. That is causing problems when the regress/results
> directory has been deleted and recreated.
I use cvs update -d -P myself, and I do *not* see it creating the
results directory.
regards, tom lane
...
> I am backing out my GNUmakefile change. I am still unclear why this has
> started happening all of a sudden.
?
The results/ directory should not be a part of CVS (since it is assumed
to not exist by the regression tests). But it has been in CVS since 1997
during a period of time when a Makefile in that directory was
responsible for cleaning the directory.
We are relying on the pruning capabilities of CVS and so never really
notice that this was the case (I use -Pd almost always too).
I doubt anything has changed recently in this regard.
- Thomas
Tom Lane wrote: > Bruce Momjian <pgman@candle.pha.pa.us> writes: > >> Does anyone know when this problem was added. I don't see any > >> significant changes in GNUmakefile. > > AFAICT, the results directory hasn't been touched in 21 months. > Are you sure you haven't changed your own CVS setup or arguments? I looked at that. My cvs hasn't changed, my OS hasn't changed. I deleted my entire tree and did another checkout, but that didn't help. > > The -d brings in any directories that may have been created since the > > last checkout. That is causing problems when the regress/results > > directory has been deleted and recreated. > > I use cvs update -d -P myself, and I do *not* see it creating the > results directory. The problem is that if the results directory exists, the update fails because there is no /CVS directory in there. Here is a sample session. At the start regress/results does not exist: --------------------------------------------------------------------------- $ cvs update -d -P pgsql ? pgsql/config.log ... $ cd /pg/test/regress/ $ mkdir results $ cd - /pgcvs $ cvs update -d -P pgsql ? pgsql/config.log ... ? pgsql/src/test/regress/results cvs update: in directory pgsql/src/test/regress/results: cvs update: cannot open CVS/Entries for reading: No such file or directory --------------------------------------------------------------------------- It seems to be failing because there is no CVS directory in results. This is CVS: Concurrent Versions System (CVS) 1.10.3 (client/server) -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000+ If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania19026
Bruce Momjian <pgman@candle.pha.pa.us> writes:
>> I use cvs update -d -P myself, and I do *not* see it creating the
>> results directory.
> The problem is that if the results directory exists, the update fails
> because there is no /CVS directory in there.
Ah. I always do a 'make distclean' before I risk a whole-tree update...
regards, tom lane
Marc has removed the regress/results directory from CVS. --------------------------------------------------------------------------- Thomas Lockhart wrote: > ... > > I am backing out my GNUmakefile change. I am still unclear why this has > > started happening all of a sudden. > > ? > > The results/ directory should not be a part of CVS (since it is assumed > to not exist by the regression tests). But it has been in CVS since 1997 > during a period of time when a Makefile in that directory was > responsible for cleaning the directory. > > We are relying on the pruning capabilities of CVS and so never really > notice that this was the case (I use -Pd almost always too). > > I doubt anything has changed recently in this regard. > > - Thomas > > > > ---------------------------(end of broadcast)--------------------------- > TIP 4: Don't 'kill -9' the postmaster > > > -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000+ If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania19026
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> Marc has removed the regress/results directory from CVS.
Uh ... say it ain't so, Joe!
regress/results/Makefile was part of several releases. If you
really did that, then it is no longer possible to extract the state
of some past releases from CVS.
This cure is way worse than the disease.
regards, tom lane