Обсуждение: dev 1.15, wxw 2.9.3 - index column name truncated by 1 char
Guillaume, I see the missing column name in index-properties has been fixed. Thanks. However the column name appears to be truncated one char too early; bookid becomes booki and authid becomes authi. Seems to be consistent across databases. -- --- Colin Beckingham 613-454-5369 http://www.it4gh.com
On 04/11/2012 04:38 PM, Colin Beckingham wrote: > Guillaume, I see the missing column name in index-properties has been > fixed. Thanks. > > However the column name appears to be truncated one char too early; > bookid becomes booki and authid becomes authi. Seems to be consistent > across databases. I am confusing Constraints and Indexes again. The column name is still missing from _Constraints_, the name is present in _Indexes_ but truncated 1 char. Colin Beckingham
On Wed, 2012-04-11 at 17:13 -0400, Colin Beckingham wrote: > > On 04/11/2012 04:38 PM, Colin Beckingham wrote: > > Guillaume, I see the missing column name in index-properties has been > > fixed. Thanks. > > > > However the column name appears to be truncated one char too early; > > bookid becomes booki and authid becomes authi. Seems to be consistent > > across databases. > > I am confusing Constraints and Indexes again. The column name is still > missing from _Constraints_, the name is present in _Indexes_ but > truncated 1 char. > 'k. Actually, as far as I can tell, it also happens with wxWidgets 2.8. It also happens on 1.14. I'm working on it. -- Guillaume http://blog.guillaume.lelarge.info http://www.dalibo.com
Hi Colin, On Fri, 2012-04-20 at 13:15 +0200, Guillaume Lelarge wrote: > On Wed, 2012-04-11 at 17:13 -0400, Colin Beckingham wrote: > > > > On 04/11/2012 04:38 PM, Colin Beckingham wrote: > > > Guillaume, I see the missing column name in index-properties has been > > > fixed. Thanks. > > > > > > However the column name appears to be truncated one char too early; > > > bookid becomes booki and authid becomes authi. Seems to be consistent > > > across databases. > > > > I am confusing Constraints and Indexes again. The column name is still > > missing from _Constraints_, the name is present in _Indexes_ but > > truncated 1 char. > > > > 'k. Actually, as far as I can tell, it also happens with wxWidgets 2.8. > It also happens on 1.14. I'm working on it. > Can you try the attached patch, please? -- Guillaume http://blog.guillaume.lelarge.info http://www.dalibo.com
Вложения
On 04/20/2012 07:58 AM, Guillaume Lelarge wrote: > Hi Colin, > > On Fri, 2012-04-20 at 13:15 +0200, Guillaume Lelarge wrote: >> On Wed, 2012-04-11 at 17:13 -0400, Colin Beckingham wrote: >>> >>> On 04/11/2012 04:38 PM, Colin Beckingham wrote: >>>> Guillaume, I see the missing column name in index-properties has been >>>> fixed. Thanks. >>>> >>>> However the column name appears to be truncated one char too early; >>>> bookid becomes booki and authid becomes authi. Seems to be consistent >>>> across databases. >>> >>> I am confusing Constraints and Indexes again. The column name is still >>> missing from _Constraints_, the name is present in _Indexes_ but >>> truncated 1 char. >>> >> >> 'k. Actually, as far as I can tell, it also happens with wxWidgets 2.8. >> It also happens on 1.14. I'm working on it. >> > > Can you try the attached patch, please? The patch works in that it fixes some indicated problems: in constraints, the field name now appears under columns, and in indexes the name of the indexed field is fully named. Some issues which may remain: 1. in indexes, the other detail for a field, (sort type, treatment of nulls etc), is indicated alongside the field name but in constraints this detail is present in grey in the text but missing from the table 2. in both constraints and indexes, neither the add nor remove buttons activate, neither do any of the field selector and other dropdowns, this may of course be deliberate if they should not be changed in this context, however say you want to change an index from indexing a single field to indexing multiple fields, or change from asc to desc? 3. the new dialog box is not modal. I can go to the parent window and change from one index or constraint to another, I think this could lead to confusion since the child dialog does not change to suit the selection in the parent. -- --- Colin Beckingham 613-454-5369 http://www.it4gh.com
On Fri, 2012-04-20 at 10:25 -0400, Colin Beckingham wrote: > > On 04/20/2012 07:58 AM, Guillaume Lelarge wrote: > > Hi Colin, > > > > On Fri, 2012-04-20 at 13:15 +0200, Guillaume Lelarge wrote: > >> On Wed, 2012-04-11 at 17:13 -0400, Colin Beckingham wrote: > >>> > >>> On 04/11/2012 04:38 PM, Colin Beckingham wrote: > >>>> Guillaume, I see the missing column name in index-properties has been > >>>> fixed. Thanks. > >>>> > >>>> However the column name appears to be truncated one char too early; > >>>> bookid becomes booki and authid becomes authi. Seems to be consistent > >>>> across databases. > >>> > >>> I am confusing Constraints and Indexes again. The column name is still > >>> missing from _Constraints_, the name is present in _Indexes_ but > >>> truncated 1 char. > >>> > >> > >> 'k. Actually, as far as I can tell, it also happens with wxWidgets 2.8. > >> It also happens on 1.14. I'm working on it. > >> > > > > Can you try the attached patch, please? > > The patch works in that it fixes some indicated problems: in > constraints, the field name now appears under columns, and in indexes > the name of the indexed field is fully named. > > Some issues which may remain: > 1. in indexes, the other detail for a field, (sort type, treatment of > nulls etc), is indicated alongside the field name but in constraints > this detail is present in grey in the text but missing from the table So I looked into this this afternoon and I found many disappointing things. Meaning there are still a few bugs to fix :-/ (for example don't try to use a column name with space in it in an index...) > 2. in both constraints and indexes, neither the add nor remove buttons > activate, neither do any of the field selector and other dropdowns, this > may of course be deliberate if they should not be changed in this > context, however say you want to change an index from indexing a single > field to indexing multiple fields, or change from asc to desc? PostgreSQL doesn't allow that, so pgAdmin doesn't allow it either. You can change an index's name, its tablespace, and storage parameters. That's all. > 3. the new dialog box is not modal. I can go to the parent window and > change from one index or constraint to another, I think this could lead > to confusion since the child dialog does not change to suit the > selection in the parent. > If you mean the browser window, every properties dialog has this behaviour. Nothing wrong here, AFAICT. -- Guillaume http://blog.guillaume.lelarge.info http://www.dalibo.com
On 04/20/2012 04:27 PM, Guillaume Lelarge wrote: > On Fri, 2012-04-20 at 10:25 -0400, Colin Beckingham wrote: >> >> On 04/20/2012 07:58 AM, Guillaume Lelarge wrote: >>> Hi Colin, >>> >>> On Fri, 2012-04-20 at 13:15 +0200, Guillaume Lelarge wrote: >>>> On Wed, 2012-04-11 at 17:13 -0400, Colin Beckingham wrote: >>>>> >>>>> On 04/11/2012 04:38 PM, Colin Beckingham wrote: >>>>>> Guillaume, I see the missing column name in index-properties has been >>>>>> fixed. Thanks. >>>>>> >>>>>> However the column name appears to be truncated one char too early; >>>>>> bookid becomes booki and authid becomes authi. Seems to be consistent >>>>>> across databases. >>>>> >>>>> I am confusing Constraints and Indexes again. The column name is still >>>>> missing from _Constraints_, the name is present in _Indexes_ but >>>>> truncated 1 char. >>>>> >>>> >>>> 'k. Actually, as far as I can tell, it also happens with wxWidgets 2.8. >>>> It also happens on 1.14. I'm working on it. >>>> >>> >>> Can you try the attached patch, please? >> >> The patch works in that it fixes some indicated problems: in >> constraints, the field name now appears under columns, and in indexes >> the name of the indexed field is fully named. >> >> Some issues which may remain: >> 1. in indexes, the other detail for a field, (sort type, treatment of >> nulls etc), is indicated alongside the field name but in constraints >> this detail is present in grey in the text but missing from the table > > So I looked into this this afternoon and I found many disappointing > things. Meaning there are still a few bugs to fix :-/ (for example don't > try to use a column name with space in it in an index...) > >> 2. in both constraints and indexes, neither the add nor remove buttons >> activate, neither do any of the field selector and other dropdowns, this >> may of course be deliberate if they should not be changed in this >> context, however say you want to change an index from indexing a single >> field to indexing multiple fields, or change from asc to desc? > > PostgreSQL doesn't allow that, so pgAdmin doesn't allow it either. You > can change an index's name, its tablespace, and storage parameters. > That's all. > OK, not a problem, it's just that in the properties dialog, columns tab, the row which indicates the field is selectable and changes colour and therefore looks like selecting it does something, but in fact you can't change anything there. So I wonder if there is a way to make it even less responsive so that expectations are not raised? >> 3. the new dialog box is not modal. I can go to the parent window and >> change from one index or constraint to another, I think this could lead >> to confusion since the child dialog does not change to suit the >> selection in the parent. >> > > If you mean the browser window, every properties dialog has this > behaviour. Nothing wrong here, AFAICT. > OK. I wonder for consistency's sake (parent-child) if the properties dialog window should have a close button like the parent? In Gnome 3 a close button is on the parent but the only way of closing the properties dialog is through the Cancel button. -- --- Colin Beckingham 613-454-5369 http://www.it4gh.com
On Fri, 2012-04-20 at 17:09 -0400, Colin Beckingham wrote: > > On 04/20/2012 04:27 PM, Guillaume Lelarge wrote: > > On Fri, 2012-04-20 at 10:25 -0400, Colin Beckingham wrote: > >> > >> On 04/20/2012 07:58 AM, Guillaume Lelarge wrote: > >>> Hi Colin, > >>> > >>> On Fri, 2012-04-20 at 13:15 +0200, Guillaume Lelarge wrote: > >>>> On Wed, 2012-04-11 at 17:13 -0400, Colin Beckingham wrote: > >>>>> > >>>>> On 04/11/2012 04:38 PM, Colin Beckingham wrote: > >>>>>> Guillaume, I see the missing column name in index-properties has been > >>>>>> fixed. Thanks. > >>>>>> > >>>>>> However the column name appears to be truncated one char too early; > >>>>>> bookid becomes booki and authid becomes authi. Seems to be consistent > >>>>>> across databases. > >>>>> > >>>>> I am confusing Constraints and Indexes again. The column name is still > >>>>> missing from _Constraints_, the name is present in _Indexes_ but > >>>>> truncated 1 char. > >>>>> > >>>> > >>>> 'k. Actually, as far as I can tell, it also happens with wxWidgets 2.8. > >>>> It also happens on 1.14. I'm working on it. > >>>> > >>> > >>> Can you try the attached patch, please? > >> > >> The patch works in that it fixes some indicated problems: in > >> constraints, the field name now appears under columns, and in indexes > >> the name of the indexed field is fully named. > >> > >> Some issues which may remain: > >> 1. in indexes, the other detail for a field, (sort type, treatment of > >> nulls etc), is indicated alongside the field name but in constraints > >> this detail is present in grey in the text but missing from the table > > > > So I looked into this this afternoon and I found many disappointing > > things. Meaning there are still a few bugs to fix :-/ (for example don't > > try to use a column name with space in it in an index...) > > > >> 2. in both constraints and indexes, neither the add nor remove buttons > >> activate, neither do any of the field selector and other dropdowns, this > >> may of course be deliberate if they should not be changed in this > >> context, however say you want to change an index from indexing a single > >> field to indexing multiple fields, or change from asc to desc? > > > > PostgreSQL doesn't allow that, so pgAdmin doesn't allow it either. You > > can change an index's name, its tablespace, and storage parameters. > > That's all. > > > > OK, not a problem, it's just that in the properties dialog, columns tab, > the row which indicates the field is selectable and changes colour and > therefore looks like selecting it does something, but in fact you can't > change anything there. So I wonder if there is a way to make it even > less responsive so that expectations are not raised? > Yes, we could (should) disable it. The patch I'm working on will fix this. > >> 3. the new dialog box is not modal. I can go to the parent window and > >> change from one index or constraint to another, I think this could lead > >> to confusion since the child dialog does not change to suit the > >> selection in the parent. > >> > > > > If you mean the browser window, every properties dialog has this > > behaviour. Nothing wrong here, AFAICT. > > > > OK. I wonder for consistency's sake (parent-child) if the properties > dialog window should have a close button like the parent? In Gnome 3 a > close button is on the parent but the only way of closing the properties > dialog is through the Cancel button. > They should have a Close button. The inconstency you have is probably related to the poor handling of Gnome 3 by wxWidgets. It should improve for 3.0, or at least I hope so. -- Guillaume http://blog.guillaume.lelarge.info http://www.dalibo.com
On Fri, 2012-04-20 at 23:40 +0200, Guillaume Lelarge wrote: > On Fri, 2012-04-20 at 17:09 -0400, Colin Beckingham wrote: > > > > On 04/20/2012 04:27 PM, Guillaume Lelarge wrote: > > > On Fri, 2012-04-20 at 10:25 -0400, Colin Beckingham wrote: > > >> > > >> On 04/20/2012 07:58 AM, Guillaume Lelarge wrote: > > >>> Hi Colin, > > >>> > > >>> On Fri, 2012-04-20 at 13:15 +0200, Guillaume Lelarge wrote: > > >>>> On Wed, 2012-04-11 at 17:13 -0400, Colin Beckingham wrote: > > >>>>> > > >>>>> On 04/11/2012 04:38 PM, Colin Beckingham wrote: > > >>>>>> Guillaume, I see the missing column name in index-properties has been > > >>>>>> fixed. Thanks. > > >>>>>> > > >>>>>> However the column name appears to be truncated one char too early; > > >>>>>> bookid becomes booki and authid becomes authi. Seems to be consistent > > >>>>>> across databases. > > >>>>> > > >>>>> I am confusing Constraints and Indexes again. The column name is still > > >>>>> missing from _Constraints_, the name is present in _Indexes_ but > > >>>>> truncated 1 char. > > >>>>> > > >>>> > > >>>> 'k. Actually, as far as I can tell, it also happens with wxWidgets 2.8. > > >>>> It also happens on 1.14. I'm working on it. > > >>>> > > >>> > > >>> Can you try the attached patch, please? > > >> > > >> The patch works in that it fixes some indicated problems: in > > >> constraints, the field name now appears under columns, and in indexes > > >> the name of the indexed field is fully named. > > >> > > >> Some issues which may remain: > > >> 1. in indexes, the other detail for a field, (sort type, treatment of > > >> nulls etc), is indicated alongside the field name but in constraints > > >> this detail is present in grey in the text but missing from the table > > > > > > So I looked into this this afternoon and I found many disappointing > > > things. Meaning there are still a few bugs to fix :-/ (for example don't > > > try to use a column name with space in it in an index...) > > > > > >> 2. in both constraints and indexes, neither the add nor remove buttons > > >> activate, neither do any of the field selector and other dropdowns, this > > >> may of course be deliberate if they should not be changed in this > > >> context, however say you want to change an index from indexing a single > > >> field to indexing multiple fields, or change from asc to desc? > > > > > > PostgreSQL doesn't allow that, so pgAdmin doesn't allow it either. You > > > can change an index's name, its tablespace, and storage parameters. > > > That's all. > > > > > > > OK, not a problem, it's just that in the properties dialog, columns tab, > > the row which indicates the field is selectable and changes colour and > > therefore looks like selecting it does something, but in fact you can't > > change anything there. So I wonder if there is a way to make it even > > less responsive so that expectations are not raised? > > > > Yes, we could (should) disable it. The patch I'm working on will fix > this. > Done, with some other fixes in indexes. Thanks for your report. -- Guillaume http://blog.guillaume.lelarge.info http://www.dalibo.com