Обсуждение: Query tool layout issues
Hi Guillaume, I just started using a recent snapshot build of pgAdmin, and found some display issues in the query tool related to recent changes that could use some attention. Please see the attached screenshot: - The connection drop-down has become rather ugly (the button doesn't line up vertically), and requires scrolling even for a tiny list. - The left-hand margin is the same colour as the text area now. Can we make it gray again please? - The buttons to the right of the recent queries combo are not lined up with it. Can you take a look please? -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com PG East Conference: http://www.enterprisedb.com/community/nav-pg-east-2010.do
Вложения
Le 01/03/2010 21:19, Dave Page a écrit : > Hi Guillaume, > > I just started using a recent snapshot build of pgAdmin, and found > some display issues in the query tool related to recent changes that > could use some attention. Please see the attached screenshot: > > - The connection drop-down has become rather ugly (the button doesn't > line up vertically), and requires scrolling even for a tiny list. > > - The left-hand margin is the same colour as the text area now. Can we > make it gray again please? > > - The buttons to the right of the recent queries combo are not lined up with it. > > Can you take a look please? > Sure, I'll take a look. The issues seem mainly to occur on Mac OS X machines. I have issues to compile a pgAdmin release on Mac OS X since a few days (an XML library issue). I'll work on that first. -- Guillaume. http://www.postgresqlfr.org http://dalibo.com
On Mon, Mar 1, 2010 at 9:16 PM, Guillaume Lelarge <guillaume@lelarge.info> wrote: > Le 01/03/2010 21:19, Dave Page a écrit : >> Hi Guillaume, >> >> I just started using a recent snapshot build of pgAdmin, and found >> some display issues in the query tool related to recent changes that >> could use some attention. Please see the attached screenshot: >> >> - The connection drop-down has become rather ugly (the button doesn't >> line up vertically), and requires scrolling even for a tiny list. >> >> - The left-hand margin is the same colour as the text area now. Can we >> make it gray again please? >> >> - The buttons to the right of the recent queries combo are not lined up with it. >> >> Can you take a look please? >> > > Sure, I'll take a look. The issues seem mainly to occur on Mac OS X > machines. I have issues to compile a pgAdmin release on Mac OS X since a > few days (an XML library issue). I'll work on that first. > Thanks. -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com PG East Conference: http://www.enterprisedb.com/community/nav-pg-east-2010.do
Le 01/03/2010 21:19, Dave Page a écrit : > Hi Guillaume, > > I just started using a recent snapshot build of pgAdmin, and found > some display issues in the query tool related to recent changes that > could use some attention. Please see the attached screenshot: > > - The connection drop-down has become rather ugly (the button doesn't > line up vertically), and requires scrolling even for a tiny list. > I still need to work on this one, but right now, I need some sleep. > - The left-hand margin is the same colour as the text area now. Can we > make it gray again please? > Can you check margincolor.patch? Works OK for me on GTK and Mac OS X. Didn't bother to check on Windows. The color used is #dddddd. Probably I should add the ability to customize it, as we can already customize much of the background and foreground colors. > - The buttons to the right of the recent queries combo are not lined up with it. > Can you check query.patch? Works OK for me on GTK, and is less ugly on Mac OS X. Is it good enough for you? -- Guillaume. http://www.postgresqlfr.org http://dalibo.com
Вложения
On Tue, Mar 2, 2010 at 10:52 PM, Guillaume Lelarge <guillaume@lelarge.info> wrote: > The color used is #dddddd. Probably I should add the ability to > customize it, as we can already customize much of the background and > foreground colors. Yeah, that works. I agree it should be customisable, seeing as everything else is. >> - The buttons to the right of the recent queries combo are not lined up with it. >> > > Can you check query.patch? Works OK for me on GTK, and is less ugly on > Mac OS X. Is it good enough for you? Yup, that looks better. Couple of thoughts though... - Only add a query to the list is it executes without an error, otherwise it will get spammed with non-functional queries and typos. - You can probably remove the 'Current' from 'Delete Current' and save some space. I think current is implied by the fact that the other says 'all'. -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com PG East Conference: http://www.enterprisedb.com/community/nav-pg-east-2010.do
Le 03/03/2010 13:25, Dave Page a écrit : > On Tue, Mar 2, 2010 at 10:52 PM, Guillaume Lelarge > <guillaume@lelarge.info> wrote: >> The color used is #dddddd. Probably I should add the ability to >> customize it, as we can already customize much of the background and >> foreground colors. > > Yeah, that works. I agree it should be customisable, seeing as > everything else is. > See patch attached (margin.patch). >>> - The buttons to the right of the recent queries combo are not lined up with it. >>> >> >> Can you check query.patch? Works OK for me on GTK, and is less ugly on >> Mac OS X. Is it good enough for you? > > Yup, that looks better. Couple of thoughts though... > > - Only add a query to the list is it executes without an error, > otherwise it will get spammed with non-functional queries and typos. > - You can probably remove the 'Current' from 'Delete Current' and save > some space. I think current is implied by the fact that the other says > 'all'. > Done too. See miscquery.patch. -- Guillaume. http://www.postgresqlfr.org http://dalibo.com
Вложения
On Wed, Mar 3, 2010 at 10:03 PM, Guillaume Lelarge <guillaume@lelarge.info> wrote: > Done too. See miscquery.patch. The Query tool looks good now, but I get a crash if I try to open the Options dialogue: Thread 0 Crashed: Dispatch queue: com.apple.main-thread 0 org.postgresql.pgadmin 0x001eddb0 pgSettingItemHashmap_wxImplementation_HashTable::DeleteNode(_wxHashTable_NodeBase*) + 28512 1 org.postgresql.pgadmin 0x001f21f9 pgSettingItemHashmap_wxImplementation_HashTable::DeleteNode(_wxHashTable_NodeBase*) + 45993 2 org.postgresql.pgadmin 0x0018c926 dlgSelDBNode::~dlgSelDBNode() + 342 3 libwx_base_carbonu-2.8.0.dylib 0x01375463 wxEvtHandler::ProcessEventIfMatches(wxEventTableEntryBase const&, wxEvtHandler*, wxEvent&) + 131 4 libwx_base_carbonu-2.8.0.dylib 0x01375526 wxEvtHandler::SearchDynamicEventTable(wxEvent&) + 86 5 libwx_base_carbonu-2.8.0.dylib 0x01375df3 wxEvtHandler::ProcessEvent(wxEvent&) + 179 6 libwx_base_carbonu-2.8.0.dylib 0x01375da9 wxEvtHandler::ProcessEvent(wxEvent&) + 105 7 libwx_macu_core-2.8.0.dylib 0x00f50f80 wxMenuBase::SendEvent(int, int) + 144 8 libwx_macu_core-2.8.0.dylib 0x00e9b6ac wxMenu::MacHandleCommandProcess(wxMenuItem*, int, wxWindow*) + 60 9 libwx_macu_core-2.8.0.dylib 0x00ecc3ab wxMacWindowEventHandler(OpaqueEventHandlerCallRef*, OpaqueEventRef*, void*) + 427 10 com.apple.HIToolbox 0x90e5ee29 DispatchEventToHandlers(EventTargetRec*, OpaqueEventRef*, HandlerCallRec*) + 1567 11 com.apple.HIToolbox 0x90e5e0f0 SendEventToEventTargetInternal(OpaqueEventRef*, OpaqueEventTargetRef*, HandlerCallRec*) + 411 12 com.apple.HIToolbox 0x90e80981 SendEventToEventTarget + 52 13 com.apple.HIToolbox 0x90eace3b SendHICommandEvent(unsigned long, HICommand const*, unsigned long, unsigned long, unsigned char, void const*, OpaqueEventTargetRef*, OpaqueEventTargetRef*, OpaqueEventRef**) + 448 14 com.apple.HIToolbox 0x90ed1b20 SendMenuCommandWithContextAndModifiers + 66 15 com.apple.HIToolbox 0x90ed1ad7 SendMenuItemSelectedEvent + 121 16 com.apple.HIToolbox 0x90ed19d3 FinishMenuSelection(SelectionData*, MenuResult*, MenuResult*) + 152 17 com.apple.HIToolbox 0x90ea1212 MenuSelectCore(MenuData*, Point, double, unsigned long, OpaqueMenuRef**, unsigned short*) + 440 18 com.apple.HIToolbox 0x91053144 MenuSelect + 190 19 libwx_macu_core-2.8.0.dylib 0x00ec3af9 wxMacTopLevelMouseEventHandler(OpaqueEventHandlerCallRef*, OpaqueEventRef*, void*) + 1193 20 libwx_macu_core-2.8.0.dylib 0x00e60b95 wxMacAppEventHandler(OpaqueEventHandlerCallRef*, OpaqueEventRef*, void*) + 1061 21 com.apple.HIToolbox 0x90e5ee29 DispatchEventToHandlers(EventTargetRec*, OpaqueEventRef*, HandlerCallRec*) + 1567 22 com.apple.HIToolbox 0x90e5e0f0 SendEventToEventTargetInternal(OpaqueEventRef*, OpaqueEventTargetRef*, HandlerCallRec*) + 411 23 com.apple.HIToolbox 0x90e80981 SendEventToEventTarget + 52 24 com.apple.HIToolbox 0x90e924f7 ToolboxEventDispatcherHandler(OpaqueEventHandlerCallRef*, OpaqueEventRef*, void*) + 1417 25 com.apple.HIToolbox 0x90e5f27a DispatchEventToHandlers(EventTargetRec*, OpaqueEventRef*, HandlerCallRec*) + 2672 26 com.apple.HIToolbox 0x90e5e0f0 SendEventToEventTargetInternal(OpaqueEventRef*, OpaqueEventTargetRef*, HandlerCallRec*) + 411 27 com.apple.HIToolbox 0x90e80981 SendEventToEventTarget + 52 28 libwx_macu_core-2.8.0.dylib 0x00e5efe6 wxApp::MacHandleOneEvent(void*) + 38 29 libwx_macu_core-2.8.0.dylib 0x00e5f80b wxApp::MacDoOneEvent() + 123 30 libwx_macu_core-2.8.0.dylib 0x00e78fd3 wxEventLoop::Dispatch() + 35 31 libwx_macu_core-2.8.0.dylib 0x00f1f708 wxEventLoopManual::Run() + 136 32 libwx_macu_core-2.8.0.dylib 0x00ef8bf3 wxAppBase::MainLoop() + 83 33 libwx_base_carbonu-2.8.0.dylib 0x0132b81a wxEntry(int&, wchar_t**) + 106 34 org.postgresql.pgadmin 0x0003f4c8 0x1000 + 255176 35 org.postgresql.pgadmin 0x0003f1c9 0x1000 + 254409 -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com PG East Conference: http://www.enterprisedb.com/community/nav-pg-east-2010.do
Le 04/03/2010 11:23, Dave Page a écrit : > On Wed, Mar 3, 2010 at 10:03 PM, Guillaume Lelarge > <guillaume@lelarge.info> wrote: > >> Done too. See miscquery.patch. > > The Query tool looks good now, but I get a crash if I try to open the > Options dialogue: > I don't get a crash when I open the frmOptions window. With which patch did you get that crash? > Thread 0 Crashed: Dispatch queue: com.apple.main-thread > 0 org.postgresql.pgadmin 0x001eddb0 > pgSettingItemHashmap_wxImplementation_HashTable::DeleteNode(_wxHashTable_NodeBase*) > + 28512 > 1 org.postgresql.pgadmin 0x001f21f9 > pgSettingItemHashmap_wxImplementation_HashTable::DeleteNode(_wxHashTable_NodeBase*) > + 45993 > 2 org.postgresql.pgadmin 0x0018c926 > dlgSelDBNode::~dlgSelDBNode() + 342 > 3 libwx_base_carbonu-2.8.0.dylib 0x01375463 > wxEvtHandler::ProcessEventIfMatches(wxEventTableEntryBase const&, > wxEvtHandler*, wxEvent&) + 131 > 4 libwx_base_carbonu-2.8.0.dylib 0x01375526 > wxEvtHandler::SearchDynamicEventTable(wxEvent&) + 86 > 5 libwx_base_carbonu-2.8.0.dylib 0x01375df3 > wxEvtHandler::ProcessEvent(wxEvent&) + 179 > 6 libwx_base_carbonu-2.8.0.dylib 0x01375da9 > wxEvtHandler::ProcessEvent(wxEvent&) + 105 > 7 libwx_macu_core-2.8.0.dylib 0x00f50f80 > wxMenuBase::SendEvent(int, int) + 144 > 8 libwx_macu_core-2.8.0.dylib 0x00e9b6ac > wxMenu::MacHandleCommandProcess(wxMenuItem*, int, wxWindow*) + 60 > 9 libwx_macu_core-2.8.0.dylib 0x00ecc3ab > wxMacWindowEventHandler(OpaqueEventHandlerCallRef*, OpaqueEventRef*, > void*) + 427 > 10 com.apple.HIToolbox 0x90e5ee29 > DispatchEventToHandlers(EventTargetRec*, OpaqueEventRef*, > HandlerCallRec*) + 1567 > 11 com.apple.HIToolbox 0x90e5e0f0 > SendEventToEventTargetInternal(OpaqueEventRef*, OpaqueEventTargetRef*, > HandlerCallRec*) + 411 > 12 com.apple.HIToolbox 0x90e80981 SendEventToEventTarget + 52 > 13 com.apple.HIToolbox 0x90eace3b > SendHICommandEvent(unsigned long, HICommand const*, unsigned long, > unsigned long, unsigned char, void const*, OpaqueEventTargetRef*, > OpaqueEventTargetRef*, OpaqueEventRef**) + 448 > 14 com.apple.HIToolbox 0x90ed1b20 > SendMenuCommandWithContextAndModifiers + 66 > 15 com.apple.HIToolbox 0x90ed1ad7 SendMenuItemSelectedEvent + 121 > 16 com.apple.HIToolbox 0x90ed19d3 > FinishMenuSelection(SelectionData*, MenuResult*, MenuResult*) + 152 > 17 com.apple.HIToolbox 0x90ea1212 > MenuSelectCore(MenuData*, Point, double, unsigned long, > OpaqueMenuRef**, unsigned short*) + 440 > 18 com.apple.HIToolbox 0x91053144 MenuSelect + 190 > 19 libwx_macu_core-2.8.0.dylib 0x00ec3af9 > wxMacTopLevelMouseEventHandler(OpaqueEventHandlerCallRef*, > OpaqueEventRef*, void*) + 1193 > 20 libwx_macu_core-2.8.0.dylib 0x00e60b95 > wxMacAppEventHandler(OpaqueEventHandlerCallRef*, OpaqueEventRef*, > void*) + 1061 > 21 com.apple.HIToolbox 0x90e5ee29 > DispatchEventToHandlers(EventTargetRec*, OpaqueEventRef*, > HandlerCallRec*) + 1567 > 22 com.apple.HIToolbox 0x90e5e0f0 > SendEventToEventTargetInternal(OpaqueEventRef*, OpaqueEventTargetRef*, > HandlerCallRec*) + 411 > 23 com.apple.HIToolbox 0x90e80981 SendEventToEventTarget + 52 > 24 com.apple.HIToolbox 0x90e924f7 > ToolboxEventDispatcherHandler(OpaqueEventHandlerCallRef*, > OpaqueEventRef*, void*) + 1417 > 25 com.apple.HIToolbox 0x90e5f27a > DispatchEventToHandlers(EventTargetRec*, OpaqueEventRef*, > HandlerCallRec*) + 2672 > 26 com.apple.HIToolbox 0x90e5e0f0 > SendEventToEventTargetInternal(OpaqueEventRef*, OpaqueEventTargetRef*, > HandlerCallRec*) + 411 > 27 com.apple.HIToolbox 0x90e80981 SendEventToEventTarget + 52 > 28 libwx_macu_core-2.8.0.dylib 0x00e5efe6 > wxApp::MacHandleOneEvent(void*) + 38 > 29 libwx_macu_core-2.8.0.dylib 0x00e5f80b wxApp::MacDoOneEvent() + 123 > 30 libwx_macu_core-2.8.0.dylib 0x00e78fd3 wxEventLoop::Dispatch() + 35 > 31 libwx_macu_core-2.8.0.dylib 0x00f1f708 wxEventLoopManual::Run() + 136 > 32 libwx_macu_core-2.8.0.dylib 0x00ef8bf3 wxAppBase::MainLoop() + 83 > 33 libwx_base_carbonu-2.8.0.dylib 0x0132b81a wxEntry(int&, wchar_t**) + 106 > 34 org.postgresql.pgadmin 0x0003f4c8 0x1000 + 255176 > 35 org.postgresql.pgadmin 0x0003f1c9 0x1000 + 254409 > > -- Guillaume. http://www.postgresqlfr.org http://dalibo.com
On Thu, Mar 4, 2010 at 8:42 PM, Guillaume Lelarge <guillaume@lelarge.info> wrote: > Le 04/03/2010 11:23, Dave Page a écrit : >> On Wed, Mar 3, 2010 at 10:03 PM, Guillaume Lelarge >> <guillaume@lelarge.info> wrote: >> >>> Done too. See miscquery.patch. >> >> The Query tool looks good now, but I get a crash if I try to open the >> Options dialogue: >> > > I don't get a crash when I open the frmOptions window. With which patch > did you get that crash? All of them on top of the latest SVN code. I tried a make clean which didn't help. -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com PG East Conference: http://www.enterprisedb.com/community/nav-pg-east-2010.do
Le 04/03/2010 21:45, Dave Page a écrit : > On Thu, Mar 4, 2010 at 8:42 PM, Guillaume Lelarge > <guillaume@lelarge.info> wrote: >> Le 04/03/2010 11:23, Dave Page a écrit : >>> On Wed, Mar 3, 2010 at 10:03 PM, Guillaume Lelarge >>> <guillaume@lelarge.info> wrote: >>> >>>> Done too. See miscquery.patch. >>> >>> The Query tool looks good now, but I get a crash if I try to open the >>> Options dialogue: >>> >> >> I don't get a crash when I open the frmOptions window. With which patch >> did you get that crash? > > All of them on top of the latest SVN code. I tried a make clean which > didn't help. > I have them too, and still don't crash. Can you try with empty prefs? -- Guillaume. http://www.postgresqlfr.org http://dalibo.com
On Thu, Mar 4, 2010 at 8:56 PM, Guillaume Lelarge <guillaume@lelarge.info> wrote: >>> I don't get a crash when I open the frmOptions window. With which patch >>> did you get that crash? >> >> All of them on top of the latest SVN code. I tried a make clean which >> didn't help. >> > > I have them too, and still don't crash. Can you try with empty prefs? It seems someone forgot to update xrcDialogs.cpp after changing frmOptions :-p BTW, on OSX, the tabset overflows the width of the dialogue now. Can we widen the dialogue, and perhaps move all the colour options onto one tab? -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com PG East Conference: http://www.enterprisedb.com/community/nav-pg-east-2010.do
Le 05/03/2010 22:07, Dave Page a écrit : > On Thu, Mar 4, 2010 at 8:56 PM, Guillaume Lelarge > <guillaume@lelarge.info> wrote: >>>> I don't get a crash when I open the frmOptions window. With which patch >>>> did you get that crash? >>> >>> All of them on top of the latest SVN code. I tried a make clean which >>> didn't help. >>> >> >> I have them too, and still don't crash. Can you try with empty prefs? > > It seems someone forgot to update xrcDialogs.cpp after changing frmOptions :-p > I plead guilty :-/ > BTW, on OSX, the tabset overflows the width of the dialogue now. Can > we widen the dialogue, and perhaps move all the colour options onto > one tab? > Yeah, I've seen that. My idea was to put sizers on this dialog and to widen it. And, if possible, change a bit the dialog (moving the colour options could be one way of doing it). -- Guillaume. http://www.postgresqlfr.org http://dalibo.com