Обсуждение: CVS version does not compile

Cheers, Jean-Michel

*******************************************
if g++ -DHAVE_CONFIG_H -I. -I. -I..   -I/usr/include
-I/usr/lib/wx/include/gtk2ud-2.5 -D__WXDEBUG__ -D__WXGTK__
-D_FILE_OFFSET_BITS=64 -D_LARGE_FILES -I/usr/include
-DDATA_DIR=\"/usr/local/pgadmin3/share/pgadmin3/\" -Wall -g -I./include/ -I
-g -O2 -MT ctlSQLResult.o -MD -MP -MF ".deps/ctlSQLResult.Tpo" \
  -c -o ctlSQLResult.o `test -f 'ui/ctlSQLResult.cpp' || echo
'./'`ui/ctlSQLResult.cpp; \
then mv -f ".deps/ctlSQLResult.Tpo" ".deps/ctlSQLResult.Po"; \
else rm -f ".deps/ctlSQLResult.Tpo"; exit 1; \
fi
ui/ctlSQLResult.cpp: Dans member function « bool ctlSQLResult::Export() »:
ui/ctlSQLResult.cpp:39: erreur d'analyse syntaxique avant « export »
make[2]: *** [ctlSQLResult.o] Erreur 1
make[2]: Quitte le répertoire `/usr/src/redhat/BUILD/pgadmin3-0.1.1/src'
make[1]: *** [all-recursive] Erreur 1
make[1]: Quitte le répertoire `/usr/src/redhat/BUILD/pgadmin3-0.1.1'
make: *** [all] Erreur 2
error: Bad exit status from /var/tmp/rpm-tmp.83769 (%build)

Jean-Michel POURE wrote:

>Cheers, Jean-Michel
>
>*******************************************
>if g++ -DHAVE_CONFIG_H -I. -I. -I..   -I/usr/include
>-I/usr/lib/wx/include/gtk2ud-2.5 -D__WXDEBUG__ -D__WXGTK__
>-D_FILE_OFFSET_BITS=64 -D_LARGE_FILES -I/usr/include
>-DDATA_DIR=\"/usr/local/pgadmin3/share/pgadmin3/\" -Wall -g -I./include/ -I
>-g -O2 -MT ctlSQLResult.o -MD -MP -MF ".deps/ctlSQLResult.Tpo" \
>  -c -o ctlSQLResult.o `test -f 'ui/ctlSQLResult.cpp' || echo
>'./'`ui/ctlSQLResult.cpp; \
>then mv -f ".deps/ctlSQLResult.Tpo" ".deps/ctlSQLResult.Po"; \
>else rm -f ".deps/ctlSQLResult.Tpo"; exit 1; \
>fi
>
>
There are two problems:

- I used "export" as a variable name, not good for gcc.

- Linkage has been changed again. in stead of
    LIB=...  -L$(WX_HOME)/lib -l wx_gtk2ud_stc -lwc -l wx_gtk2ud_xrc
which will link static or dynamic libraries as appropriate, it now says
    LIB=... -l$(WX_HOME)/lib/libwx_gtk2ud_stc.a,
tying it to the static libraries (I dont have them...) This is done for
stc and xrc, not for the base wx lib.

Please revert it back to the flexible solution.

Regards,
Andreas

> -----Original Message-----
> From: Andreas Pflug [mailto:Andreas.Pflug@web.de]
> Sent: 20 June 2003 21:51
> To: jm.poure@freesurf.fr
> Cc: pgadmin-hackers@postgresql.org; Dave Page; Adam Pendleton
> Subject: Re: [pgadmin-hackers] CVS version does not compile
>
>
> - Linkage has been changed again. in stead of
>     LIB=...  -L$(WX_HOME)/lib -l wx_gtk2ud_stc -lwc -l
> wx_gtk2ud_xrc which will link static or dynamic libraries as
> appropriate, it now says
>     LIB=... -l$(WX_HOME)/lib/libwx_gtk2ud_stc.a,
> tying it to the static libraries (I dont have them...) This
> is done for
> stc and xrc, not for the base wx lib.
>
> Please revert it back to the flexible solution.
>

That was changed because it is the correct solution. Debug builds use wx
statically, and following some bug reports, I changed it to use static
xrc, stc and libpq as well. Release builds are dynamic in all ways.

However, I realise this is not ideal, so proposed a change earlier that
will allow any combination of release/debug & static/dynamic. I believe
Adam is now working on it.

Regards, Dave

Dave Page wrote:

>>- Linkage has been changed again. in stead of
>>    LIB=...  -L$(WX_HOME)/lib -l wx_gtk2ud_stc -lwc -l
>>wx_gtk2ud_xrc which will link static or dynamic libraries as
>>appropriate, it now says
>>    LIB=... -l$(WX_HOME)/lib/libwx_gtk2ud_stc.a,
>>tying it to the static libraries (I dont have them...) This
>>is done for
>>stc and xrc, not for the base wx lib.
>>
>>Please revert it back to the flexible solution.
>>
>>
>>
>
>That was changed because it is the correct solution. Debug builds use wx
>statically, and following some bug reports, I changed it to use static
>xrc, stc and libpq as well. Release builds are dynamic in all ways.
>
>However, I realise this is not ideal, so proposed a change earlier that
>will allow any combination of release/debug & static/dynamic. I believe
>Adam is now working on it.
>
There are Debug (both static/dynamic possible), Normal (user downloaded
tarball and compiles against installed packages, both static/dynamic
possible) and binary distribution (we want it as static as possible,
GTK2 can be required IMHO)

Regards,
Andreas