Re: Logical Replication - improve error message while adding tables to the publication in check_publication_add_relation

Поиск
Список
Период
Сортировка
От Peter Eisentraut
Тема Re: Logical Replication - improve error message while adding tables to the publication in check_publication_add_relation
Дата
Msg-id f79c6631-ca02-6c4a-e70b-17e8bf96cef3@enterprisedb.com
обсуждение исходный текст
Ответ на Re: Logical Replication - improve error message while adding tables to the publication in check_publication_add_relation  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
Ответы Re: Logical Replication - improve error message while adding tables to the publication in check_publication_add_relation  (Daniel Gustafsson <daniel@yesql.se>)
Список pgsql-hackers
On 15.11.21 10:38, Bharath Rupireddy wrote:
>> I still think that the v8 patch posted earlier is the better option, which
>> increase granularity of error reporting with a small code footprint.
> Thanks. Attaching the v8 here again.

I find the use of RelationUsesLocalBuffers() confusing in this patch. 
It would be clearer to check relpersistence directly in both branches of 
the if statement.



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Andres Freund
Дата:
Сообщение: Re: [RFC] building postgres with meson
Следующее
От: Dagfinn Ilmari Mannsåker
Дата:
Сообщение: Re: Test::More version