Hi,
On Fri, Nov 07, 2025 at 03:03:03PM +0000, Bertrand Drouvot wrote:
> Hi,
>
> On Fri, Nov 07, 2025 at 02:37:32PM +0100, Álvaro Herrera wrote:
> > On 2025-Nov-07, Bertrand Drouvot wrote:
> >
> > > Agree, will modify the .cocci scripts that way.
> >
> > I just noticed that we missed this ... maybe you want to include it also?
> >
> > - MyProc->waitLSN = 0;
> > + MyProc->waitLSN = InvalidXLogRecPtr;
> >
> > - lastLSN = 0;
> > + lastLSN = InvalidXLogRecPtr;
> >
> > - MyProc->waitLSN = 0;
> > + MyProc->waitLSN = InvalidXLogRecPtr;
>
> Yeah, that's another story here that is worth to look at too. Will do.
What do you think of the attached? It contains the ones you mentioned and some
others. The patch attached has been generated by the .cocci script [1].
[1]: https://github.com/bdrouvot/coccinelle_on_pg/blob/main/replace_literal_0_assignement_with_InvalidXLogRecPtr.cocci
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com