Re: Consistently use the XLogRecPtrIsInvalid() macro

Поиск
Список
Период
Сортировка
От Álvaro Herrera
Тема Re: Consistently use the XLogRecPtrIsInvalid() macro
Дата
Msg-id 202511131242.kcbmff4tc5ss@alvherre.pgsql
обсуждение исходный текст
Ответ на Re: Consistently use the XLogRecPtrIsInvalid() macro  (Bertrand Drouvot <bertranddrouvot.pg@gmail.com>)
Ответы Re: Consistently use the XLogRecPtrIsInvalid() macro
Список pgsql-hackers
On 2025-Nov-07, Bertrand Drouvot wrote:

> What do you think of the attached? It contains the ones you mentioned and some
> others. The patch attached has been generated by the .cocci script [1].
> 
> [1]:
https://github.com/bdrouvot/coccinelle_on_pg/blob/main/replace_literal_0_assignement_with_InvalidXLogRecPtr.cocci

Hmm, I tried to recreate your patch using this .cocci file, and in my
run, there's a few changes in your patch that my spatch run didn't
detect.  I wonder if that's because my spatch version is buggy, or
because you hacked the .cocci file beyond what's in your github repo.

In case you're curious, here's two commits: what I got with my spatch
run as a first step, and then the patch you sent on top of that.

(I'm wondering if I should reproduce your previous patches in case there
were also differences there.  Life is short though.)

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/

Вложения

В списке pgsql-hackers по дате отправления: