Re: Consistently use the XLogRecPtrIsInvalid() macro

Hi,

On Fri, Nov 07, 2025 at 02:37:32PM +0100, Álvaro Herrera wrote:
> On 2025-Nov-07, Bertrand Drouvot wrote:
> 
> > Agree, will modify the .cocci scripts that way.
> 
> I just noticed that we missed this ... maybe you want to include it also?
> 
> -    MyProc->waitLSN = 0;
> +    MyProc->waitLSN = InvalidXLogRecPtr;
>  
> -    lastLSN = 0;
> +    lastLSN = InvalidXLogRecPtr;
>  
> -    MyProc->waitLSN = 0;
> +    MyProc->waitLSN = InvalidXLogRecPtr;

Yeah, that's another story here that is worth to look at too. Will do.

I'm currently working on the RegProcedureIsValid() and OidIsValid() cases,
will share once done.

> 
> > Now that XLogRecPtrIsValid() is available in back branches, I agree that we
> > can be less conservative and not wait until v24. v21 looks like good timing to
> > me.
> 
> Cool,  please resubmit.

Sure, done in the attached.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com