On Fri, Dec 30, 2022 at 05:12:57PM -0600, Justin Pryzby wrote:
# Use larger ccache cache, as this task compiles with multiple compilers /
# flag combinations
- CCACHE_MAXSIZE: "1GB"
+ CCACHE_MAXSIZE: "1G"
In 0006, I am not sure how much this matters. Perhaps somebody more
fluent with Cirrus, though, has a different opinion..
* pointer to this structure. The information here must be sufficient to
* properly initialize each new TableScanDesc as workers join the scan, and it
- * must act as a information what to scan for those workers.
+ * must provide information what to scan for those workers.
This comment in 0009 is obviously incorrect, but I am not sure whether
your new suggestion is an improvement. Do workers provide such
information or has this structure some information that the workers
rely on?
Not sure that the whitespace issue in 0021 for the header of inval.c
is worth caring about.
0014 and 0013 do not reduce the translation workload, as the messages
include some stuff specific to the GUC names accessed to, or some
specific details about the code paths triggered.
The rest has been applied where they matter.
--
Michael