On Wednesday, November 17, 2021 12:19 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> On Tue, Nov 16, 2021 at 9:34 PM osumi.takamichi@fujitsu.com
> <osumi.takamichi@fujitsu.com> wrote:
> >
> > On Monday, November 15, 2021 9:14 PM I wrote:
> > > I've conducted some update for this.
> > > (The rebased part is only C code and checked by pgindent)
> > I'll update my patches since a new skip xid patch has been shared in
> > [1].
> >
> > This version includes some minor renames of functions that are related
> > to transaction sizes.
>
> I've looked at v12-0001 patch. Here are some comments:
Thank you for paying attention to this thread !
> - TupleDescInitEntry(tupdesc, (AttrNumber) 3, "relid",
> + TupleDescInitEntry(tupdesc, (AttrNumber) 3, "last_error_relid",
> OIDOID, -1, 0);
> - TupleDescInitEntry(tupdesc, (AttrNumber) 4, "command",
> + TupleDescInitEntry(tupdesc, (AttrNumber) 4, "last_error_command",
> TEXTOID, -1, 0);
> - TupleDescInitEntry(tupdesc, (AttrNumber) 5, "xid",
> + TupleDescInitEntry(tupdesc, (AttrNumber) 5, "last_error_xid",
> XIDOID, -1, 0);
> - TupleDescInitEntry(tupdesc, (AttrNumber) 6, "error_count",
> + TupleDescInitEntry(tupdesc, (AttrNumber) 6, "last_error_count",
> INT8OID, -1, 0);
> - TupleDescInitEntry(tupdesc, (AttrNumber) 7, "error_message",
> + TupleDescInitEntry(tupdesc, (AttrNumber) 7, "last_error_message",
>
> If renaming column names clarifies those meanings, the above changes should
> be included into my patch that introduces pg_stat_subscription_workers
> view?
At first, your column names of pg_stat_subscription_workers look totally OK to me by itself
and I thought I should take care of those renaming at the commit timing of my stats patches.
But, if you agree with the new names above and fixing your patch doesn't
bother you, I'd appreciate your help !
> I think that exporting PartitionTupleRouting should not be done in the one
> patch together with renaming the view columns. There is not relevance
> between them at all. If it's used by v12-0002 patch, I think it should be included
> in that patch or in another separate patch.
Yes, it's used by v12-0002.
Absolutely you are right. When you update the patch like above,
I would like to make it independent.
Best Regards,
Takamichi Osumi