From Sun, Sept 12, 2021 11:13 PM vignesh C <vignesh21@gmail.com> wrote:
> On Fri, Sep 10, 2021 at 11:21 AM Hou Zhijie <houzj.fnst@fujitsu.com> wrote:
> > Attach the without-flag version and add comments about the pubobj_name.
>
> Thanks for the changes, the suggested changes make the parsing code simpler.
> I have merged the changes to the main patch. Attached v27 patch has the
> changes for the same.
Hi,
I have some suggestions for the documents and comments of the new syntax.
IMO, the document could be clearer in the following format.
------
Synopsis
CREATE PUBLICATION name
[ FOR ALL TABLES
| FOR publication object [, ... ] ]
[ WITH ( publication_parameter [= value] [, ... ] ) ]
where publication object is one of:
TABLE [ ONLY ] table_name [ * ] [, ... ]
ALL TABLES IN SCHEMA { schema_name | CURRENT_SCHEMA } [, ... ]
------
Attach a diff(based on v27-*) which change the doc and comments like the
following.
Best regards,
Hou zj