On Tue, Sep 14, 2021 at 6:31 AM houzj.fnst@fujitsu.com
<houzj.fnst@fujitsu.com> wrote:
>
> From Sun, Sept 12, 2021 11:13 PM vignesh C <vignesh21@gmail.com> wrote:
> > On Fri, Sep 10, 2021 at 11:21 AM Hou Zhijie <houzj.fnst@fujitsu.com> wrote:
> > > Attach the without-flag version and add comments about the pubobj_name.
> >
> > Thanks for the changes, the suggested changes make the parsing code simpler.
> > I have merged the changes to the main patch. Attached v27 patch has the
> > changes for the same.
>
> Hi,
>
> I have some suggestions for the documents and comments of the new syntax.
>
> IMO, the document could be clearer in the following format.
> ------
> Synopsis
> CREATE PUBLICATION name
> [ FOR ALL TABLES
> | FOR publication object [, ... ] ]
> [ WITH ( publication_parameter [= value] [, ... ] ) ]
>
> where publication object is one of:
>
> TABLE [ ONLY ] table_name [ * ] [, ... ]
> ALL TABLES IN SCHEMA { schema_name | CURRENT_SCHEMA } [, ... ]
> ------
>
> Attach a diff(based on v27-*) which change the doc and comments like the
> following.
Thanks for the comments and the changes, I have made a few changes and
merged it into the v28 patch attached at [1].
[1] - https://www.postgresql.org/message-id/CALDaNm0OudeDeFN7bSWPro0hgKx%3D1zPgcNFWnvU_G6w3mDPX0Q%40mail.gmail.com
Regards,
Vignesh