Re: pgsql: Add putenv support for msvcrt from Visual Studio 2013

Поиск
Список
Период
Сортировка
От Christian Ullrich
Тема Re: pgsql: Add putenv support for msvcrt from Visual Studio 2013
Дата
Msg-id DB6PR0602MB29818313F0C5DCD2C7C65DDED48C0@DB6PR0602MB2981.eurprd06.prod.outlook.com
обсуждение исходный текст
Ответ на Re: pgsql: Add putenv support for msvcrt from Visual Studio 2013  (Michael Paquier <michael.paquier@gmail.com>)
Ответы Re: pgsql: Add putenv support for msvcrt from Visual Studio 2013
Re: pgsql: Add putenv support for msvcrt from Visual Studio 2013
Список pgsql-hackers
* From: Michael Paquier

> With 0005 I am seeing a compilation failure: you need to have the
> declarations in the _MSC_VER block at the beginning of the routine. It

Sorry, too used to C++.

> would be nice to mention in a code comment that this what Noah has
> mentioned upthread: if a CRT loads while pgwin32_putenv() is
> executing, the newly-loaded CRT will always have the latest value.

I fixed the existing comment by removing the last sentence that is in the wrong place now, but I don't see the point in
suddenlystarting to explain why it is done this way and not the other.
 

> Based on that 0006 will need a rebase, nothing huge though.

Done, new revisions attached.

-- 
Christian


Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: Minor correction in alter_table.sgml
Следующее
От: Andrew Dunstan
Дата:
Сообщение: Re: Mail thread references in commits