Re: Implementation of the GUI to create/modify/drop "Resource Group".

Поиск
Список
Период
Сортировка
От Akshay Joshi
Тема Re: Implementation of the GUI to create/modify/drop "Resource Group".
Дата
Msg-id CANxoLDf8iBv5nh1gbvjBEhUw=p1tL2WyueW3tDTb7s0stY0Bqg@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Implementation of the GUI to create/modify/drop "Resource Group".  (Dave Page <dpage@pgadmin.org>)
Ответы Re: Implementation of the GUI to create/modify/drop "Resource Group".  (Dave Page <dpage@pgadmin.org>)
Список pgadmin-hackers



On Sat, Jun 7, 2014 at 7:58 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi Akshay


On Thu, Jun 5, 2014 at 1:37 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Dave

I have implemented the GUI for creating, modifying and deleting the Resource Group for PPAS 9.4 and above. As I don't have new icon for the "Resource Group", I used the existing group and groups icon. I have tested the code on Windows and Linux.

Attached is the patch file. Please review it and if code looks good to you then can you please commit it.  

It looks fine to me on first review and test, except:

- The schema class and filename should be edbResourceGroup, not pgResourceGroup.

- pgResourceGroup::GetSql is incomplete - it doesn't emit the rate limit values, just "CREATE RESOURCE GROUP foo;" 

   Fixed. Attached is the modified patch.

Thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Akshay Joshi
Principal Software Engineer 


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246
Вложения

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Dave Page
Дата:
Сообщение: pgAdmin III commit: Soften up the collations icon.
Следующее
От: "J.F. Oster"
Дата:
Сообщение: Re: PATCH: Search Objects by definitions and comments