Re: BUG #17570: Unrecognized node type for query with statistics on expressions

On Thu, Aug 4, 2022 at 11:42 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:

* statext_is_compatible_clause_internal is not on board with
offsetting the attnums.

 

Correct. Good catch! Fix this in v2 patch.

* Although the coverage report claims this code is exercised, the
fact that nothing failed when you made only a partial fix says it's
not exercised well enough.

 

That's true. We need to provide a better test case to cover this.

Also I'm trying to provide a better test case and at last come up with a
case in v3 like:

    SELECT * FROM tststats.priv_test_tbl where a = 1 and tststats.priv_test_tbl.* > (1, 1) is not null;

For this case, the clause 'a = 1' would cover that the attnum comes from
statext_is_compatible_clause_internal. And the clause 'priv_test_tbl.* >
(1, 1) is not null' would cover that the attnum comes from 'exprs' and
it has a whole-row reference.

Thanks