Re: Calculate total_table_pages after set_base_rel_sizes()

On Tue, 25 Sep 2018 at 10:23, Edmund Horner <ejrh00@gmail.com> wrote:
> I have a small tweak.  In make_one_rel, we currently have:
>
>     /*
>      * Compute size estimates and consider_parallel flags for each base rel,
>      * then generate access paths.
>      */
>     set_base_rel_sizes(root);
>     set_base_rel_pathlists(root);
>
> Your patch inserts code between the two lines.  I think the comment should be split too.
>
>     /* Compute size estimates and consider_parallel flags for each base rel. */
>     set_base_rel_sizes(root);
>
>     // NEW CODE
>
>     /* Generate access paths. */
>     set_base_rel_pathlists(root);

Thanks for looking at this.

I've changed that in the attached updated patch.

-- 
 David Rowley                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services