Re: Calculate total_table_pages after set_base_rel_sizes()
| От | Tom Lane |
|---|---|
| Тема | Re: Calculate total_table_pages after set_base_rel_sizes() |
| Дата | |
| Msg-id | 8122.1541611077@sss.pgh.pa.us обсуждение |
| Ответ на | Re: Calculate total_table_pages after set_base_rel_sizes() (David Rowley <david.rowley@2ndquadrant.com>) |
| Ответы |
Re: Calculate total_table_pages after set_base_rel_sizes()
|
| Список | pgsql-hackers |
David Rowley <david.rowley@2ndquadrant.com> writes:
> [ v2-0001-Calculate-total_table_pages-after-set_base_rel_si.patch ]
Pushed with cosmetic adjustments. The reason it's okay to not check for
appendrels in this loop is now quite different from the reason it was okay
before, so I didn't like the fact that you'd just cut-and-pasted the same
comment. Also, you did s/brel/rel/ in the transferred code, which I would
not have objected to except you were inserting it into a function that
(a) already had a local variable "rel", causing a shadowing situation,
and (b) had an identical loop just above this that used the "brel"
notation. So I changed that back.
regards, tom lane
В списке pgsql-hackers по дате отправления: