Re: row filtering for logical replication

On Thu, Jan 6, 2022 at 9:29 AM Peter Smith <smithpb2250@gmail.com> wrote:
>
> FYI - v58 is currently known to be broken due to a recent commit [1].
>
> I plan to post a v59* later today to address this as well as other
> recent review comments.
>
> ------
> [1] https://github.com/postgres/postgres/commit/6ce16088bfed97f982f66a9dc17b8364df289e4d
>
> Kind Regards,
> Peter Smith.
> Fujitsu Australia.


Here is the v59* patch set:

Main changes from v58* are
0. Rebase to HEAD (needed after recent commit [1])
1. Multiple review comments addressed

~~

Details
=======

v58-0001 (main)
- Fixed some typos for commit message
- Made PG docs wording more consistent [5/1 Peter] #1,#2
- Modified tablesync SQL using Vignesh improvements [22/12 Amit] and
Tang improvements [internal]
- Fixed whitespace [5/1 Peter] #3
- Moved code below comment [5/1 Peter] #4
- Fixed typos/wording in comments [5/1 Peter] #5,#6,#7,#8,#9,#10,#13
- Removed parse_node.h from this patch [5/1 Peter] #12, [5/1 Vignesh] #4
- Used for_each_from macro in tablesync [5/1 Wangw] #1
- Reverted unnecessary signature change of get_rel_sync_entry [5/1 Wangw] #2
- Moved #define outside of struct [5/1 Amit #define]

v58-0002 (new/old tuple)
- Modified signature of pgoutput_row_file_update_check [29/12 Tang] #3
- Removed unnecessary assignments of *action [5/1 Amit *action]

v58-0003 (tab, dump)
- no change

v58-0004 (refactor transformations)
- no change

------
[1] https://github.com/postgres/postgres/commit/6ce16088bfed97f982f66a9dc17b8364df289e4d
[22/12 Amit]
https://www.postgresql.org/message-id/CAA4eK1JNRE1dQR_xQT-2pFFHMTXzb%3DCf68Dw3N_5swvrz0D8tw%40mail.gmail.com
[29/12 Tang]
https://www.postgresql.org/message-id/OS0PR01MB611317903619FE04C42AD1ECFB449%40OS0PR01MB6113.jpnprd01.prod.outlook.com
[5/1 Amit #define]
https://www.postgresql.org/message-id/CAA4eK1K5%3DFZ47va1NjTrSJADCf91%3D251LtvqBxNjt4vtZGjPGw%40mail.gmail.com
[5/1 Amit *action]
https://www.postgresql.org/message-id/CAA4eK1Ktt5GrzM8hHWn9htg_Cfn-7y0VN6zFFyqQM4FxEjc5Rg%40mail.gmail.com
[5/1 Peter]
https://www.postgresql.org/message-id/CAHut%2BPvp_O%2BZQf11kOyhO80YHUQnPQZMDRrm2ce%2BryY36H_TPw%40mail.gmail.com
[5/1 Vignesh]
https://www.postgresql.org/message-id/CALDaNm13yVPH0EcObv4tCHLQfUwjfvPFh8c-nd3Ldg71Y9es7A%40mail.gmail.com
[5/1 Wangw]
https://www.postgresql.org/message-id/OS3PR01MB6275ADE2B0EDED067C136D539E4B9%40OS3PR01MB6275.jpnprd01.prod.outlook.com

Kind Regards,
Peter Smith.
Fujitsu Australia