On Sat, Feb 18, 2012 at 2:16 AM, Robert Haas <robertmhaas@gmail.com> wrote:
> On Fri, Feb 17, 2012 at 5:04 AM, Fujii Masao <masao.fujii@gmail.com> wrote:
>> Here are review comments:
>>
>> The document about EXPLAIN needs to be updated.
>>
>> You forgot to add the long-integer-valued property of shared/local_blks_dirtied.
>> So when I ran EXPLAIN and used json as a format, no information about
>> blks_dirtied
>> was reported.
>
> Thanks for the review. Updated patch attached.
Thanks for updating the patch!
The patch looks good to me. But I have three minor comments:
In pg_stat_statements--1.1.sql
+/* contrib/pg_stat_statements/pg_stat_statements--1.0.sql */
Typo: s/1.0/1.1
In pg_stat_statements--1.0--1.1.sql, we should complain if script is sourced
in psql, as follows?
\echo Use "ALTER EXTENSION pg_stat_statements UPDATE TO '1.1'" to
load this file. \quit
+DATA = pg_stat_statements--1.1.sql pg_stat_statements--1.0--1.1.sql \
+ pg_stat_statements--unpackaged--1.0.sql
Though I'm not familiar with CREATE EXTENSION. Why did you exclude 1.0.sql
from DATA? In hstore/Makefile, 1.0.sql is included. You think we should prevent
old version (i.e., 1.0) of pg_stat_statements from being used in 9.2?
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center