On Mon, Feb 20, 2012 at 2:49 AM, Fujii Masao <masao.fujii@gmail.com> wrote:
> In pg_stat_statements--1.0--1.1.sql, we should complain if script is sourced
> in psql, as follows?
>
> \echo Use "ALTER EXTENSION pg_stat_statements UPDATE TO '1.1'" to
> load this file. \quit
Yeah, maybe. I don't know if we want to put that in every file
forever, but I guess it probably makes sense to do it here.
> +DATA = pg_stat_statements--1.1.sql pg_stat_statements--1.0--1.1.sql \
> + pg_stat_statements--unpackaged--1.0.sql
>
> Though I'm not familiar with CREATE EXTENSION. Why did you exclude 1.0.sql
> from DATA? In hstore/Makefile, 1.0.sql is included. You think we should prevent
> old version (i.e., 1.0) of pg_stat_statements from being used in 9.2?
I'm not sure. My feeling is that we probably don't want to ship all
the old scripts forever. People should install the latest version,
and use the upgrade scripts to get there if they have an older one.
So my gut feeling here is to change hstore to exclude that file rather
than adding it here. Any other opinions?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company