On Tue, Dec 27, 2016 at 12:23 PM, Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp> wrote: > Hello, > > At Mon, 26 Dec 2016 14:24:33 +0100, Pavel Stehule <pavel.stehule@gmail.com> wrote in <CAFj8pRD2qq6v0jm6kqmWMwo-yNSvn8Vvf+m=DBy3ps=Y0_3yPA@mail.gmail.com> > pavel.stehule> 2016-12-26 9:40 GMT+01:00 Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp >> >: >> >> > > Thanks for reviewing but I ran out of time for this CF.. >> > > >> > > I'm going to move this to the next CF. >> > >> > I splitted the patch into small pieces. f3fd531 conflicted to >> > this so rebased onto the current master HEAD. >> > >> > 0001 is psql_completion refactoring. >> > 0002-0003 are patches prividing new infrastructures. >> > 0004 is README for the infrastructures. >> > 0005 is letter-case correction of SET/RESET/SHOW using 0002. >> > 0006-0008 are improvements of recursive syntaxes using 0001 and 0004. >> > 0009-0016 are simplifying (maybe) completion code per syntax. >> > >> > The last one (0017) is the IF(NOT)EXIST modifications. It >> > suggests if(not)exists for syntaxes already gets object >> > suggestion. So some kind of objects like operator, cast and so >> > don't get an if.. suggestion. Likewise, I intentionally didn't >> > modified siggestions for "TEXT SEARCH *". >> > >> > >> lot of patches. I hope I look on these patches this week. > > Thank you for looking this and sorry for the many files. But I > hople that they would be far easier to read.
The current patch status was "waiting on author", but that's incorrect as a new series of this patch has been sent. Please be careful with the status of the CF app! I am moving it to next CF with "needs review". Gerdan Santos has marked himself as a reviewer of the patch but I saw no activity, so I have removed his name to not confuse people looking for patches to review (that happens!).
I tested new set of these patches and I found some regressions there - mentioned in my last mail.
Maybe I miss new update, bit I don't know about it.