Re: User management functionality patch [pgadmin4]
| От | Harshal Dhumal |
|---|---|
| Тема | Re: User management functionality patch [pgadmin4] |
| Дата | |
| Msg-id | CAFiP3vyZ7yweg4RGt41b1KTyJGo-v6sPJ-kK2u8_bnoYhS0-Ng@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: User management functionality patch [pgadmin4] (Dave Page <dpage@pgadmin.org>) |
| Ответы |
Re: User management functionality patch [pgadmin4]
|
| Список | pgadmin-hackers |
Hi,
On Fri, Jun 3, 2016 at 4:39 PM, Dave Page <dpage@pgadmin.org> wrote:
Fixed the issue to not to show error immediately. Also role cell does not lose focus after tab hit, it is select2 cell which does not respond to focus-in event of tab. This is general issue for all select2 cells.
I'm not convinced that to deny superuser from closing dialog for his mistakes (accidental mistakes).
Consider a case when superuser clears email for any old user inadvertently (obviously this won't reflect on server). At this point there is no proper way that he can roll back or close the dialog without saving it if we disable close button. He has to either enter correct email for that user or refresh the browser.
Fixed.
On Fri, Jun 3, 2016 at 11:37 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:Hi Harshal,Dave asked to put the User Management menu under the 'Change Password' (right top side).
Done
Correct - that way it won't be displayed in desktop mode. Other comments:- If I type an email address, then hit tab to select a Role, I immediately get an error saying that the role cannot be empty and the control loses focus. I should be able to add a user using just the keyboard.
Fixed the issue to not to show error immediately. Also role cell does not lose focus after tab hit, it is select2 cell which does not respond to focus-in event of tab. This is general issue for all select2 cells.
- In general I'm seeing validation errors before I've had a chance to enter values. I should only see them if the appropriate field has lost focus.
Fixed.
- Role names should be "Administrator" and "User".
Fixed (set ConfidDB to 10 before applying this patch if any of previous patch was applied.)
- The Close button should be disabled if errors are present.
I'm not convinced that to deny superuser from closing dialog for his mistakes (accidental mistakes).
Consider a case when superuser clears email for any old user inadvertently (obviously this won't reflect on server). At this point there is no proper way that he can roll back or close the dialog without saving it if we disable close button. He has to either enter correct email for that user or refresh the browser.
Another case while adding new user if he plans not to add user then he has to clear that partially filled user from grid before he can close the dialog.
Let me know if we still want to implement this.
- If I enter all the details for a new user and then hit Close, the dialog is closed and the new user is NOT added. I have to click something else first so the row loses focus, and then click close.
I was not able to reproduce this issue. I tried with both close buttons (top-right and bottom-right). Users were created in both the cases by adding all details and directly closing dialog without clicking anywhere on the dialog.
- The styling of the Add button and header does not match other grids (blue background for the header, title in white on the left, grey "ADD" button with no icon. The search box should be pushed right, to the left of the button as well I think.
Fixed.
- s/Search by email/Filter by email- s/New Password/New password- s/Confirm Password/Confirm password
Fixed.
- The font on the Close button doesn't match what's on the properties dialogues (looks like a global issue)
Fixed.
- The minimum size of the dialogue should be set such that the dialogue is usable at mimimum size, e.g. all columns shown, with 2 rows.
Fixed.
--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Вложения
В списке pgadmin-hackers по дате отправления:
Следующее
От: Surinder KumarДата:
Сообщение: [pgAdmin4][Patch]: RM#1184 - Re-docking on the main tabset is broken