Re: PATCH: pgAdmin4 windows installer

Hi

On Fri, Jun 3, 2016 at 2:45 PM, Paresh More <paresh.more@enterprisedb.com> wrote:

Hello Dave

Attached is the updated patch for pgAdmin 4 windows

- Windows x86 and amd64 check is added, so now on 32 machine if amd64 is selected it would not allow to generate installer.

- check is added which will check if any mismatch in QT(msvc) and VC version

Yeah, that is better (e.g. it detected one mismatch), but after I updated Qt so I had 5.5 with the msvc2013 and msvc2013_64 kits installed, it would still let me try to build a 32 bit package with msvc2013_64.

 

And all issues which you mentioned are also fixed.

Not entirely:

Error on line 101 in C:\Users\dpage\Documents\pgadmin4\pkg\win32\installer.iss: Column 3:

Semicolon (';') expected.

Compile aborted.

- A number of tabs have crept back into Make.bat after I replaced them all with '    ' last time.

I've fixed a few more tabs, and tidied up the README and Make.bat some more. Please find attached. I've still yet to get a working installer out.

Thanks.

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company