Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling

Поиск
Список
Период
Сортировка
От Joao De Almeida Pereira
Тема Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling
Дата
Msg-id CAE+jjak8u54w4wjYNtO0tVpD6-w+2cuEA7M7c8+XvCP6fPYP=Q@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling  (Dave Page <dpage@pgadmin.org>)
Ответы Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling  (Dave Page <dpage@pgadmin.org>)
Список pgadmin-hackers
Дерево обсуждения

Hello Dave,
Did you use the latest one patch we sent?
We realised that this was an issue in the second email we sent.
Thanks
Joao

On Thu, Jul 20, 2017, 8:15 AM Dave Page <dpage@pgadmin.org> wrote:
Hi

On Wed, Jul 19, 2017 at 8:33 PM, Shruti Iyer <siyer@pivotal.io> wrote:
Hi again!

Attached are the most updated patches. We found an issue with the previous implementation. So we generated the new patches.

The 01 patch fails linting:

/Users/dpage/git/pgadmin4/web/regression/javascript/history/query_history_spec.jsx
  188:9   error  Expected indentation of 10 spaces but found 8   indent
  196:7   error  Expected indentation of 8 spaces but found 6    indent
  198:7   error  Expected indentation of 8 spaces but found 6    indent
  202:12  error  Expected indentation of 10 spaces but found 11  indent
  205:11  error  Expected indentation of 8 spaces but found 10   indent
  212:9   error  Expected indentation of 10 spaces but found 8   indent
  214:11  error  Expected indentation of 8 spaces but found 10   indent
  217:11  error  Expected indentation of 12 spaces but found 10  indent
  219:9   error  Expected indentation of 6 spaces but found 8    indent 

Can you please fix that up and double-check the tests pass?

Thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Dave Page
Дата:
Сообщение: Re: [pgAdmin4][Patch]: To make session more secure in web mode
Следующее
От: Murtuza Zabuawala
Дата:
Сообщение: Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor