Обсуждение: [pgadmin4][PATCH] Query History Arrow Navigation and Styling

On Thu, Jul 20, 2017 at 2:18 PM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:

Hello Dave,
Did you use the latest one patch we sent?
We realised that this was an issue in the second email we sent.

Just checked again, and yes, that was the third and latest version I've received.. 

 

Thanks
Joao

On Thu, Jul 20, 2017, 8:15 AM Dave Page <dpage@pgadmin.org> wrote:

Hi

On Wed, Jul 19, 2017 at 8:33 PM, Shruti Iyer <siyer@pivotal.io> wrote:

Hi again!

Attached are the most updated patches. We found an issue with the previous implementation. So we generated the new patches.

The 01 patch fails linting:

/Users/dpage/git/pgadmin4/web/regression/javascript/history/query_history_spec.jsx

  188:9   error  Expected indentation of 10 spaces but found 8   indent

  196:7   error  Expected indentation of 8 spaces but found 6    indent

  198:7   error  Expected indentation of 8 spaces but found 6    indent

  202:12  error  Expected indentation of 10 spaces but found 11  indent

  205:11  error  Expected indentation of 8 spaces but found 10   indent

  212:9   error  Expected indentation of 10 spaces but found 8   indent

  214:11  error  Expected indentation of 8 spaces but found 10   indent

  217:11  error  Expected indentation of 12 spaces but found 10  indent

  219:9   error  Expected indentation of 6 spaces but found 8    indent 

Can you please fix that up and double-check the tests pass?

Thanks.

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Hi Dave,

In our previous email, the second patch fixed the linting issue from the first patch. 

However, we've remade these two patches so they both pass the linting test.

Thanks,

Matt and João

On Thu, Jul 20, 2017 at 12:56 PM, Dave Page <dpage@pgadmin.org> wrote:

On Thu, Jul 20, 2017 at 2:18 PM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:

Hello Dave,
Did you use the latest one patch we sent?
We realised that this was an issue in the second email we sent.

Just checked again, and yes, that was the third and latest version I've received.. 

 

Thanks
Joao

On Thu, Jul 20, 2017, 8:15 AM Dave Page <dpage@pgadmin.org> wrote:

Hi

On Wed, Jul 19, 2017 at 8:33 PM, Shruti Iyer <siyer@pivotal.io> wrote:

Hi again!

Attached are the most updated patches. We found an issue with the previous implementation. So we generated the new patches.

The 01 patch fails linting:

/Users/dpage/git/pgadmin4/web/regression/javascript/history/query_history_spec.jsx

  188:9   error  Expected indentation of 10 spaces but found 8   indent

  196:7   error  Expected indentation of 8 spaces but found 6    indent

  198:7   error  Expected indentation of 8 spaces but found 6    indent

  202:12  error  Expected indentation of 10 spaces but found 11  indent

  205:11  error  Expected indentation of 8 spaces but found 10   indent

  212:9   error  Expected indentation of 10 spaces but found 8   indent

  214:11  error  Expected indentation of 8 spaces but found 10   indent

  217:11  error  Expected indentation of 12 spaces but found 10  indent

  219:9   error  Expected indentation of 6 spaces but found 8    indent 

Can you please fix that up and double-check the tests pass?

Thanks.

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Ah, OK - I was working on them one at a time.

Thanks, patches applied!

On Thu, Jul 20, 2017 at 7:01 PM, Matthew Kleiman <mkleiman@pivotal.io> wrote:

Hi Dave,

In our previous email, the second patch fixed the linting issue from the first patch. 

However, we've remade these two patches so they both pass the linting test.

Thanks,

Matt and João

On Thu, Jul 20, 2017 at 12:56 PM, Dave Page <dpage@pgadmin.org> wrote:

On Thu, Jul 20, 2017 at 2:18 PM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:

Hello Dave,
Did you use the latest one patch we sent?
We realised that this was an issue in the second email we sent.

Just checked again, and yes, that was the third and latest version I've received.. 

 

Thanks
Joao

On Thu, Jul 20, 2017, 8:15 AM Dave Page <dpage@pgadmin.org> wrote:

Hi

On Wed, Jul 19, 2017 at 8:33 PM, Shruti Iyer <siyer@pivotal.io> wrote:

Hi again!

Attached are the most updated patches. We found an issue with the previous implementation. So we generated the new patches.

The 01 patch fails linting:

/Users/dpage/git/pgadmin4/web/regression/javascript/history/query_history_spec.jsx

  188:9   error  Expected indentation of 10 spaces but found 8   indent

  196:7   error  Expected indentation of 8 spaces but found 6    indent

  198:7   error  Expected indentation of 8 spaces but found 6    indent

  202:12  error  Expected indentation of 10 spaces but found 11  indent

  205:11  error  Expected indentation of 8 spaces but found 10   indent

  212:9   error  Expected indentation of 10 spaces but found 8   indent

  214:11  error  Expected indentation of 8 spaces but found 10   indent

  217:11  error  Expected indentation of 12 spaces but found 10  indent

  219:9   error  Expected indentation of 6 spaces but found 8    indent 

Can you please fix that up and double-check the tests pass?

Thanks.

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Jul 21, 2017 at 12:34 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:

On Jul 21, 2017 4:23 PM, "Dave Page" <dpage@pgadmin.org> wrote:

On Fri, Jul 21, 2017 at 11:05 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:

Hi,

On Fri, Jul 21, 2017 at 2:24 PM, Dave Page <dpage@pgadmin.org> wrote:

Hi

On Fri, Jul 21, 2017 at 9:38 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:

Hi,

Currently if user clicks on empty white area below history entry then arrow navigation does not work.

Attached patch fixes this issue.

This fixes that problem, but stops it working if I *don't* click on the white area first. We need both I think :-)

Yes we need both. Please find updated patch

Why all the changes to yarn.lock?

Are there? I can't see any changes.

Huh, no, you're right. Looks like my machine is rewriting it for some reason. I'll dig deeper.

Sorry for the noise.

 

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company