Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling

Поиск

Список

Период

Сортировка

От	Dave Page
Тема	Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling
Дата	20 июля 2017 г. 18:15:17
Msg-id	CA+OCxozGimecEvO2xGqpQ6243D-v7kheMFKaxRpJ+mvwt+P5Pw@mail.gmail.com обсуждение исходный текст
Ответ на	Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling (Shruti Iyer <siyer@pivotal.io>)
Ответы	Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling (Joao De Almeida Pereira <jdealmeidapereira@pivotal.io>)
Список	pgadmin-hackers

On Wed, Jul 19, 2017 at 8:33 PM, Shruti Iyer <siyer@pivotal.io> wrote:

Hi again!

Attached are the most updated patches. We found an issue with the previous implementation. So we generated the new patches.

The 01 patch fails linting:

/Users/dpage/git/pgadmin4/web/regression/javascript/history/query_history_spec.jsx

188:9 error Expected indentation of 10 spaces but found 8 indent

196:7 error Expected indentation of 8 spaces but found 6 indent

198:7 error Expected indentation of 8 spaces but found 6 indent

202:12 error Expected indentation of 10 spaces but found 11 indent

205:11 error Expected indentation of 8 spaces but found 10 indent

212:9 error Expected indentation of 10 spaces but found 8 indent

214:11 error Expected indentation of 8 spaces but found 10 indent

217:11 error Expected indentation of 12 spaces but found 10 indent

219:9 error Expected indentation of 6 spaces but found 8 indent

Can you please fix that up and double-check the tests pass?

Thanks.

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

В списке pgadmin-hackers по дате отправления:

От: Dave Page
Дата: 20 июля 2017 г., 18:10:09
Сообщение: Re: [RM2074][[RM2080]][pgAdmin4] handle large bytea and bytea[] datain datagrid

От: pgAdmin 4 Jenkins
Дата: 20 июля 2017 г., 18:15:52
Сообщение: Jenkins build is back to normal : pgadmin4-master-python26 #370