On Wed, Jul 27, 2016 at 6:46 PM, Robert Haas <robertmhaas@gmail.com> wrote:
> On Wed, Jul 27, 2016 at 2:20 AM, Amit Kapila <amit.kapila16@gmail.com> wrote:
>> Okay, that makes sense to me apart from minor issue reported by
>> Andrew. I think we might want to slightly rephrase the comments on
>> top of copyParamList() which indicates only about dynamic parameter
>> hooks.
>
> I don't see why it needs to be changed - can you explain in more
> detail what you have in mind?
>
Basically after this function, usage of ParamListInfo doesn't need to
care for value of paramMask as you have already ignored the required
params. I think it is quite apparent from the code, but as the
similar information is mention for dynamic parameter hooks, I thought
we might want to update it. If you don't feel the need of same, then
leave it as it is.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com