> On Wed, 26 Sep 2018 at 05:33, Michael Paquier <michael@paquier.xyz> wrote:
>
> On Tue, Sep 25, 2018 at 01:39:59PM +0200, Dmitry Dolgov wrote:
> > Shouldn't it be fixed by adding EventTriggerAlterTableStart? Judging from the
> > following call of ATController, we can just pass NULL as parsetree.
>
> Hmm. I don't think that this is correct as this data could always be
> used to fetch a command tag, right? It seems to me instead that we
> should pass down IndexStmt and handle things like the attached.
> Thoughts?
Yes, you're right. Although probably it's not great that the sequence of
EventTriggerAlterTableStart, EventTriggerAlterTableRelid and
EventTriggerAlterTableEnd is distributed between different functions (which
most likely is worth a comment in AlterTableInternal), but it's a minor
concern.